Received-SPF: softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   greearb@candelatech.com
To:     linux-wireless@vger.kernel.org
Cc:     Ben Greear <greearb@candelatech.com>
Subject: [PATCH 2/2] mt76: mt7915:  improve logging around unhandled events.
Date:   Mon,  4 Apr 2022 15:50:58 -0700
Message-Id: <20220404225058.32475-2-greearb@candelatech.com>
In-Reply-To: <20220404225058.32475-1-greearb@candelatech.com>
References: <20220404225058.32475-1-greearb@candelatech.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

From: Ben Greear <greearb@candelatech.com>

It would be good to know of events that firmware is sending that
the driver does not currently handle.

Signed-off-by: Ben Greear <greearb@candelatech.com>
---
 .../net/wireless/mediatek/mt76/mt76_connac_mcu.h   |  1 +
 drivers/net/wireless/mediatek/mt76/mt7915/mcu.c    | 14 ++++++++++++--
 2 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
index c3c93338d56a..272b107b7e91 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
+++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
@@ -820,6 +820,7 @@ enum {
 	MCU_EXT_EVENT_CSA_NOTIFY = 0x4f,
 	MCU_EXT_EVENT_BCC_NOTIFY = 0x75,
 	MCU_EXT_EVENT_MURU_CTRL = 0x9f,
+	MCU_EXT_EVENT_IGMP_FLOODING = 0xBD, /* Seen on 7915 */
 };
 
 enum {
diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
index d09cf89c4505..83af8e2ca95f 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
@@ -487,7 +487,13 @@ mt7915_mcu_rx_ext_event(struct mt7915_dev *dev, struct sk_buff *skb)
 	case MCU_EXT_EVENT_BCC_NOTIFY:
 		mt7915_mcu_rx_bcc_notify(dev, skb);
 		break;
+	case MCU_EXT_EVENT_IGMP_FLOODING:
+	case MCU_EXT_EVENT_PS_SYNC:
+		/* ignore some we know we do not care about */
+		break;
 	default:
+		/* in SDK, grep for EventExtEventHandler */
+		dev_info(dev->mt76.dev, "mt7915, unhandled rx_ext_event: 0x%x", rxd->ext_eid);
 		break;
 	}
 }
@@ -502,6 +508,7 @@ mt7915_mcu_rx_unsolicited_event(struct mt7915_dev *dev, struct sk_buff *skb)
 		mt7915_mcu_rx_ext_event(dev, skb);
 		break;
 	default:
+		dev_info(dev->mt76.dev, "mt7915, unhandled unsolicited event: 0x%x", rxd->eid);
 		break;
 	}
 	dev_kfree_skb(skb);
@@ -2090,7 +2097,7 @@ static int mt7915_load_patch(struct mt7915_dev *dev)
 	case PATCH_NOT_DL_SEM_SUCCESS:
 		break;
 	default:
-		dev_err(dev->mt76.dev, "Failed to get patch semaphore\n");
+		dev_err(dev->mt76.dev, "Failed to get patch semaphore: %d", sem);
 		return -EAGAIN;
 	}
 
@@ -2530,8 +2537,11 @@ int mt7915_mcu_init(struct mt7915_dev *dev)
 	}
 
 	ret = mt7915_load_firmware(dev);
-	if (ret)
+	if (ret) {
+		dev_info(dev->mt76.dev, "mcu-init: Failed to load firmware, err: %d",
+			 ret);
 		return ret;
+	}
 
 	set_bit(MT76_STATE_MCU_RUNNING, &dev->mphy.state);
 
-- 
2.20.1