Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Sender: Larry Finger <larry.finger@gmail.com>
Message-ID: <57ff87e5-2012-1253-c98a-10bc9ad54441@lwfinger.net>
Date:   Sun, 3 Apr 2022 19:28:20 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH] wireless: Change Kconfig to select WEXT_PRIV
Content-Language: en-US
To:     Johannes Berg <johannes@sipsolutions.net>,
        Kalle Valo <kvalo@kernel.org>
Cc:     linux-wireless@vger.kernel.org
References: <20220403181431.21811-1-Larry.Finger@lwfinger.net>
 <3e30cdabeb1d1a33f16a41d86f8b660a996a0d0e.camel@sipsolutions.net>
From:   Larry Finger <Larry.Finger@lwfinger.net>
In-Reply-To: <3e30cdabeb1d1a33f16a41d86f8b660a996a0d0e.camel@sipsolutions.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/3/22 14:20, Johannes Berg wrote:
> On Sun, 2022-04-03 at 13:14 -0500, Larry Finger wrote:
>> File net/wireless/Kconfig contains two blind configuration variables,
>> namely WEXT_PRIV and WEXT_SPY. If those variables are already in the
>> configuration file, they will be retained, but there is no way to
>> set them if they are missing other than to manually edit .config.
>> They should be enabled if either WIRELESS_EXT or CFG80211_WEXT are set
>> in the same manner as WEXT_CORE and WEXT_PROC.
>>
>> Personally, the setting of WEXT_SPY is not important; however, openSUSE
>> and Ubuntu both enable it in their default kernels. Other distros have
>> not been checked, but it is likely that they also enable that setting.
>>
> 
> They're intentionally this way though - they're only selected by the
> (few) drivers that need them.
> 
> Yeah, out of tree drivers lose out, but we don't really care?

Unfortunately, I do. At least I now know enough to turn those two on before they 
cause me any problems. Until yesterday, my configuration files were OK. I'm not 
sure what happened.

@Kalle - please drop this patch.

Larry