Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <3e30cdabeb1d1a33f16a41d86f8b660a996a0d0e.camel@sipsolutions.net>
Subject: Re: [PATCH] wireless: Change Kconfig to select WEXT_PRIV
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Larry Finger <Larry.Finger@lwfinger.net>,
        Kalle Valo <kvalo@kernel.org>
Cc:     linux-wireless@vger.kernel.org
Date:   Sun, 03 Apr 2022 21:20:44 +0200
In-Reply-To: <20220403181431.21811-1-Larry.Finger@lwfinger.net>
References: <20220403181431.21811-1-Larry.Finger@lwfinger.net>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 (3.42.4-1.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sun, 2022-04-03 at 13:14 -0500, Larry Finger wrote:
> File net/wireless/Kconfig contains two blind configuration variables,
> namely WEXT_PRIV and WEXT_SPY. If those variables are already in the
> configuration file, they will be retained, but there is no way to
> set them if they are missing other than to manually edit .config.
> They should be enabled if either WIRELESS_EXT or CFG80211_WEXT are set
> in the same manner as WEXT_CORE and WEXT_PROC.
> 
> Personally, the setting of WEXT_SPY is not important; however, openSUSE
> and Ubuntu both enable it in their default kernels. Other distros have
> not been checked, but it is likely that they also enable that setting.
> 

They're intentionally this way though - they're only selected by the
(few) drivers that need them.

Yeah, out of tree drivers lose out, but we don't really care?

johannes