Received-SPF: softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <a0f3d677-e3a8-ecef-a17e-0638764bd425@linux.intel.com>
Date:   Mon, 4 Apr 2022 16:29:10 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH net-next v5 08/13] net: wwan: t7xx: Add data path
 interface
Content-Language: en-US
To:     Sergey Ryazanov <ryazanov.s.a@gmail.com>
Cc:     netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
        Jakub Kicinski <kuba@kernel.org>,
        David Miller <davem@davemloft.net>,
        Johannes Berg <johannes@sipsolutions.net>,
        Loic Poulain <loic.poulain@linaro.org>,
        M Chetan Kumar <m.chetan.kumar@intel.com>,
        chandrashekar.devegowda@intel.com,
        Intel Corporation <linuxwwan@intel.com>,
        chiranjeevi.rapolu@linux.intel.com,
        =?UTF-8?B?SGFpanVuIExpdSAo5YiY5rW35YabKQ==?= 
        <haijun.liu@mediatek.com>, amir.hanania@intel.com,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        dinesh.sharma@intel.com, eliot.lee@intel.com,
        ilpo.johannes.jarvinen@intel.com, moises.veleta@intel.com,
        pierre-louis.bossart@intel.com, muralidharan.sethuraman@intel.com,
        Soumya.Prakash.Mishra@intel.com, sreehari.kancharla@intel.com,
        madhusmita.sahu@intel.com
References: <20220223223326.28021-1-ricardo.martinez@linux.intel.com>
 <20220223223326.28021-9-ricardo.martinez@linux.intel.com>
 <CAHNKnsTZ57hZfy_CTv8-AXuXJEuYVCaO0oax03eMMYzerB-Oyw@mail.gmail.com>
From:   "Martinez, Ricardo" <ricardo.martinez@linux.intel.com>
In-Reply-To: <CAHNKnsTZ57hZfy_CTv8-AXuXJEuYVCaO0oax03eMMYzerB-Oyw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Sergey,

On 3/6/2022 6:58 PM, Sergey Ryazanov wrote:
> On Thu, Feb 24, 2022 at 1:35 AM Ricardo Martinez
> <ricardo.martinez@linux.intel.com> wrote:
>> From: Haijun Liu <haijun.liu@mediatek.com>
>>
>> Data Path Modem AP Interface (DPMAIF) HIF layer provides methods
>> for initialization, ISR, control and event handling of TX/RX flows.
>>
>> DPMAIF TX
>> Exposes the `dmpaif_tx_send_skb` function which can be used by the
>> network device to transmit packets.
>> The uplink data management uses a Descriptor Ring Buffer (DRB).
>> First DRB entry is a message type that will be followed by 1 or more
>> normal DRB entries. Message type DRB will hold the skb information
>> and each normal DRB entry holds a pointer to the skb payload.
>>
>> DPMAIF RX
>> The downlink buffer management uses Buffer Address Table (BAT) and
>> Packet Information Table (PIT) rings.
>> The BAT ring holds the address of skb data buffer for the HW to use,
>> while the PIT contains metadata about a whole network packet including
>> a reference to the BAT entry holding the data buffer address.
>> The driver reads the PIT and BAT entries written by the modem, when
>> reaching a threshold, the driver will reload the PIT and BAT rings.
...
>> +static int t7xx_dpmaif_add_skb_to_ring(struct dpmaif_ctrl *dpmaif_ctrl, struct sk_buff *skb)
>> +{
>> +       unsigned short cur_idx, drb_wr_idx_backup;
>> ...
>> +       txq = &dpmaif_ctrl->txq[skb_cb->txq_number];
>> ...
>> +       cur_idx = txq->drb_wr_idx;
>> +       drb_wr_idx_backup = cur_idx;
>> ...
>> +       for (wr_cnt = 0; wr_cnt < payload_cnt; wr_cnt++) {
>> ...
>> +               bus_addr = dma_map_single(dpmaif_ctrl->dev, data_addr, data_len, DMA_TO_DEVICE);
>> +               if (dma_mapping_error(dpmaif_ctrl->dev, bus_addr)) {
>> +                       dev_err(dpmaif_ctrl->dev, "DMA mapping fail\n");
>> +                       atomic_set(&txq->tx_processing, 0);
>> +
>> +                       spin_lock_irqsave(&txq->tx_lock, flags);
>> +                       txq->drb_wr_idx = drb_wr_idx_backup;
>> +                       spin_unlock_irqrestore(&txq->tx_lock, flags);
> What is the purpose of locking here?

The intention is to protect against concurrent access of drb_wr_idx by t7xx_txq_drb_wr_available()

>
>> +                       return -ENOMEM;
>> +               }
>> ...
>> +       }
>> ...
>> +}
>