Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp103750pxb; Tue, 5 Apr 2022 01:32:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxY+BYvxLuQY9PBXozTuXctJofurOzI019D/ouml4cjY3rZP9E/LdWb1nfNtSir4SSKNCoI X-Received: by 2002:a63:4463:0:b0:381:3c1e:7299 with SMTP id t35-20020a634463000000b003813c1e7299mr1982645pgk.490.1649147537372; Tue, 05 Apr 2022 01:32:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649147537; cv=none; d=google.com; s=arc-20160816; b=Pvz6EN6j6NB4LGCwAXJrBzAzWqNnjHXGu7aS7XmNFIt1QTSz1TBwqrfjs7m/KO79LU rE1Rh7reJZ0tbmnN3/5UygAJi2CDX3UwavhnFxMhd+gBsP9RtCNDEnqX0WUjWx8C9pSx BQCVQXFmEbU9skoQsqn+zKmi92r1eLWAy1YkYGUhHG3y1rqzbh3gRbvlTbFvOy0LGe7U HxtjCSqWwqk1H6TDxQc1koVc+QWof0W0wiOCJKkypSQtuwX+uhXb+YHtUUnGLaZyZg2Q rFyAg+YSJ9Nt4AsQnMXwN3XiVDG4VKo0KkdkW5O2znknbCf4Nko5sitnH2Aj4m2WAXjz v0dA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=UDGuCB5rq2jSFCPOpSKnwf4tfMOMS4M/21T0sL8jSUU=; b=nsW1NQsJv+ZG5AG3Qfu9aDgpEHkhlNfYJtRwKnUDBkNRg0FcIkahQ0NK7yx1xR8Y1F DJdPndGCnxI9VFkZtDf6woqbI02JLLtOd86aTt0F3Wk0nC+c8Qa/jUfb9xASPB/F8u68 3VEgoM+DGyHNumg3u215KK92peu1oxH0DB6rcU0G07iB3fa08kv6rcpgolDn5cTOmUbH lDuvferYZkeiJoY3mFq9fmYM3DBjUwKwyBRzUpE0hc4nwjLIAnC+WQiY9Lb7eRLx4NT6 xciHPV3bevFl8p1q8BTi358HvwoqIzr18bunwMiSCF/yHFYao2UKv7JYyaevI/Vstr+E jN8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="RRvQs/ew"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h7-20020a056a00170700b004fa843103dbsi13202523pfc.193.2022.04.05.01.31.52; Tue, 05 Apr 2022 01:32:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="RRvQs/ew"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234374AbiDEIZH (ORCPT + 69 others); Tue, 5 Apr 2022 04:25:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238686AbiDEITR (ORCPT ); Tue, 5 Apr 2022 04:19:17 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B0731AF1D for ; Tue, 5 Apr 2022 01:09:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AE06BB81B18 for ; Tue, 5 Apr 2022 08:09:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66635C385A0; Tue, 5 Apr 2022 08:09:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649146157; bh=VzMbINFNTvSENLG/I6ooncrp2ypoqck+oxssEZccqoM=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=RRvQs/ew/vr6siHZtExBHLT9lWLJNq8Hyy4R9/QXp7goNUlHhRv5ouiMwqvaym8nS KW4UrRfoLi8M+IRhl/WIajFgH0jx31qT3ibM9ZFQrAHYdqRlZ69JFr4akgquE80Yfd V1tnoHoTaYjq3BDO1Fj3lO8/3IjN7HLvqiRG0siMp5r/YC+cjF+birFgWxCppUzAxC VvDmsjqvYw/5WKT9MnoNdmnb4frQKfqNcCimdVDHvvNvs4bwF+DR0K3GPtAmb8/W5r Q4F/B1EBeYk/vuJWtsDH4Lgg2Pxzpu+KG1fLu3PrDFEWOVEvDt5o870PXs+mn7XCLm EJIcfYqJOZPFA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] ath11k: Change max no of active probe SSID and BSSID to fw capability From: Kalle Valo In-Reply-To: <20220329150221.21907-1-quic_kathirve@quicinc.com> References: <20220329150221.21907-1-quic_kathirve@quicinc.com> To: Karthikeyan Kathirvel Cc: , , Karthikeyan Kathirvel User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <164914615451.12306.2945099051936753478.kvalo@kernel.org> Date: Tue, 5 Apr 2022 08:09:16 +0000 (UTC) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Karthikeyan Kathirvel wrote: > The maximum number of SSIDs in a for active probe requests is currently > reported as 16 (WLAN_SCAN_PARAMS_MAX_SSID) when registering the driver. > The scan_req_params structure only has the capacity to hold 10 SSIDs. > This leads to a buffer overflow which can be triggered from > wpa_supplicant in userspace. When copying the SSIDs into the > scan_req_params structure in the ath11k_mac_op_hw_scan route, it can > overwrite the extraie pointer. > > Firmware supports 16 ssid * 4 bssid, for each ssid 4 bssid combo probe > request will be sent, so totally 64 probe requests supported. So > set both max ssid and bssid to 16 and 4 respectively. Remove the > redundant macros of ssid and bssid. > > Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.7.0.1-01300-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Karthikeyan Kathirvel > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 50dc9ce9f805 ath11k: Change max no of active probe SSID and BSSID to fw capability -- https://patchwork.kernel.org/project/linux-wireless/patch/20220329150221.21907-1-quic_kathirve@quicinc.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches