Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp1040662pxb; Wed, 6 Apr 2022 07:19:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz+wgCIXklOpceo2YHylwjNT0VgwhH5Bk9ByxF6QMK10z3gisX23vsiU5te/yzRkxvSpvPE X-Received: by 2002:a17:902:db0c:b0:154:1b36:6a7a with SMTP id m12-20020a170902db0c00b001541b366a7amr9012994plx.36.1649254780095; Wed, 06 Apr 2022 07:19:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649254780; cv=none; d=google.com; s=arc-20160816; b=mkx0MRfKtypEU4R7l4cpPNZAnOpWJJ266GkIo8j9/RcKkfY4GdluFIgEGzRoK9I7lg mFATh5Wkx9y9QCIEJJ2bHjvyDdnA7IGtbNYblv1os2p6TCK8S3lYBjAqK09OjGppVmpy RaM6sCDWBpBcBHNrR6KOLwK6EJVxgOQr+cq0zvyAc1W4UcO8CqjrQRXZQ6/2plEKYb4Y AlIDK5bWI4+zHV753xGL7sWOhyZXek6BOyBdq6jK+A8xrojLdW0w1Fs4raCSwQvFFGbZ b7vn0LzKpMChM7a1/NqcR+DEfk4cHfQGJm9Gecp4jMYqx+3Nki/Sh3yYL88h8cgTanov kwtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=W17BNFASO72ATARDog8DYv0kRzk9qsJ6U9QrlDwkrhw=; b=KqVqEuJTkb5QnsgHa5egIPRfWEa4U9dbAESMKSZV75osD73yJM+z35nwtxB+nMtSg4 cW9u9TtXhfqUNqtBbgsV7b6LAS/mTThbvrcn9a32ndmMcTWNPFhqjoDOXxv+eY+UqmSa akYVqJuDt/SxkBAZ6+mWTo15OuQA0Mjr5T5wnip5if5z9eo963O9dVNvsr707/VR5fVB o7dZBwL90wFUCMna9E9eytSXtqxO2HcRy+FQ6TmfJ55vwuK6jkDnKYSsNIN/+Nzsk3kM z3FYDqak0hoMBh4H9Upkl7trrJQnBpUl3iWV4suW4OTib1efSGvb4+3WgNVGf6XmOV7r W87Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PmHI2AXs; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id mh12-20020a17090b4acc00b001bd14e0308fsi6016329pjb.103.2022.04.06.07.19.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 07:19:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PmHI2AXs; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id F1CEC47CDFF; Wed, 6 Apr 2022 05:05:19 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229655AbiDFLs2 (ORCPT + 69 others); Wed, 6 Apr 2022 07:48:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232139AbiDFLsB (ORCPT ); Wed, 6 Apr 2022 07:48:01 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07C984B1945 for ; Wed, 6 Apr 2022 01:39:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 075F160DDD for ; Wed, 6 Apr 2022 08:34:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9CD1C385A1; Wed, 6 Apr 2022 08:34:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649234063; bh=yHI4cCsChblsBPcn58Gc84jVaku3lU6eMPwbk92lODQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=PmHI2AXstj0TP/ZEFAhot17q52TFFM1hV8ocf24IJ+BWH8X99RkP3QrsDvJ4fugxt yBYxczrDgxV/UbmL8RWrU5ej506Vbb5FG8aSd1sqHS39cIqxBBcq5E7AYkQVm4UQV7 sznx7sKwMfBeLSQPLsF0NpNs/N0hECsoHMjwXIFespt/KAsnPjsZ4vPLEHlz2cRsR/ zAm8qRJK+sGiPeXqC5RbaG7BcXap6aRn8gl3rDRgcSqWXEuZK6EYjzvIKR9ofzfazf axrG/+0s/lp2Ypelx+35lFvkHku2EJ2MVoKrEKPhSGGhk3JM9eq/lgLeOGUndUupkr LuClG5wOBRgBg== From: Kalle Valo To: ath11k@lists.infradead.org Cc: linux-wireless@vger.kernel.org Subject: Re: [PATCH 1/3] ath11k: mhi: remove state machine References: <20220401173042.17467-2-kvalo@kernel.org> <164923162903.31835.17335207502754178945.kvalo@kernel.org> Date: Wed, 06 Apr 2022 11:34:17 +0300 In-Reply-To: <164923162903.31835.17335207502754178945.kvalo@kernel.org> (Kalle Valo's message of "Wed, 6 Apr 2022 07:53:51 +0000 (UTC)") Message-ID: <87wng2pq46.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Kalle Valo writes: > Kalle Valo wrote: > >> State machines are difficult to understand and in this case it's just useless, >> which is shown by the diffstat. So remove it entirely to make the code simpler. >> >> No functional changes. >> >> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03003-QCAHSPSWPL_V1_V2_SILICONZ_LITE-2 >> Signed-off-by: Kalle Valo > > 3 patches applied to ath-next branch of ath.git, thanks. > > 5fe7847bb63b ath11k: mhi: remove state machine > 4afe7c40380e ath11k: mhi: add error handling for suspend and resume > 7dabaa64c04a ath11k: mhi: remove unnecessary goto from ath11k_mhi_start() I accidentally had a wrong commit in ath-next so to remove that I had to rebase these three commits. The new commit ids are: 121210ec935c ath11k: mhi: remove state machine 3e80fcbca372 ath11k: mhi: add error handling for suspend and resume b9e34ba6b314 ath11k: mhi: remove unnecessary goto from ath11k_mhi_start() -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches