Received-SPF: softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Kalle Valo <kvalo@kernel.org>
To:     Meng Tang <tangmeng@uniontech.com>
Cc:     davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] ipw2x00: use DEVICE_ATTR_*() macro
References: <20220406015444.14408-1-tangmeng@uniontech.com>
Date:   Wed, 06 Apr 2022 12:58:31 +0300
In-Reply-To: <20220406015444.14408-1-tangmeng@uniontech.com> (Meng Tang's
        message of "Wed, 6 Apr 2022 09:54:44 +0800")
Message-ID: <87r16apm7s.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Meng Tang <tangmeng@uniontech.com> writes:

> Use DEVICE_ATTR_*() helper instead of plain DEVICE_ATTR,
> which makes the code a bit shorter and easier to read.
>
> Signed-off-by: Meng Tang <tangmeng@uniontech.com>
> ---
>  drivers/net/wireless/intel/ipw2x00/ipw2100.c |  64 +++++-----
>  drivers/net/wireless/intel/ipw2x00/ipw2200.c | 119 +++++++++----------
>  2 files changed, 90 insertions(+), 93 deletions(-)

You have submitted a similar (or identical?) patch earlier:

https://patchwork.kernel.org/project/linux-wireless/patch/20220401053138.17749-1-tangmeng@uniontech.com/

If you submit a new patch mark it as v2 and include a changelog. Please
read our documentation:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches