Received-SPF: softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH v2] mwifiex: add mutex lock for call in
 mwifiex_dfs_chan_sw_work_queue
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20220321225515.32113-1-dossche.niels@gmail.com>
References: <20220321225515.32113-1-dossche.niels@gmail.com>
To:     Niels Dossche <dossche.niels@gmail.com>
Cc:     linux-wireless@vger.kernel.org,
        Amitkumar Karwar <amitkarwar@gmail.com>,
        Ganapathi Bhat <ganapathi017@gmail.com>,
        Sharvari Harisangam <sharvari.harisangam@nxp.com>,
        Xinming Hu <huxinming820@gmail.com>,
        Brian Norris <briannorris@chromium.org>,
        Niels Dossche <dossche.niels@gmail.com>
User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <164924545655.19026.5921699639764275443.kvalo@kernel.org>
Date:   Wed,  6 Apr 2022 11:44:19 +0000 (UTC)
Precedence: bulk

Niels Dossche <dossche.niels@gmail.com> wrote:

> cfg80211_ch_switch_notify uses ASSERT_WDEV_LOCK to assert that
> net_device->ieee80211_ptr->mtx (which is the same as priv->wdev.mtx)
> is held during the function's execution.
> mwifiex_dfs_chan_sw_work_queue is one of its callers, which does not
> hold that lock, therefore violating the assertion.
> Add a lock around the call.
> 
> Disclaimer:
> I am currently working on a static analyser to detect missing locks.
> This was a reported case. I manually verified the report by looking
> at the code, so that I do not send wrong information or patches.
> After concluding that this seems to be a true positive, I created
> this patch.
> However, as I do not in fact have this particular hardware,
> I was unable to test it.
> 
> Reviewed-by: Brian Norris <briannorris@chromium.org>
> Signed-off-by: Niels Dossche <dossche.niels@gmail.com>

Patch applied to wireless-next.git, thanks.

3e12968f6d12 mwifiex: add mutex lock for call in mwifiex_dfs_chan_sw_work_queue

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220321225515.32113-1-dossche.niels@gmail.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches