Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <fb02ab86-4c7f-8303-621d-349ac8c25546@quicinc.com>
Date:   Wed, 6 Apr 2022 10:02:31 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH v2] cw1200: fix incorrect check to determine if no element
 is found in list
Content-Language: en-US
To:     Kalle Valo <kvalo@kernel.org>,
        Xiaomeng Tong <xiam0nd.tong@gmail.com>
CC:     <pizza@shaftnet.org>, <davem@davemloft.net>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <linville@tuxdriver.com>,
        <linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <jakobkoschel@gmail.com>
References: <20220320035436.11293-1-xiam0nd.tong@gmail.com>
 <164924475461.19026.8095141212129340061.kvalo@kernel.org>
From:   Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <164924475461.19026.8095141212129340061.kvalo@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/6/2022 4:32 AM, Kalle Valo wrote:
> Xiaomeng Tong <xiam0nd.tong@gmail.com> wrote:
> 
>> The bug is here: "} else if (item) {".
>>
>> The list iterator value will *always* be set and non-NULL by
>> list_for_each_entry(), so it is incorrect to assume that the iterator
>> value will be NULL if the list is empty or no element is found in list.
>>
>> Use a new value 'iter' as the list iterator, while use the old value
>> 'item' as a dedicated pointer to point to the found element, which
>> 1. can fix this bug, due to now 'item' is NULL only if it's not found.
>> 2. do not need to change all the uses of 'item' after the loop.
>> 3. can also limit the scope of the list iterator 'iter' *only inside*
>>     the traversal loop by simply declaring 'iter' inside the loop in the
>>     future, as usage of the iterator outside of the list_for_each_entry
>>     is considered harmful. https://lkml.org/lkml/2022/2/17/1032
>>
>> Fixes: a910e4a94f692 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN chipsets")
>> Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
> 
> Can someone review this, please?
> 

Reviewed-by: Jeff Johnson <quic_jjohnson@quicinc.com>