Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <907e5b13-ceaa-4ae3-9d61-a0a5d0eab20b@quicinc.com>
Date:   Wed, 6 Apr 2022 10:18:40 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 2/7] cfg80211: add a function for reporting TX status with
 hardware timestamps
Content-Language: en-US
To:     Luca Coelho <luca@coelho.fi>, <johannes@sipsolutions.net>,
        <kvalo@kernel.org>
CC:     <gregory.greenman@intel.com>, <linux-wireless@vger.kernel.org>
References: <20220406120924.979792-1-luca@coelho.fi>
 <iwlwifi.20220406145756.721e5cd5a682.I411bb8c79a26ffb33898bea2075f6779c7da0cb4@changeid>
From:   Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <iwlwifi.20220406145756.721e5cd5a682.I411bb8c79a26ffb33898bea2075f6779c7da0cb4@changeid>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/6/2022 5:09 AM, Luca Coelho wrote:
> From: Avraham Stern <avraham.stern@intel.com>
> 
> Add a function for reporting TX status with hardware timestamps. This
> function shall be used for reporting the TX status of Timing
> measurement and Fine timing measurement action frames by devices that
> support reporting hardware timestamps.
> 
> Signed-off-by: Avraham Stern <avraham.stern@intel.com>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> ---
>   include/net/cfg80211.h | 47 ++++++++++++++++++++++++++++++++++++++++--
>   net/wireless/nl80211.c | 42 ++++++++++++++++++++++++-------------
>   2 files changed, 73 insertions(+), 16 deletions(-)
> 
> diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
> index 68713388b617..13c2ad88adb1 100644
> --- a/include/net/cfg80211.h
> +++ b/include/net/cfg80211.h
> @@ -7574,6 +7574,38 @@ static inline bool cfg80211_rx_mgmt(struct wireless_dev *wdev, int freq,
>   				    flags);
>   }
>   
> +/**
> + * struct cfg80211_tx_status - TX status for management frame information
> + *
> + * @cookie: Cookie returned by cfg80211_ops::mgmt_tx()
> + * @tx_tstamp: hardware TX timestamp in nanoseconds
> + * @ack_tstamp: hardware ack RX timestamp in nanoseconds
> + * @buf: Management frame (header + body)
> + * @len: length of the frame data
> + * @ack: Whether frame was acknowledged
> + */
> +struct cfg80211_tx_status {
> +	u64 cookie;
> +	u64 tx_tstamp;
> +	u64 ack_tstamp;
> +	const u8 *buf;
> +	size_t len;
> +	bool ack;
> +};
> +
> +/**
> + * cfg80211_mgmt_tx_status_ext - TX status notification with extended info
> + * @wdev: wireless device receiving the frame
> + * @status: TX status data
> + * @gfp: context flags
> + *
> + * This function is called whenever a management frame was requested to be
> + * transmitted with cfg80211_ops::mgmt_tx() to report the TX status of the
> + * transmission attempt with extended info.
> + */
> +void cfg80211_mgmt_tx_status_ext(struct wireless_dev *wdev,
> +				 struct cfg80211_tx_status *status, gfp_t gfp);

can/should status be const?

snipping the rest, but consider for all cases where status is now passed 
as a struct pointer

/jeff