Received: by 2002:a05:6a10:83d0:0:0:0:0 with SMTP id o16csp163508pxh; Thu, 7 Apr 2022 17:31:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw3wZvZoA4ZYtrjeiHwHizTdE01VPKxkiC92RiixY4jbTE4Z9w1jc6lB5z+4by3ZhERFSan X-Received: by 2002:a05:6a00:14d5:b0:4fb:2adf:dcdd with SMTP id w21-20020a056a0014d500b004fb2adfdcddmr16870866pfu.72.1649377879181; Thu, 07 Apr 2022 17:31:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649377879; cv=none; d=google.com; s=arc-20160816; b=HAEVoyEZUD25A/dQTeqtRtVqChdF/lu3Nq5g+xLI3pQdjvTqiZDQgZTTjgrLcJsDO3 c9Zj1nFgc5aZ4tOy6++CPZThy02OOpFW7JC4dBxK9RTm/74NuBWCSaHr7bpEp+y8xUDU yncCI3hHbBTHirqnoc7UEyXeW5V3ovzDyx2ZLGoxtcu0GZZN2Z3LsUXl1ips32v+bY9W OaL2zoNyzIooC+R85QSLPRGnoiSaygN+odxtDpEqE4bYC+lgDIgYsSc8hawIGdeAbZ4w RDVX2w/23CJUu+vIBFTGKFmc7CZGO6pxzn94g1RcldR3bomta2gDuhpfF0l63hXk6kSR Ai3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=6SvL+PrDiumEXgMKH0ujFZRbikX1D8ZqgSVL+GfIgUQ=; b=1BrJuv+bsc4xND6/TlCGltfSt7evhCPvhOZP1wdltYfBiTvw7NhNXoyKwD89IYP2HO SR7UD0qYlSeeKycLHbuHkL/OVbOPUKAtmvVK20eL6AOi9Gkq/Pert+rNWOhyYAeEXdKB sfP/NZre1l7iI6LKsIYs27KcPNs6p/nsyQJYRQTvZb3KQUtvwfBYuuqIb+CgSBaS93+L 79Ep7JZvFWWTYlonD+LB0QzxizF+ePZ0sgqtAsmrMLp/faU/x6YfgScBlAYbwbWEAopb AdBX/oQMtuEVRVN0K2JwHU0sgbZhG+Mc/ozNGo4e0Hg7XKMp+/yI0fZsdIqkk4Wr4lsU pmDg== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id 32-20020a630a20000000b00398b859041esi20073093pgk.255.2022.04.07.17.31.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Apr 2022 17:31:19 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AD116223BFC; Thu, 7 Apr 2022 17:01:30 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232718AbiDHAD0 (ORCPT + 69 others); Thu, 7 Apr 2022 20:03:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232702AbiDHADX (ORCPT ); Thu, 7 Apr 2022 20:03:23 -0400 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D98821F95E9; Thu, 7 Apr 2022 17:01:21 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R601e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04426;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=12;SR=0;TI=SMTPD_---0V9SkcgY_1649376078; Received: from localhost(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0V9SkcgY_1649376078) by smtp.aliyun-inc.com(127.0.0.1); Fri, 08 Apr 2022 08:01:18 +0800 From: Yang Li To: kvalo@kernel.org Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, loic.poulain@linaro.org, toke@toke.dk, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Li , Abaci Robot Subject: [PATCH -next 2/2] ath9k: Remove unnecessary print function dev_err() Date: Fri, 8 Apr 2022 08:01:13 +0800 Message-Id: <20220408000113.129906-2-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c In-Reply-To: <20220408000113.129906-1-yang.lee@linux.alibaba.com> References: <20220408000113.129906-1-yang.lee@linux.alibaba.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org The print function dev_err() is redundant because platform_get_irq_byname() already prints an error. Eliminate the follow coccicheck warning: ./drivers/net/wireless/ath/ath9k/ahb.c:103:2-9: line 103 is redundant because platform_get_irq() already prints an error Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/net/wireless/ath/ath9k/ahb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/ahb.c b/drivers/net/wireless/ath/ath9k/ahb.c index c9b853af41d1..9cd12b20b18d 100644 --- a/drivers/net/wireless/ath/ath9k/ahb.c +++ b/drivers/net/wireless/ath/ath9k/ahb.c @@ -99,10 +99,8 @@ static int ath_ahb_probe(struct platform_device *pdev) } irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(&pdev->dev, "no IRQ resource found\n"); + if (irq < 0) return irq; - } ath9k_fill_chanctx_ops(); hw = ieee80211_alloc_hw(sizeof(struct ath_softc), &ath9k_ops); -- 2.20.1.7.g153144c