Received: by 2002:a05:6a10:144:0:0:0:0 with SMTP id 4csp243906pxw; Fri, 8 Apr 2022 06:36:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwb93I2DuQkGV2xUHLKhswoZRZLofnLIJuA1i/0t7+o0WWHipzz0fcX4s8sC68/dR+BRxo6 X-Received: by 2002:a17:907:72c7:b0:6e8:442c:1722 with SMTP id du7-20020a17090772c700b006e8442c1722mr5035100ejc.120.1649424961790; Fri, 08 Apr 2022 06:36:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649424961; cv=none; d=google.com; s=arc-20160816; b=eeRYnD2qJG6QBp3BCaoNzfWLYPGAIRwI8yYYrTubwd0DSfTgiNpR4YhMarK7Jsaz4v CrNmurpy/0vscCrCt25SJ6FeUHxmsmcrrmcWJSWzIebHDvfhTdhY6AgZIpO2LIAnEpoX S1AZrTwYvkBGmdLl0FiPhhTrM9rPLsCl7dMI8iwRFJbJlI032KI3Hl3SGZfFEpU1KYBf LaccoqVVBPz1zFQAe3CNqrnOTYr4NeCkU5goulueDox5cbQ5AeaQ8Unk2909GMOOPmgI XO7Wye/ECAf3uR7Zioo9O4UVwBeJFsB3qNMZ00ulK8RQf7Mct8Ggknom5DHkyKMnm/Ej cm3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:references:in-reply-to:subject:cc:to:dkim-signature :from; bh=zivYut1AiMU4O2qsRQrApqir8I1ZCtnVZttACI98ZsU=; b=oMTVC5csYJ7XjzkwtDIgnRGOV7q2vRNV2KXj+fvbltGmMCNgqMWn2v4z1tKeDQz6ju p/jKeck3wh0tuqgJ/brVk+jq/djYSiFA6sn3MY3nYxM4HR52D4FdN7ckaAMb7HvnahCq TQQtJkYlo/zYWpWMzEdk0cVIqfjW5OYMUmgXcwxkXtnqcI071cF/OfScZ6snsA0NwPkv vmmsE/6lUInbAlsz6dZ69XN+bearXbSV2zddgImWAQJle1gWkTTOS/qmWNpJ51ZdBrnH Hp+TwjXWYRajBI4Hvju3wWNl8SBQdsDuhmfh58vyTjYUqjHP1PkHzEHmCNmXPCYEEZRD eXiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@toke.dk header.s=20161023 header.b=JHPHxpd7; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=toke.dk Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id la18-20020a170907781200b006e840b0ba86si999347ejc.335.2022.04.08.06.35.34; Fri, 08 Apr 2022 06:36:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@toke.dk header.s=20161023 header.b=JHPHxpd7; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=toke.dk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235221AbiDHLzs (ORCPT + 69 others); Fri, 8 Apr 2022 07:55:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232152AbiDHLzp (ORCPT ); Fri, 8 Apr 2022 07:55:45 -0400 Received: from mail.toke.dk (mail.toke.dk [IPv6:2a0c:4d80:42:2001::664]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A15F7DE0B; Fri, 8 Apr 2022 04:53:39 -0700 (PDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1649418816; bh=zivYut1AiMU4O2qsRQrApqir8I1ZCtnVZttACI98ZsU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=JHPHxpd7Y6BHAvmVpiYcZHXKmphnE0W2EJDlgJg1iujP7WCLJj5uzJGMuVd4a4Pmv aRPf75G5493uN3+C/eYwK0j1SHL0+jaITiixsMxrulPhn/vcP2sKMYZo0dv3MaXCix RoGabv5HCLnY/b3LjwEvO41wSx5uymKIrupuOOkdNaUF9BR9icljuhXqVyidFXPcvu AiHY90NxRJSuVj3OKnHEGgUJ9s9dBBog/it08ChgV0l6sczoJGQ/0GcwBgjLa144Lg x2Bqt0gYsjdijYYDpLSe4Kpfo+PCW6WA4WWMWbUP+YEuF9YtrY5oG42PW/coD8F8et 0A/dgrYVYVCqA== To: Yang Li , kvalo@kernel.org Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, loic.poulain@linaro.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Li , Abaci Robot Subject: Re: [PATCH -next 2/2] ath9k: Remove unnecessary print function dev_err() In-Reply-To: <20220408000113.129906-2-yang.lee@linux.alibaba.com> References: <20220408000113.129906-1-yang.lee@linux.alibaba.com> <20220408000113.129906-2-yang.lee@linux.alibaba.com> Date: Fri, 08 Apr 2022 13:53:35 +0200 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87h77394g0.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Yang Li writes: > The print function dev_err() is redundant because > platform_get_irq_byname() already prints an error. > > Eliminate the follow coccicheck warning: > ./drivers/net/wireless/ath/ath9k/ahb.c:103:2-9: line 103 is redundant > because platform_get_irq() already prints an error > > Reported-by: Abaci Robot > Signed-off-by: Yang Li Heh, so I was the one originally insisting on keeping that err print, but looking a bit closer now it does really appear to be redundant, so: Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen