Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH 5/6] mt76: mt7915: enable radar background detection
To:     Lorenzo Bianconi <lorenzo@kernel.org>, nbd@nbd.name
Cc:     lorenzo.bianconi@redhat.com, linux-wireless@vger.kernel.org,
        ryder.lee@mediatek.com, evelyn.tsai@mediatek.com,
        owen.peng@mediatek.com
References: <cover.1641996493.git.lorenzo@kernel.org>
 <f97a4fe5bec70d8e5594c0f4d286b46b844939a5.1641996493.git.lorenzo@kernel.org>
From:   Ben Greear <greearb@candelatech.com>
Organization: Candela Technologies
Message-ID: <70c4ecc0-cfc6-e924-6578-3314dca42d75@candelatech.com>
Date:   Mon, 11 Apr 2022 14:46:53 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <f97a4fe5bec70d8e5594c0f4d286b46b844939a5.1641996493.git.lorenzo@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/12/22 6:13 AM, Lorenzo Bianconi wrote:
> Notify userland the hw supports background radar/CAC detection.

So, what about someone like me using mtk7915 4x4 radio from asia-rf?  It
has no extra RF chains afaik, and it is certainly broken when
trying to use DFS channels on my system.

Maybe you need a positive check instead of negative check before
enabling this feature?

Thanks,
Ben

> 
> Tested-by: Owen Peng <owen.peng@mediatek.com>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
>   drivers/net/wireless/mediatek/mt76/mt7915/init.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/init.c b/drivers/net/wireless/mediatek/mt76/mt7915/init.c
> index 5c1643963506..91c7ce60f296 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7915/init.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7915/init.c
> @@ -309,6 +309,7 @@ static void
>   mt7915_init_wiphy(struct ieee80211_hw *hw)
>   {
>   	struct mt7915_phy *phy = mt7915_hw_phy(hw);
> +	struct mt76_dev *mdev = &phy->dev->mt76;
>   	struct wiphy *wiphy = hw->wiphy;
>   	struct mt7915_dev *dev = phy->dev;
>   
> @@ -337,6 +338,12 @@ mt7915_init_wiphy(struct ieee80211_hw *hw)
>   	wiphy_ext_feature_set(wiphy, NL80211_EXT_FEATURE_BEACON_RATE_VHT);
>   	wiphy_ext_feature_set(wiphy, NL80211_EXT_FEATURE_BEACON_RATE_HE);
>   
> +	if (!mdev->dev->of_node ||
> +	    !of_property_read_bool(mdev->dev->of_node,
> +				   "mediatek,disable-radar-background"))
> +		wiphy_ext_feature_set(wiphy,
> +				      NL80211_EXT_FEATURE_RADAR_BACKGROUND);
> +
>   	ieee80211_hw_set(hw, HAS_RATE_CONTROL);
>   	ieee80211_hw_set(hw, SUPPORTS_TX_ENCAP_OFFLOAD);
>   	ieee80211_hw_set(hw, SUPPORTS_RX_DECAP_OFFLOAD);
> 


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com