Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp763327pxb; Tue, 12 Apr 2022 12:49:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyFJwTN1cxfX9HAmFrE5gn4ke4678JhdB24LB7gWrwpQqAcRhrTyyl3qZD5LHduu0K0ba35 X-Received: by 2002:a63:1141:0:b0:39c:b664:c508 with SMTP id 1-20020a631141000000b0039cb664c508mr26336122pgr.49.1649792945297; Tue, 12 Apr 2022 12:49:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649792945; cv=none; d=google.com; s=arc-20160816; b=zk7tiJLGvaXoLPFjE0C4jxrbSJenpYuada/lHCHAgkqp0Nz4vSU+X9AB1itRI4TZKA m4UYmSVm2drxi3/o8vHh9DBafj41wJHq+Hooq8lo8+sdq9GKorOtzPKLvGDxQvEhSeEx f7/8lVEoJnUA482PEIua1/d2Yf3HozN2Rm+om/RuSDXjkv85mgM2I4mC7RhPBneBRxuY xW3uHNvAyoMffWqB83wKZpeUJUWuIzyNkDD9w8uAoSo7xG7OBu6Fx2MA53yyGK/97XMk TApKvoxKwcb6UoCiGnNTfeYhCD4NRwuRjfrvXeeO0dH3t2QdFIHWn4Nbc5fefs3U001d 3TfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=dhHwA3F2FQftO6pEZ0j/0p+3amxo82F+h1rNav10MQw=; b=ZVe/0Ay2wrOV9okDV6iB3QXXKsw916QGXTa4aY7JEg2cdibHo8J4L1UaMYlN1VuuIB J5YOGy3Fg6MiWn6bmYZb8tJeV++NrK3vzjhVzxzbVkKnA6tAs5QH6ehmFMIYrGDLzcL4 EkwGD5BJ+Lud6oJaoOa86SuYV8t//c3SDVYaQtS7SutgFMijQkBU/QcWldOGsMAfy1xs OC5BH8bf91LJBX7itQKFm+Gahi/rDw7BpsE2oxXaudcAEJ1m5knMoV00+bBwYHSl6mB/ 9ImOUmEaor2Q4ObK6VyFYfsxHEWutMOQFJQCYC6L6voLG5j8psOeiOD6Ph3qYX+gV1Jy /8ig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Uk22QgIv; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id c2-20020a634e02000000b0039cf6436c9esi3150520pgb.468.2022.04.12.12.49.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 12:49:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Uk22QgIv; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D3DAB24596; Tue, 12 Apr 2022 12:44:58 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243239AbiDLNjx (ORCPT + 70 others); Tue, 12 Apr 2022 09:39:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234919AbiDLNju (ORCPT ); Tue, 12 Apr 2022 09:39:50 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D9762E092; Tue, 12 Apr 2022 06:37:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4B9DCB81D7A; Tue, 12 Apr 2022 13:37:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 857E1C385A1; Tue, 12 Apr 2022 13:37:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649770649; bh=v0nDaaCQ3usmsYxnhE/FHNZck2HIGICmWaiMBdencwI=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=Uk22QgIvlCLGqhttJUlJHTKFNSZX3+X8U3p7zjNDrYvQZ51Q+P+X/ad8ErHVMVOVB AbsreyM2rucCIm8k3sOR9v5RGUoilV/1m6IzSXvTJ5VW+WDsOrwwC61nkO+ItW/MSV 23oD+7nfadTQw0idWgv8adiHLZGLOanERg0NgFEHS2ODvDLmfhqqVe3jpVVHccqGts JIkq8FvcNzgNVvGqIDsMdr09ViFum4BZiR55Zq672PyUeOAJDUURNLOf3RkCKAiX44 geNC39ZapXVaX88pE0H4QQ66mC9DgYk8RMs6nV0vuKqKnhEF8zpmInujfPFmMs+0L+ 8cjrQNJwae/vQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] rtw89: ser: add a break statement From: Kalle Valo In-Reply-To: <20220407175349.3053362-1-trix@redhat.com> References: <20220407175349.3053362-1-trix@redhat.com> To: Tom Rix Cc: pkshih@realtek.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, nathan@kernel.org, ndesaulniers@google.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Tom Rix User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <164977064177.31115.17806762798615887989.kvalo@kernel.org> Date: Tue, 12 Apr 2022 13:37:26 +0000 (UTC) X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Tom Rix wrote: > The clang build fails with > ser.c:397:2: error: unannotated fall-through > between switch labels [-Werror,-Wimplicit-fallthrough] > default: > ^ > The case above the default does not have a break. > So add one. > > Signed-off-by: Tom Rix > Reviewed-by: Nathan Chancellor I took Zong's version: https://patchwork.kernel.org/project/linux-wireless/patch/20220408001353.17188-2-pkshih@realtek.com/ Patch set to Superseded. -- https://patchwork.kernel.org/project/linux-wireless/patch/20220407175349.3053362-1-trix@redhat.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches