Received-SPF: softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Tue, 12 Apr 2022 16:29:18 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Kalle Valo <kvalo@kernel.org>
Cc:     Toke =?iso-8859-1?Q?H=F8iland-J=F8rgensen?= <toke@toke.dk>,
        Oleksij Rempel <linux@rempel-privat.de>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "John W. Linville" <linville@tuxdriver.com>,
        linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ath9k_htc: fix potential out of bounds access with
 invalid rxstatus->rs_keyix
Message-ID: <20220412132918.GQ12805@kadam>
References: <20220409061225.GA5447@kili>
 <87tub26ir2.fsf@toke.dk>
 <875yneo2jh.fsf@kernel.org>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <875yneo2jh.fsf@kernel.org>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?FNJlftX8tUPpUi4fRGsfZsKM4dSRT9yIPsL1BeIHLnEa7WHSYc5DMvbjRq?=
 =?iso-8859-1?Q?b9WPLkbtd6IOcNC1tJ0PZG5jbonmDzFGSfqVhHU4WsLKIu17Bx0di9kvQP?=
 =?iso-8859-1?Q?lQumgsmbqfhPyBx0ex0AdscvIKD5YP3oXdpYl2YLQYxPC/WD2QUO9PEilo?=
 =?iso-8859-1?Q?1QIJwMHheGhN+BCydPGmWDIMFjyhMfB3mqjjzeq57A01OnTci8w/7iH5ix?=
 =?iso-8859-1?Q?NocBP0TwhZ6MU2mODXvm/WHBiBwRFBz5D6BeqnWWXpBdOuEa9/s0Pm0t1J?=
 =?iso-8859-1?Q?+MR4H0wQGfoQ6JuKS32FYPVnKSNBmhOzGBAoShdFrjoqXDLAOFg09siSRs?=
 =?iso-8859-1?Q?P4GZzVGF4YuU78oxNDxI9d18ClLIPpnw1Y6H8RhGTDRK6TbAg6Txfpb/yf?=
 =?iso-8859-1?Q?+RAg/SN93SFr4Ge+KUHN/yg2K0FeexpUwrmnYCYi0ceAmDThFfnUZ7eiXU?=
 =?iso-8859-1?Q?Knc8hUiIUhTqFwCs4owura6RhV7YO28Yp71hjRpALZZ4hnSjBYxYPUTpAG?=
 =?iso-8859-1?Q?A/sBZPMJPlcf6k4CcTBfL/lqOtrVuzwycgv7KMADP4cZa4fOGcPnQmsyN3?=
 =?iso-8859-1?Q?W8iqRbKKxIIc7M1B4Xov5dmp9T9kp86o7TmF01F32uB9CkEisUhspDAHvb?=
 =?iso-8859-1?Q?SZMY1fqGh6GQgXymZw96sySm0meh6FF99eXv4JUyAMytkcoPHZHQPxWu//?=
 =?iso-8859-1?Q?R8a6Qn1MUfy6YKARjDhVs/2cUJzcEN8gT9Kp5MnssWmK21qnVyPRiqi/Gt?=
 =?iso-8859-1?Q?hOc1hl9dCQ+mpf/azrgUNO/fxfjllzQHfUCBZ52meSoDu3jKTKrf1Kzztg?=
 =?iso-8859-1?Q?V7U93kxfqtSkChVq4Nl5iggJhs48N8L6mZAqPODAysdws8d389np9gw34u?=
 =?iso-8859-1?Q?eZB2BHnXfxgy1uuD5aK9ZYusA7QikUBN6plm8HCFTuQ8akAF/dApUmyDsf?=
 =?iso-8859-1?Q?V74oCN5v8Fo80gVa+q+/BrKYLCY1pEU/HUFNsFQnfIA4yc3SNQCX/OJws1?=
 =?iso-8859-1?Q?KSwKfEzHIEijRJt6RsyIS4J/Zh3fq/xwswOwqCuYfmxiHVjTi49KschPUJ?=
 =?iso-8859-1?Q?AZmNVjd6vv43QUkQ88lkWbeNQzEqrKwMb+Y04bjlL2hcwakyWqKVjjcaSX?=
 =?iso-8859-1?Q?LBXe3LuiIzYB7cJB7HRHExebGvmOO1wLK2qHfEzTdXo+bxI4yU7/F4jGKp?=
 =?iso-8859-1?Q?bwOWKose/MPCVBkhSXcIh9wa0zk4K7dRSz4QCDIAhm0hSXv6h9zhY5d4lp?=
 =?iso-8859-1?Q?/pUWtya6hWA55JfmdkMBkGhYjHGCAoxlQBEsFNNeLYibst7PmD4AsFA9bE?=
 =?iso-8859-1?Q?iCPwf7850wJ5kHs1Ol9B27dH8UzhgzMq6kOrb4YY/k3VMELs1xIfo1HvDZ?=
 =?iso-8859-1?Q?QnWVndo5dS1o3f8IQJGH3SP4EoGggsrFRwJUhbDKUbn8Ag5FEPLCTCtfRM?=
 =?iso-8859-1?Q?J10dh9e3kuUI7UuM8Z+fwg5R2Lko44kaOsSXmfTVRPkvPnNncXtDS/oUq1?=
 =?iso-8859-1?Q?T70gqPPN8mYeHfVSCIgbmQnunAbNClDe4S36NmBjaht7KelyquMHaBLwbr?=
 =?iso-8859-1?Q?rGSbgBpm6YS5DZa0UYvseglwADqgLfSjiyfk1Xl4avzG9Ui4jBX5C+taKL?=
 =?iso-8859-1?Q?5dwxp2zz56EnqCGrU4vbITcCetpiPIsTYtCXc6wFw4/bjrvq7okPVAuOtS?=
 =?iso-8859-1?Q?yH2Po7ScIt0PZhv4IJ6djlwtC7jhMJTbPD+2+X6RonYvvwOrijGB4/fks0?=
 =?iso-8859-1?Q?3v4T3LqHIffoED7KDAITqdamKzCuVnA58Kbu/CGo71XMXpXlRdMKEGAYac?=
 =?iso-8859-1?Q?90pA9IPDZ3avJPidVoDaeho1MsdzCTQ=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b2503587-0bad-449c-6498-08da1c8878c8
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2022 13:29:29.5281
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4L+ssECxevyA5vSlexzBdINfPbC2vs4vvksrgLVbfiR5mDLVS2WuGv5XbgRR9nImwHcwON2l8IkvVnQIBH3MbstgjhFh5gFNzllpCsz3QyM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4533
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-12_04:2022-04-11,2022-04-12 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=990 malwarescore=0
 mlxscore=0 phishscore=0 suspectscore=0 spamscore=0 adultscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204120064
X-Proofpoint-GUID: wZeHJDtm8U9JF36dR1BjIwRa9Y8GHmD_
X-Proofpoint-ORIG-GUID: wZeHJDtm8U9JF36dR1BjIwRa9Y8GHmD_
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Tue, Apr 12, 2022 at 04:26:58PM +0300, Kalle Valo wrote:
> Toke H?iland-J?rgensen <toke@toke.dk> writes:
> 
> > Dan Carpenter <dan.carpenter@oracle.com> writes:
> >
> >> The "rxstatus->rs_keyix" eventually gets passed to test_bit() so we need to
> >> ensure that it is within than bitmap.
> >
> > s/than/the/ ?
> >
> > This I think Kalle can fix up when applying :)
> 
> Yup, fixed now in the pending branch.

Thanks!

regards,
dan carpenter