Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp22710pxb; Tue, 12 Apr 2022 15:41:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx2M9ubcW9wqtoz5z/WBjrP55sCnRvwPnDGLECeWb/UB5Zr6nqYxefEkWc9EPIyz4kssrSE X-Received: by 2002:a17:902:7fc2:b0:153:3c90:17b9 with SMTP id t2-20020a1709027fc200b001533c9017b9mr39839140plb.61.1649803312191; Tue, 12 Apr 2022 15:41:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649803312; cv=none; d=google.com; s=arc-20160816; b=u7s+Zzo9PbvmmVlWpREAho2fceXwmfK7XD3PYHBY2Z8BCwh0KwZw48ZWdMOQSpFzRF PHEs4UGhhN+szZ/FfiEE+py1Mc3V32UAWF9M64RBYS/GYkg9HnDPjItT9eWubD0gWrMR MtiSAo8fdlUVTaOooadftL2aplZrXmG24c3nkCW3X4+nyMtDsRXqfGx8C367eglN8F6S hi/GH2ac3t2Zb9N+To8VRPxIWTsjKj7YUdZ+w8CWefsAr9iDcvMeUQQlsmzHQMAKjisx G94fRQGKoiUDg2zjrod+uXZHXLpVFsc2IDpiXm6u4PvN62NJJCHlKbRIEWS8pR8Q12Bo IrFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:message-id:in-reply-to :subject:cc:to:from:date:dkim-signature; bh=ydSXhj/D++q4Bz/3RjGM+cKyo6yUcRljwfCjbzNaWXs=; b=XsamKdt1iObIMtMIPHgz1Y6REmi8ayIzoPxDozzw4SFdbYxEyvU6xDPvpUCqijPwsI 3wRbpWYDAjmbSfd81fh0rH2Z2dWLvAVotxP3fviRDPYlgaUsdj48iMuj/2yQKjeT/yr3 bgq6+gerMWWcIe6FKB+pn519F38wMpUCeBiTZNG2/2gdy+Yb2yTAB6vIfjv1/wtyX+r7 oDfjsLTOQ8OzNgqhxrFNYBUGRU6BsUDt4+SWUvRpFXltugb4a/epB+ZuJoSJnE0lqV9N yMz1B7oH/jlZmjlnQ1gha7ii0bS4Nt8j+sLK0VTJZhpixkzkePvAf7P5GtpF2iEgW4rP d9Yg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=VqzfgHzn; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id i13-20020a65484d000000b0039ce3d3c784si3726588pgs.775.2022.04.12.15.41.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 15:41:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=VqzfgHzn; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 042CD105AAE; Tue, 12 Apr 2022 14:20:27 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355210AbiDLNJM (ORCPT + 70 others); Tue, 12 Apr 2022 09:09:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356041AbiDLNIW (ORCPT ); Tue, 12 Apr 2022 09:08:22 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4B1BBC2F; Tue, 12 Apr 2022 05:54:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649768056; x=1681304056; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=LdY9sTGizeqlCp/hNlojoai4UZdpGD+7RUCYPvX1e2U=; b=VqzfgHznPsX/Vmn4Ld/X4n+YEZQwFnrKd45OtMtaGD4pZhmFfoiVB952 0+P7H5Nyfvpr2YI+84pttCQTGc6rDusfHQl2biYQ8VnrR3+COVjfDm0hO Far2/8pdUZdyyQP91+p9uMaY0fGtBAGIF8rzrSInjXa/oglKHdH4m/Pqt ltyvM5nMsHRzY1fOlpZmFDkqv0SaIhDLat6K7tdQ1uF3AICWPvbBiYJ/n AIDRWy/16nFTJpwSEsv7LLAbVwmxPhQJHv+5bCU2halCnQWCUXPwSG/Zi kMC0TNAB2KZ8rEcs4R9s268DZeZGFqIfhekWoLzkZzRA7DUKeUrq2P3+8 Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10314"; a="242307088" X-IronPort-AV: E=Sophos;i="5.90,253,1643702400"; d="scan'208";a="242307088" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2022 05:54:14 -0700 X-IronPort-AV: E=Sophos;i="5.90,253,1643702400"; d="scan'208";a="572753215" Received: from rsimofi-mobl1.ger.corp.intel.com ([10.252.45.1]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2022 05:54:08 -0700 Date: Tue, 12 Apr 2022 15:54:05 +0300 (EEST) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: Ricardo Martinez cc: Netdev , linux-wireless@vger.kernel.org, kuba@kernel.org, davem@davemloft.net, johannes@sipsolutions.net, ryazanov.s.a@gmail.com, loic.poulain@linaro.org, m.chetan.kumar@intel.com, chandrashekar.devegowda@intel.com, linuxwwan@intel.com, chiranjeevi.rapolu@linux.intel.com, haijun.liu@mediatek.com, amir.hanania@intel.com, Andy Shevchenko , dinesh.sharma@intel.com, eliot.lee@intel.com, moises.veleta@intel.com, pierre-louis.bossart@intel.com, muralidharan.sethuraman@intel.com, Soumya.Prakash.Mishra@intel.com, sreehari.kancharla@intel.com, madhusmita.sahu@intel.com Subject: Re: [PATCH net-next v6 06/13] net: wwan: t7xx: Add AT and MBIM WWAN ports In-Reply-To: <20220407223629.21487-7-ricardo.martinez@linux.intel.com> Message-ID: <7cbb81a8-6bb-599b-3c27-a161622a08d@linux.intel.com> References: <20220407223629.21487-1-ricardo.martinez@linux.intel.com> <20220407223629.21487-7-ricardo.martinez@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thu, 7 Apr 2022, Ricardo Martinez wrote: > From: Chandrashekar Devegowda > > Adds AT and MBIM ports to the port proxy infrastructure. > The initialization method is responsible for creating the corresponding > ports using the WWAN framework infrastructure. The implemented WWAN port > operations are start, stop, and TX. > > Signed-off-by: Chandrashekar Devegowda > Co-developed-by: Ricardo Martinez > Signed-off-by: Ricardo Martinez > > >From a WWAN framework perspective: > Reviewed-by: Loic Poulain > --- > + spin_lock_irqsave(&port->rx_wq.lock, flags); > + port->rx_length_th = 0; > + spin_unlock_irqrestore(&port->rx_wq.lock, flags); ? -- i.