Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   =?ISO-8859-1?Q?J=E9r=F4me?= Pouiller <jerome.pouiller@silabs.com>
To:     linux-wireless <linux-wireless@vger.kernel.org>,
        Kalle Valo <kvalo@kernel.org>,
        Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Subject: Re: [PATCH 09/10] staging: wfx: ensure HIF request has been sent before polling
Date:   Wed, 13 Apr 2022 17:18:52 +0200
Message-ID: <4557835.LvFx2qVVIh@pc-42>
Organization: Silicon Labs
In-Reply-To: <033f49bc-cc31-7384-7a7c-5d3c45ce9594@I-love.SAKURA.ne.jp>
References: <20220225112405.355599-1-Jerome.Pouiller@silabs.com> <20220225112405.355599-10-Jerome.Pouiller@silabs.com> <033f49bc-cc31-7384-7a7c-5d3c45ce9594@I-love.SAKURA.ne.jp>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?wl6H4hbYwsz4H4xJNn9vSZ9KB9RB0EPY9DUA9scg5UoUdgmFiEXAVaDZHl?=
 =?iso-8859-1?Q?g0dMjISMRWMa0nJnIdbs6iTsAGMncgg+7RHxph3vR9fov8g7DofJ8EkfqO?=
 =?iso-8859-1?Q?rue5bQdNgX8BmPpfSn8UNU10o86SVD3oP72G0Grprsv0iEQxvRXfph8tGS?=
 =?iso-8859-1?Q?fmtXkirWKw5kpAs9iYWiwMMA9IhrkY7e0ndNTdv4d/o43EvQP+ueXOYfli?=
 =?iso-8859-1?Q?jcQedaJ2m91OvHi+MP5/N2B7FVNHw1kYN/dog0pD9HwUv3oH2PH1gadH9J?=
 =?iso-8859-1?Q?D64dUDCpp3pwsM6BlAZVn7mQWlrKgiUhkdRA/fq5kX0oY5ZxtoTEwLEw0B?=
 =?iso-8859-1?Q?lrExdAZmMH3LiT05rBI6dW4nCr6oH0jjhG52OIfS0nzQy1/1EsaX1dOaxu?=
 =?iso-8859-1?Q?PVp04GMa9oj27xhe2aVZD/jsZC3xqrCWcKqfB0LIjmP175X5bigF70L8JD?=
 =?iso-8859-1?Q?ElHB638seTQ5aqG0oNSHIuEDFRHwamFxre5lqRHpUqHFDr8XS3FG0ZItp+?=
 =?iso-8859-1?Q?SddgEUVpXdmqtt2Qo1airUZUSNvcr01x6Vhco+rFiOX77EbEA7RK9JcJLn?=
 =?iso-8859-1?Q?lt71tcSDkLKOUkh+opel8hOR24boR0aOVZQQhgHO3wxmUXZFUQpS0qSyIj?=
 =?iso-8859-1?Q?hQkdMezPssX0JODWm59e3e5fIN5nHZwNGai5GQkghj9cZbRJJFNHAxNx5t?=
 =?iso-8859-1?Q?JieD6iQ6cNkpmC96yQXqRgBd7amIHgydoVgT9xbzmYyo8N005sOM7Iy5Qn?=
 =?iso-8859-1?Q?1tzPRfo6nx7KbH1hYZGsbhKJysx5FSFdYq/Nvb2dnYfkcXb7ZWIOkiCn5g?=
 =?iso-8859-1?Q?noxsSkNOa49c+O7gJ3wUOaFcFBaDdpdTiAgzmsCXyc9hDY3Jge+/H8RiWo?=
 =?iso-8859-1?Q?rtz8xfX/cvAemLcjKP/YB30bmH1EwogNJmJVPQxFzadYnQwH72LdysJLKS?=
 =?iso-8859-1?Q?rsEVPWJs85iWC1S+RYxBinzVj8/LMzciI4vcJ+/RP3CyXBLuxmkZlKiHZM?=
 =?iso-8859-1?Q?QjyChMzrm75vOuzmgfR91LQCB0oCcg/iF2oiyYgCa4FLwMjoSRkUMOvNRa?=
 =?iso-8859-1?Q?bESYxN2P0URbmsCPWMJbsa1jBaeyBrwhgAZteysyYtaAPLyP/Gx0GpfYFh?=
 =?iso-8859-1?Q?Kh36XBNt/AXz7MtKQ+mC6RoYSisxtwGX81IIUUBzN0qosTBoucpScCVNuK?=
 =?iso-8859-1?Q?AsjIICHoXC7fCC8+XIvSeczBxHjaiL0yAz2Ju/ZzGP7Jr5Uk0UbijOr0Ta?=
 =?iso-8859-1?Q?dQYnWpZN87ewoDsHiLpISHbTDuuqDLpTBhkTZ5PScghInEvz5fYYHJgqvB?=
 =?iso-8859-1?Q?efj6MYlGtxnkQvi65KgfXzCsFfrVWVSSn6aq+CaBNcrFjjKLrKqJOIxfDK?=
 =?iso-8859-1?Q?RggPXZ0uWYG8UdHDiTcUyJ/TQPZskzuLeiQFvY5lX1F0xJo3e+f/XfEbIO?=
 =?iso-8859-1?Q?FzaH1vyIC88S6tYnVtj9mRazbXIYs4fnLN5G3B7dUWN3vNJ6hxzsQxupB+?=
 =?iso-8859-1?Q?PNzuoRDvJJZeFlIlzn7Y2QCUq6rus3ss8qoFnKNFFoQSBrDISu2DBPLHTO?=
 =?iso-8859-1?Q?zcXUbRN9sy08AjN/Lfhrj+iYldiuVerYkhp/3n8bbg63q6b3DesGzUJ2uL?=
 =?iso-8859-1?Q?v9iC3PB2tJtxv+kwDcEPh12aJA6Su7nxzd3aP8W2WFJUDU8IX6/lGqkwDd?=
 =?iso-8859-1?Q?7FFupz3y8ngrHKxWNlnW49rQBtJ1WNx9lgGM0uaNe4oKbi8vsssorrpIwt?=
 =?iso-8859-1?Q?/sID5FQp4p20eNJXC6uzvLm+mg8fZyjJerKD7EPhpSxM05rtOo4t0RxKZh?=
 =?iso-8859-1?Q?hnQN8RhvDT90e3OiPeiX1muyWCoSg1rQuB13YGOAPQLXCEI9v+Bm6PbURa?=
 =?iso-8859-1?Q?3T?=
X-MS-Exchange-AntiSpam-MessageData-1: ZstJgjF+DvY0Wg==
X-OriginatorOrg: silabs.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f4e1500e-c226-4048-3740-08da1d60ed49
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5657.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2022 15:18:56.5172
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JVjeVCbfN8tHdnCGoH30hM3MqWWZ6WZ3byY2t7j3UP7pAWvfAM/BXLY01qOoevmC7V12WAHaGNEVeMYJtTEv7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2613
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Tuesday 12 April 2022 15:11:53 CEST Tetsuo Handa wrote:
> Hello.
>=20
> I found that commit c86176d51340d5ee ("staging: wfx: ensure HIF request h=
as
> been sent before polling") started using flush_workqueue(system_highpri_w=
q).
>=20
> But please avoid flushing system-wide workqueues, for
> flushing system-wide workqueues is dangerous and will be forbidden.
>=20
> Link: https://lkml.kernel.org/r/49925af7-78a8-a3dd-bce6-cfc02e1a9236@I-lo=
ve.SAKURA.ne.jp
>=20
>=20

There is a workqueue provided by mac80211. But I am not sure it can=20
replace the system-wide workqueue.

I guess I need to declare a new workqueue. Give me a couple of weeks to
prepare a patch.


--=20
J=E9r=F4me Pouiller