Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yihao Han <hanyihao@vivo.com>
To:     Kalle Valo <kvalo@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, ath11k@lists.infradead.org,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     kernel@vivo.com, Yihao Han <hanyihao@vivo.com>
Subject: [PATCH] ath11k: simplify if-if to if-else
Date:   Thu, 14 Apr 2022 02:20:42 -0700
Message-Id: <20220414092042.78152-1-hanyihao@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RR5+AHtPphR6UTnDzYfKyKOx+t5ZcUhiU933CPPLSoDWQ5IRYF3TfiaV6wje?=
 =?us-ascii?Q?7fEXxN8uHE1kyjWrfVpo7lXNP8h+sF2/eUG0mX6zkJh0PzO/V/X7fvU57piN?=
 =?us-ascii?Q?SzjgaprwLxj7Lp/iV9P9A+knCNci6lATZZyAqolHo1yMW80K9OYZ8felIC6d?=
 =?us-ascii?Q?Hy26FipzJbDys/gJLVoiWNRYqgBlGhp3N78uKc4w6K3rAxXOx4bKLgEeCqbG?=
 =?us-ascii?Q?8/PuJi/0NQJTkFVtfWhpGi8La2Ga0vIWSCwKG7jq1lTHzOdzfnteZLVrWShb?=
 =?us-ascii?Q?ft9PjqWtZJoSsh2KmFejrlaTaMHrcNEoDXNBxuWcn7+7d+l0VZxSg//GPa/O?=
 =?us-ascii?Q?dm2sAA7D4DUKjzCtgpHUV72xF6vm9NtgD+FB7A2kN7KmnOd2g9yJ+VtkFFs4?=
 =?us-ascii?Q?sc5ozR6NYMMAkpvgA3O+YjfpRMc005n3EymzPNYRgN21AZrghxUhc6jd+js2?=
 =?us-ascii?Q?Vqoqu+l7ELCU22AO+eFvIHNOxNaJMKSk6AuoWKGz0cBxD3c4qLYpJP7UBQnj?=
 =?us-ascii?Q?MoNbPsI3wEcXDfeXz3OU8LtAcvX4ZXZ3Ei3FzRDL5wG/skaSecSpRhiTNOVF?=
 =?us-ascii?Q?9qZYUgqY8CXpq56zsK+98dLCIj08ujI6BbLuIUza9tY2s41VRXIZiPkfFGmx?=
 =?us-ascii?Q?hv/HK613WQ91yrhCmu03ysseowGF3Ulvxzs2QuxZ09NyIvmUMP9p4dv058O7?=
 =?us-ascii?Q?OOGuU6LQ9wYzoPGo+qV+vjRd7adCb1CzCzIfN5eCWyeJN1dbInxhrP2VxaA+?=
 =?us-ascii?Q?I030C4g9x/FdUiLuKNh5pLpqei6IrNpgD00//Lxz9zaMfzs3YGA+6iJR7D/l?=
 =?us-ascii?Q?Q8XZx6DJFsfVV9UBWtzozwIMX+484qyDhm+dANyRK4iqzeST8jeFtge/mbMs?=
 =?us-ascii?Q?Vn8v1XjjXiZm/1X2Rc+ILKvOVei1kyPB0kMFxKxC+u6OoPP2QhnkmCBNiTBL?=
 =?us-ascii?Q?gXtBXHAOeEnd2i2taJrF4y6hbMaaUcV1P+Tk/evYGLi/5JXFol1oPhd3HG0T?=
 =?us-ascii?Q?KLxJQaDW6uwCLs8Ob3juevx3dj7qXLdZbhc6l4hogG/aBIAi8VC+JW9bNUsT?=
 =?us-ascii?Q?GLSJzLahFXDLcAyOLTWeUFBAld1Q0Pd6GGGpe9JQyMto8QfsuuOYsTBeIN1t?=
 =?us-ascii?Q?8Ae9P587CqQzqF76W5q2AvkSK/PvNgJFUifbYVsF8929k9OZUatt5HXcAeLe?=
 =?us-ascii?Q?YkDbSaUJ7LGA8Ym2pTr9GCCY46wBoCQQpB7X1bCBDWMzdV1mOWVJ45CdoihP?=
 =?us-ascii?Q?Runvgt5gVX+6cgL4WZDGfOCzDsxpAtVTJSGRsW4RHHc+KNV9rbeRPS4IwAWY?=
 =?us-ascii?Q?9Y1T6DUx6DQmwxOylcDCKwPIqpp6qlTygA7ea/TY7MsY31tXKDI3uodg66MS?=
 =?us-ascii?Q?FVy4oz6tF8v6gm2hU+hArQzWsSn+MJIlBjGwduGBLxYnZzwJ5PZCUVoS5Rp4?=
 =?us-ascii?Q?OyvAV5/2cfVulGj2UOnzmBPpWZ9JY7NaJWna40TAuAcdHSJ/71y4vTu0/N1h?=
 =?us-ascii?Q?ew0uiTY2y0v4C7ZBYlzPSma2Ar28ymhUGd/bScr/K7q5gV/u449x4hXpba4A?=
 =?us-ascii?Q?+wczLh75Tvwaa5TA/fEFKB9bWbbuGkwuWlQgNhsSynno+eExhplsydhUgNK+?=
 =?us-ascii?Q?XYRQVUDFgN2fYSXk2XMf4mcI98Ya65uZ9oI9b3h6ZyHC6z/JygGEe/JQJbiY?=
 =?us-ascii?Q?SfTbdeKf33BiegLUy+P2ylXn16PF7KCDQtxhs3BTlOks7ZYu/Kf1WOxJGAg1?=
 =?us-ascii?Q?cZ35xxvb1A=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 36fb2039-e194-4369-5470-08da1df81493
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4173.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2022 09:20:56.2359
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AuTtgXyI+swTFm8yjM/1jPYZQCCavfz3a1YYltd+x6BMJmngvYc2wtQLt5rXQG23AjFFdEsto/yL25TQrj4mpg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB3700
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

Replace `if (!ab->is_reset)` with `else` for simplification
and add curly brackets according to the kernel coding style:

"Do not unnecessarily use braces where a single statement will do."

...

"This does not apply if only one branch of a conditional statement is
a single statement; in the latter case use braces in both branches"

Please refer to:
https://www.kernel.org/doc/html/v5.17-rc8/process/coding-style.html

Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
 drivers/net/wireless/ath/ath11k/core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c
index cbac1919867f..80009482165a 100644
--- a/drivers/net/wireless/ath/ath11k/core.c
+++ b/drivers/net/wireless/ath/ath11k/core.c
@@ -1532,8 +1532,7 @@ static void ath11k_core_restart(struct work_struct *work)
 
 	if (ab->is_reset)
 		complete_all(&ab->reconfigure_complete);
-
-	if (!ab->is_reset)
+	else
 		ath11k_core_post_reconfigure_recovery(ab);
 }
 
-- 
2.17.1