Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp822071pxb; Fri, 15 Apr 2022 12:15:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzN0rvolo49ZADkdXVTpkfUiJBT8XFz1IHaWJPV+X9ASBj5pXBEczkt5VkfL2EbTMVCwF84 X-Received: by 2002:a17:90a:9301:b0:1cb:7363:d76d with SMTP id p1-20020a17090a930100b001cb7363d76dmr5758189pjo.99.1650050149756; Fri, 15 Apr 2022 12:15:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650050149; cv=none; d=google.com; s=arc-20160816; b=N+wju0IRAo3vixkuJiwVr2DD1jXtJfrtqqc8h0vexROzYyCD5QFVhzARJ0jC3jvGND XwVexc77l4Hiltcc6pbu4mWOGLQ5qulysbbCFL19RqeN7Ur0dPfkIpCzBuEVrlliTZEP 5OFl4CrTj9ygbFbbMHEv/HfViXcbhCafynrCKTzaC4OjQ8FNdme1NX5eRx/ZQlFAioIA q+GiV6xu3PTsFjiWXaEtExzrDnEULqe3I1WucQsOh0JdZ1SndYYKqmxMQ0GWJIHSa2Mb A6sNfJu6D83w1WqCHC61u2c72y1Z+0VvSN1cDHBmfHAKJdTIwpN0N7mx5I+23YNOvhD8 3JnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=t2JyKHgJzNVEtMBMT1fofHfCUqQE1R9r4NG3h8NrjI8=; b=TGygc4urHJDtlhiVOMP+m+wq/hDl+7TWNfGA84vEYO+Fun6cjAvQ/vcaA3c8D9Agmm 2oqe6wByWKqWEWtz1mKsQ58fqk6ayYsVZK13jQYZ3bIL4Kj4XHEMIdNdoMl5PEEZ7FPN 18WPzPyNElt915elyYLmgu4Y2nc4SQVTxaR/H3OfEHqAya8/GuvzHRvPQA2TReoA+HGs 6QiRW0DPVu+Z2BLEuWYcUxbKixxfJ5k73P8+Z2M0vmiIHzZsoXRg3+dx+5U6BLDGuFlu Sw0eGvSSEmckjsa+OFKqsL64s42D3Vfn2pvy5Mc3R/z1YRfXdOTJmGx0+UItTCPpsEa1 7RfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=pvbwW0C1; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h13-20020a056a00218d00b00505cc5e6ae9si2323590pfi.312.2022.04.15.12.15.33; Fri, 15 Apr 2022 12:15:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=pvbwW0C1; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350795AbiDOG7E (ORCPT + 66 others); Fri, 15 Apr 2022 02:59:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232878AbiDOG7D (ORCPT ); Fri, 15 Apr 2022 02:59:03 -0400 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F24803E0C5; Thu, 14 Apr 2022 23:56:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1650005796; x=1681541796; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=t2JyKHgJzNVEtMBMT1fofHfCUqQE1R9r4NG3h8NrjI8=; b=pvbwW0C11+qnWdAWxaMiAxY+2P/cTne0DGa4ZqeS6O+jLKCD5Tj+W/wF cFRNpBX53q3wRFllrI8Aen0FbYMqKnuy+c/KU+6jILOY/4qx6o9mA95YC RWSvuo0kYbOqVEobHODd5yw9r+ZZ8hqZibQ7uVnrEX17oi3qoTPKLpU2o 4=; Received: from unknown (HELO ironmsg02-sd.qualcomm.com) ([10.53.140.142]) by alexa-out-sd-01.qualcomm.com with ESMTP; 14 Apr 2022 23:56:35 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg02-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2022 23:56:36 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Thu, 14 Apr 2022 23:56:34 -0700 Received: from [10.253.8.85] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Thu, 14 Apr 2022 23:56:31 -0700 Message-ID: Date: Fri, 15 Apr 2022 14:56:29 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] ath11k: simplify if-if to if-else Content-Language: en-US To: Benjamin Poirier , Yihao Han CC: Kalle Valo , "David S. Miller" , Jakub Kicinski , Paolo Abeni , , , , , References: <20220414092042.78152-1-hanyihao@vivo.com> From: Wen Gong In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 4/15/2022 2:16 PM, Benjamin Poirier wrote: > On 2022-04-14 02:20 -0700, Yihao Han wrote: ... > It seems there is no synchronization around is_reset but is it > guaranteed that it cannot be changed by ath11k_core_reset() between the > two tests? I'm not familiar with the driver. ath11k_core_reset() has logic to avoid muti-reset in the same time. it means it has one recovery work doing for each time.