Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <9188cd3d7463cb8fc65c741bd07de817d0e60f6f.camel@mediatek.com>
Subject: Re: [PATCH v2] mt76: mt7915: add debugfs knob for RF registers
 read/write
From:   Shayne Chen <shayne.chen@mediatek.com>
To:     Felix Fietkau <nbd@nbd.name>
CC:     linux-wireless <linux-wireless@vger.kernel.org>,
        Lorenzo Bianconi <lorenzo@kernel.org>,
        Ryder Lee <ryder.lee@mediatek.com>,
        Evelyn Tsai <evelyn.tsai@mediatek.com>,
        Bo Jiao <Bo.Jiao@mediatek.com>,
        linux-mediatek <linux-mediatek@lists.infradead.org>,
        Peter Chiu <chui-hao.chiu@mediatek.com>
Date:   Fri, 15 Apr 2022 19:15:47 +0800
In-Reply-To: <c8662170-bf59-06df-a78c-8fb24303f274@nbd.name>
References: <20220415061444.30720-1-shayne.chen@mediatek.com>
         <c8662170-bf59-06df-a78c-8fb24303f274@nbd.name>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 2022-04-15 at 10:26 +0200, Felix Fietkau wrote:
> On 15.04.22 08:14, Shayne Chen wrote:
> > Add RF registers read/write support for debugging RF issues, which
> > should be processed by mcu commands.
> > 
> > Reviewed-by: Ryder Lee <ryder.lee@mediatek.com>
> > Signed-off-by: Peter Chiu <chui-hao.chiu@mediatek.com>
> > Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
> 
> What's the required width of rf_sel and rf_ofs? Would both fit
> together 
> in a single u32? If so, you could just use the generic regidx
> debugfs 
> file for both and simply add a rf_regval debugfs file.
> 
> - Felix

Hi Felix,

FW use the WF sel (antenna 0-3) and offset to locate rf registers.
I'll send an update patch to merge them in the generic regidx with
wf sel [31:28] and offset [27:0].

Thanks,
Shayne