Received-SPF: softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <c8662170-bf59-06df-a78c-8fb24303f274@nbd.name>
Date:   Fri, 15 Apr 2022 10:26:58 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v2] mt76: mt7915: add debugfs knob for RF registers
 read/write
Content-Language: en-US
To:     Shayne Chen <shayne.chen@mediatek.com>
Cc:     linux-wireless <linux-wireless@vger.kernel.org>,
        Lorenzo Bianconi <lorenzo@kernel.org>,
        Ryder Lee <ryder.lee@mediatek.com>,
        Evelyn Tsai <evelyn.tsai@mediatek.com>,
        Bo Jiao <Bo.Jiao@mediatek.com>,
        linux-mediatek <linux-mediatek@lists.infradead.org>,
        Peter Chiu <chui-hao.chiu@mediatek.com>
References: <20220415061444.30720-1-shayne.chen@mediatek.com>
From:   Felix Fietkau <nbd@nbd.name>
In-Reply-To: <20220415061444.30720-1-shayne.chen@mediatek.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 15.04.22 08:14, Shayne Chen wrote:
> Add RF registers read/write support for debugging RF issues, which
> should be processed by mcu commands.
> 
> Reviewed-by: Ryder Lee <ryder.lee@mediatek.com>
> Signed-off-by: Peter Chiu <chui-hao.chiu@mediatek.com>
> Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
What's the required width of rf_sel and rf_ofs? Would both fit together 
in a single u32? If so, you could just use the generic regidx debugfs 
file for both and simply add a rf_regval debugfs file.

- Felix