Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5ed02d6d-f4ae-3cea-f2c5-8bfa2f4b5eb1@nbd.name>
Date:   Sun, 17 Apr 2022 19:02:31 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH v2] ath9k: fix QCA9561 PA bias level
Content-Language: en-US
To:     =?UTF-8?Q?Thibaut_VAR=c3=88NE?= <hacks+kernel@slashdirt.org>,
        =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= <toke@toke.dk>,
        Kalle Valo <kvalo@kernel.org>, linux-wireless@vger.kernel.org
Cc:     =?UTF-8?Q?Petr_=c5=a0tetiar?= <ynezz@true.cz>,
        Clemens Hopfer <openwrt@wireloss.net>
References: <EC4F8380-4725-441D-B3FF-8CD7048F2236@slashdirt.org>
 <20220417145145.1847-1-hacks+kernel@slashdirt.org>
From:   Felix Fietkau <nbd@nbd.name>
In-Reply-To: <20220417145145.1847-1-hacks+kernel@slashdirt.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 17.04.22 16:51, Thibaut VARÈNE wrote:
> This patch fixes an invalid TX PA DC bias level on QCA9561, which
> results in a very low output power and very low throughput as devices
> are further away from the AP (compared to other 2.4GHz APs).
> 
> This patch was suggested by Felix Fietkau, who noted[1]:
> "The value written to that register is wrong, because while the mask
> definition AR_CH0_TOP2_XPABIASLVL uses a different value for 9561, the
> shift definition AR_CH0_TOP2_XPABIASLVL_S is hardcoded to 12, which is
> wrong for 9561."
> 
> In real life testing, without this patch the 2.4GHz throughput on
> Yuncore XD3200 is around 10Mbps sitting next to the AP, and closer to
> practical maximum with the patch applied.
> 
> [1] https://lore.kernel.org/all/91c58969-c60e-2f41-00ac-737786d435ae@nbd.name
> 
> Signed-off-by: Thibaut VARÈNE <hacks+kernel@slashdirt.org>

Acked-by: Felix Fietkau <nbd@nbd.name>