Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 17 Apr 2022 17:40:00 +0200
From:   Lorenzo Bianconi <lorenzo@kernel.org>
To:     Ben Greear <greearb@candelatech.com>
Cc:     nbd@nbd.name, lorenzo.bianconi@redhat.com,
        linux-wireless@vger.kernel.org, ryder.lee@mediatek.com,
        evelyn.tsai@mediatek.com, owen.peng@mediatek.com
Subject: Re: [PATCH 5/6] mt76: mt7915: enable radar background detection
Message-ID: <Ylw00A5YN0mybkCw@localhost.localdomain>
References: <cover.1641996493.git.lorenzo@kernel.org>
 <f97a4fe5bec70d8e5594c0f4d286b46b844939a5.1641996493.git.lorenzo@kernel.org>
 <70c4ecc0-cfc6-e924-6578-3314dca42d75@candelatech.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="c/qzhBrLScOgABlj"
Content-Disposition: inline
In-Reply-To: <70c4ecc0-cfc6-e924-6578-3314dca42d75@candelatech.com>
Precedence: bulk


--c/qzhBrLScOgABlj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> On 1/12/22 6:13 AM, Lorenzo Bianconi wrote:
> > Notify userland the hw supports background radar/CAC detection.
>=20
> So, what about someone like me using mtk7915 4x4 radio from asia-rf?  It
> has no extra RF chains afaik, and it is certainly broken when
> trying to use DFS channels on my system.

according to my understanding asia-rf card can be considered an outlier from
this point of view (mt7915 regular card should support a dedicated radar ch=
ain).
AFAIU there is no way to autodetect this feature (@Ryder correct?), so we c=
ould
add a module parameter (similar to dts one) to disable this feature. What do
you think?

Regards,
Lorenzo

>=20
> Maybe you need a positive check instead of negative check before
> enabling this feature?
>=20
> Thanks,
> Ben
>=20
> >=20
> > Tested-by: Owen Peng <owen.peng@mediatek.com>
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > ---
> >   drivers/net/wireless/mediatek/mt76/mt7915/init.c | 7 +++++++
> >   1 file changed, 7 insertions(+)
> >=20
> > diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/init.c b/drivers=
/net/wireless/mediatek/mt76/mt7915/init.c
> > index 5c1643963506..91c7ce60f296 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mt7915/init.c
> > +++ b/drivers/net/wireless/mediatek/mt76/mt7915/init.c
> > @@ -309,6 +309,7 @@ static void
> >   mt7915_init_wiphy(struct ieee80211_hw *hw)
> >   {
> >   	struct mt7915_phy *phy =3D mt7915_hw_phy(hw);
> > +	struct mt76_dev *mdev =3D &phy->dev->mt76;
> >   	struct wiphy *wiphy =3D hw->wiphy;
> >   	struct mt7915_dev *dev =3D phy->dev;
> > @@ -337,6 +338,12 @@ mt7915_init_wiphy(struct ieee80211_hw *hw)
> >   	wiphy_ext_feature_set(wiphy, NL80211_EXT_FEATURE_BEACON_RATE_VHT);
> >   	wiphy_ext_feature_set(wiphy, NL80211_EXT_FEATURE_BEACON_RATE_HE);
> > +	if (!mdev->dev->of_node ||
> > +	    !of_property_read_bool(mdev->dev->of_node,
> > +				   "mediatek,disable-radar-background"))
> > +		wiphy_ext_feature_set(wiphy,
> > +				      NL80211_EXT_FEATURE_RADAR_BACKGROUND);
> > +
> >   	ieee80211_hw_set(hw, HAS_RATE_CONTROL);
> >   	ieee80211_hw_set(hw, SUPPORTS_TX_ENCAP_OFFLOAD);
> >   	ieee80211_hw_set(hw, SUPPORTS_RX_DECAP_OFFLOAD);
> >=20
>=20
>=20
> --=20
> Ben Greear <greearb@candelatech.com>
> Candela Technologies Inc  http://www.candelatech.com
>=20

--c/qzhBrLScOgABlj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCYlw0zAAKCRA6cBh0uS2t
rHItAQCDgS4CZSkVBJ5X9lUPEQy4yW9kgFZq1KVpAXoSTCyRLAD+InDPFSPQtJ9u
O3CjwblkH2XGFhXtkCZLBuXNt9+1aAk=
=2Wj0
-----END PGP SIGNATURE-----

--c/qzhBrLScOgABlj--