Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
To:     Thibaut =?utf-8?Q?VAR=C3=88NE?= <hacks+kernel@slashdirt.org>,
        Kalle Valo <kvalo@kernel.org>, linux-wireless@vger.kernel.org
Cc:     Felix Fietkau <nbd@nbd.name>,
        Petr =?utf-8?Q?=C5=A0tetiar?= <ynezz@true.cz>,
        Clemens Hopfer <openwrt@wireloss.net>,
        Thibaut =?utf-8?Q?VAR=C3=88NE?= <hacks+kernel@slashdirt.org>
Subject: Re: [PATCH v2] ath9k: fix QCA9561 PA bias level
In-Reply-To: <20220417145145.1847-1-hacks+kernel@slashdirt.org>
References: <EC4F8380-4725-441D-B3FF-8CD7048F2236@slashdirt.org>
 <20220417145145.1847-1-hacks+kernel@slashdirt.org>
Date:   Sun, 17 Apr 2022 21:00:28 +0200
Message-ID: <87ilr73583.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Thibaut VAR=C3=88NE <hacks+kernel@slashdirt.org> writes:

> This patch fixes an invalid TX PA DC bias level on QCA9561, which
> results in a very low output power and very low throughput as devices
> are further away from the AP (compared to other 2.4GHz APs).
>
> This patch was suggested by Felix Fietkau, who noted[1]:
> "The value written to that register is wrong, because while the mask
> definition AR_CH0_TOP2_XPABIASLVL uses a different value for 9561, the
> shift definition AR_CH0_TOP2_XPABIASLVL_S is hardcoded to 12, which is
> wrong for 9561."
>
> In real life testing, without this patch the 2.4GHz throughput on
> Yuncore XD3200 is around 10Mbps sitting next to the AP, and closer to
> practical maximum with the patch applied.
>
> [1] https://lore.kernel.org/all/91c58969-c60e-2f41-00ac-737786d435ae@nbd.=
name
>
> Signed-off-by: Thibaut VAR=C3=88NE <hacks+kernel@slashdirt.org>

Thank you for the fix!

Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk>