Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp4331889pxb; Wed, 20 Apr 2022 00:22:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyN8obDmwA8rbODt96WV0p1rdYMBGZ/FpeYq/jVyvjAGpRNJHYrpUy9eQ5fSaklvWQMsVMi X-Received: by 2002:a63:1b5e:0:b0:3aa:593c:9392 with SMTP id b30-20020a631b5e000000b003aa593c9392mr3204227pgm.470.1650439360190; Wed, 20 Apr 2022 00:22:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650439360; cv=none; d=google.com; s=arc-20160816; b=fguzcEvaa+TOfeZnz74VoRf0wbZft2iQfNkJW40//cyMkTO7rQGvceTvHWrNADg6NH cSp8wtWAYgw/lSIYBVg0udXWiyEJ1wjkWsxxNF2amNVNlrC266LivjnJrKw2lQFnwUMg SXBoIjzwxSLXM3k/p65YKz1ZHr8EhT0vqMs2gUGmsh0BocifRfo5OkJR9B3SDQq1vuaC XYy1MZd3QnjotiWdxdtsFjnoK34AjiLvCkmpUPUMeMoOkrgDKTK0/Fo2t16OSf8yRGiv nCb53CGEJT7FgfoEvQ8s4U4Mte3klJXC+FNqQhIRHO6tqVYm2tazLSdn2ISXxmbKafjD 0fpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=Pcvg/PYFS+ifJRo/HVteuD0zgdkv+kaMKzgQSnSoB0Q=; b=kGmTvLen5EY5TO4SYa/xwsTGr7+WnntVQEtFzeiLBU5O7isJ9fU2vy7ARVncMvIKwF 04JrGkEmStgOaIrkKSIm6+YUm7cV1fxCIgOaXVlhocYqFajs1J4Fiu6cB5gssISbjGIJ GWnzxExnuXiruxuZu/eKdaN80tKLSsuVYDc1lpa9f91ZR46zCq1G5g9EtXFn0+N8wZEF 309AShzZKWjNQIclmFz2xfrM03VLO4RDma3lKwHnCsak/vGnrAQhAaM25a6P8fa/FbDK v7aeTVkw9EOq0nKtqbPtXsaYro/91uP3vLJDpYQxYjU4s4Wd2gbKlXiMVHevsO4aCLcO Bsew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lr4-20020a17090b4b8400b001cb8bfcc721si1588225pjb.7.2022.04.20.00.22.25; Wed, 20 Apr 2022 00:22:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232428AbiDTEGr (ORCPT + 66 others); Wed, 20 Apr 2022 00:06:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230163AbiDTEGp (ORCPT ); Wed, 20 Apr 2022 00:06:45 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C27E33EA2 for ; Tue, 19 Apr 2022 21:03:56 -0700 (PDT) X-UUID: d3104b34bd6f40929dcaad32302c47af-20220420 X-UUID: d3104b34bd6f40929dcaad32302c47af-20220420 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1325550787; Wed, 20 Apr 2022 12:03:51 +0800 Received: from MTKMBS34N1.mediatek.inc (172.27.4.172) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Wed, 20 Apr 2022 12:03:50 +0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS34N1.mediatek.inc (172.27.4.172) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 20 Apr 2022 12:03:49 +0800 Received: from mcddlt001.gcn.mediatek.inc (10.19.240.15) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 20 Apr 2022 12:03:48 +0800 From: Bo Jiao To: Felix Fietkau CC: linux-wireless , Ryder Lee , Sujuan Chen , Shayne Chen , Evelyn Tsai , linux-mediatek , Bo Jiao Subject: [PATCH] mt76: mt7915: report qos_ctl without ACK policy Date: Wed, 20 Apr 2022 12:03:46 +0800 Message-ID: <20220420040346.8378-1-bo.jiao@mediatek.com> X-Mailer: git-send-email 2.17.0 MIME-Version: 1.0 Content-Type: text/plain X-MTK: N X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE,T_SPF_TEMPERROR,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Bo Jiao there is no need to report to the mac80211 layer the ACK policy which may cause rx out-of-order issue, because the hardware rmac module already handle it Signed-off-by: Bo Jiao --- drivers/net/wireless/mediatek/mt76/mt7915/mac.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c index b47aea6..5080280 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c @@ -675,6 +675,11 @@ mt7915_mac_fill_rx(struct mt7915_dev *dev, struct sk_buff *skb) fc = cpu_to_le16(FIELD_GET(MT_RXD6_FRAME_CONTROL, v0)); qos_ctl = FIELD_GET(MT_RXD8_QOS_CTL, v2); + /* + * there is no need to report the ACK policy to the + * mac80211 layer, because hw has already processed it. + */ + qos_ctl &= ~IEEE80211_QOS_CTL_ACK_POLICY_MASK; seq_ctrl = FIELD_GET(MT_RXD8_SEQ_CTRL, v2); rxd += 4; -- 2.18.0