Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp4680036pxb; Wed, 20 Apr 2022 08:05:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwU+rKAFmHQCfMgOHUyDgCjNIfXPRhlajLGrc3Nz9LntGtmYxx9vhCBEg8fNXW9LHSDGg7c X-Received: by 2002:aa7:dc53:0:b0:421:d085:9a0d with SMTP id g19-20020aa7dc53000000b00421d0859a0dmr24167530edu.0.1650467109235; Wed, 20 Apr 2022 08:05:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650467109; cv=none; d=google.com; s=arc-20160816; b=G7noi++QkVs0XgWx2L0jM38Wm9yKLyDaa08u58+O36fWHERvdzmSSQ0EdF0tofqUmq v2/d8WU/YFSOPcQihy40nO/2DihdfU+OXH2zWO/fYDf+D5kKTAdlgujgQIFLIo2uDQjK TwXMPOL8wtuT2p7x1TVn4mlAPAiP2VdWxpq4mchLXQZoeu/CqsLhDDWmdjffb3klsZiz eciNnTASS3EIlz8N6siktBXil8qgMA8NLF/epVjVorncZnZ5wwKbzcIUku09/6j2UxtM R36XxqRfVDr62Zbusc+19d0nmcT6up3lfmSm/ZxFEGi5obuYMQhVh2rwVL//j1lXYxH+ nK3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from:dkim-signature; bh=T48u72zYkdxaToU1x2wH0NSnqQnzI4Q6H8B1nwJ6u0g=; b=TcNPW4I87tGZ4+6MoyupiKwZFqZEGguYEWr8PgsHLruiTiNIQFCmZcOgR/B9ytU69o fNjR38WmLAppZzPVHqABGqFACG/SUrpmW7ipcfejLs5d/b9n+HA2fIPW46zxpVqsBEOr pLpec3H2arXUUVyNKol/iPo/K4Une0KWKpwI08RSus0LMhz/NmOmy1ep3ZMAbZbqR40R Sb9zn0RcXuotmkjxq0GrM6RvmcYvWDqLI74Zs0Qe36BVng/umO2XNMOECDinQybCRlBP zgUZSk/v7FyBWkz9HfgvkN9QaxctACr7PPeAEdzj6NXSp9pDrF5hQ1/FX+gsDXiQ0UqG aPVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=Z85H5j4g; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j25-20020a17090686d900b006df76385c21si2024872ejy.193.2022.04.20.08.04.48; Wed, 20 Apr 2022 08:05:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=Z85H5j4g; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377782AbiDTKqa (ORCPT + 66 others); Wed, 20 Apr 2022 06:46:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376506AbiDTKqZ (ORCPT ); Wed, 20 Apr 2022 06:46:25 -0400 Received: from nbd.name (nbd.name [IPv6:2a01:4f8:221:3d45::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFC0E3FDB4 for ; Wed, 20 Apr 2022 03:43:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject :To:From:Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=T48u72zYkdxaToU1x2wH0NSnqQnzI4Q6H8B1nwJ6u0g=; b=Z85H5j4grx7YkTyEDV7Z+UqsXY AV/lKZhBCjMuq8QZeHbJf7DPam0vjLsxziWTr+XZPtvKFjDKTHWnmuN4GFNWArWQ/Ni0/nxJB706P iB67A4Cq0TD/Ia7ywaYG/atCRtADD1SSfFNzKOWT4f5R33Apv/0o0qbfHiqnO7RQPSDM=; Received: from p200300daa70ef200009e86881025829d.dip0.t-ipconnect.de ([2003:da:a70e:f200:9e:8688:1025:829d] helo=localhost.localdomain) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1nh7oA-00052O-9r for linux-wireless@vger.kernel.org; Wed, 20 Apr 2022 12:43:38 +0200 From: Felix Fietkau To: linux-wireless@vger.kernel.org Subject: [PATCH] mt76: fix rx reordering with non explicit / psmp ack policy Date: Wed, 20 Apr 2022 12:43:31 +0200 Message-Id: <20220420104331.32418-1-nbd@nbd.name> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org When the QoS ack policy was set to non explicit / psmp ack, frames are treated as not being part of a BA session, which causes extra latency on reordering. Fix this by only bypassing reordering for packets with no-ack policy Signed-off-by: Felix Fietkau --- drivers/net/wireless/mediatek/mt76/agg-rx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/agg-rx.c b/drivers/net/wireless/mediatek/mt76/agg-rx.c index 72622220051b..9b8e1dfbc814 100644 --- a/drivers/net/wireless/mediatek/mt76/agg-rx.c +++ b/drivers/net/wireless/mediatek/mt76/agg-rx.c @@ -169,8 +169,7 @@ void mt76_rx_aggr_reorder(struct sk_buff *skb, struct sk_buff_head *frames) /* not part of a BA session */ ackp = status->qos_ctl & IEEE80211_QOS_CTL_ACK_POLICY_MASK; - if (ackp != IEEE80211_QOS_CTL_ACK_POLICY_BLOCKACK && - ackp != IEEE80211_QOS_CTL_ACK_POLICY_NORMAL) + if (ackp == IEEE80211_QOS_CTL_ACK_POLICY_NOACK) return; tid = rcu_dereference(wcid->aggr[tidno]); -- 2.35.1