Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <46f14357-d02b-cad3-9fa8-7e1962305251@nbd.name>
Date:   Wed, 20 Apr 2022 13:25:49 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH] mt76: mt7915: disable RX_HDR_TRANS_SHORT
Content-Language: en-US
To:     Bo Jiao <bo.jiao@mediatek.com>
Cc:     linux-wireless <linux-wireless@vger.kernel.org>,
        Ryder Lee <ryder.lee@mediatek.com>,
        Sujuan Chen <sujuan.chen@mediatek.com>,
        "lian . chen" <lian.chen@mediatek.com>,
        Shayne Chen <shayne.chen@mediatek.com>,
        Evelyn Tsai <evelyn.tsai@mediatek.com>,
        linux-mediatek <linux-mediatek@lists.infradead.org>
References: <20220420071144.14573-1-bo.jiao@mediatek.com>
From:   Felix Fietkau <nbd@nbd.name>
In-Reply-To: <20220420071144.14573-1-bo.jiao@mediatek.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 20.04.22 09:11, Bo Jiao wrote:
> From: Bo Jiao <Bo.Jiao@mediatek.com>
> 
> This patch disables RX_TRANS_SHORT to make MDP to do header translation
> when payload less than 8 bytes, hence the (QoS) null data can be encapsulated
> to 802.3 format. However, WDS requires (QoS) null data in 802.11 format
> to created vlan AP interfaces.
> 
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> Signed-off-by: lian.chen <lian.chen@mediatek.com>
> Signed-off-by: Sujuan Chen <sujuan.chen@mediatek.com>
> Signed-off-by: Bo Jiao <Bo.Jiao@mediatek.com>
> ---
>   drivers/net/wireless/mediatek/mt76/agg-rx.c      | 3 +++
>   drivers/net/wireless/mediatek/mt76/mt7915/init.c | 3 +++
>   drivers/net/wireless/mediatek/mt76/mt7915/mac.c  | 4 ----
>   drivers/net/wireless/mediatek/mt76/mt7915/regs.h | 3 +++
>   4 files changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/agg-rx.c b/drivers/net/wireless/mediatek/mt76/agg-rx.c
> index 7262222..efd1a85 100644
> --- a/drivers/net/wireless/mediatek/mt76/agg-rx.c
> +++ b/drivers/net/wireless/mediatek/mt76/agg-rx.c
> @@ -167,6 +167,9 @@ void mt76_rx_aggr_reorder(struct sk_buff *skb, struct sk_buff_head *frames)
>   		return;
>   	}
>   
> +	if (!status->aggr)
> +		return;
> +
>   	/* not part of a BA session */
>   	ackp = status->qos_ctl & IEEE80211_QOS_CTL_ACK_POLICY_MASK;
>   	if (ackp != IEEE80211_QOS_CTL_ACK_POLICY_BLOCKACK &&
This is an unrelated change, for which I've just sent a replacement 
patch. The rest is applied.

Thanks,

- Felix