Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Hermes Zhang <chenhui.zhang@axis.com>
Cc:     Arend van Spriel <aspriel@gmail.com>,
        Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Jakub Kicinski" <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, <kernel@axis.com>,
        Hermes Zhang <chenhuiz@axis.com>,
        <linux-wireless@vger.kernel.org>,
        <brcm80211-dev-list.pdl@broadcom.com>,
        <SHA-cyfmac-dev-list@infineon.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] brcmfmac: of: introduce new property to allow disable PNO
References: <20220422044419.3415842-1-chenhui.zhang@axis.com>
Date:   Fri, 22 Apr 2022 08:59:43 +0300
In-Reply-To: <20220422044419.3415842-1-chenhui.zhang@axis.com> (Hermes Zhang's
        message of "Fri, 22 Apr 2022 12:44:18 +0800")
Message-ID: <8735i5odyo.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Hermes Zhang <chenhui.zhang@axis.com> writes:

> From: Hermes Zhang <chenhuiz@axis.com>
>
> The PNO feature need to be disable for some scenario in different
> product. This commit introduce a new property to allow the
> product-specific toggling of this feature.

"some scenario"? That's not really helpful.

> Signed-off-by: Hermes Zhang <chenhuiz@axis.com>
> ---
>
> Notes:
>     Change property name to brcm,pno-disable
>
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
> index 8623bde5eb70..121a195e4054 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
> @@ -11,6 +11,7 @@
>  #include "core.h"
>  #include "common.h"
>  #include "of.h"
> +#include "feature.h"
>  
>  static int brcmf_of_get_country_codes(struct device *dev,
>  				      struct brcmf_mp_device *settings)
> @@ -102,6 +103,9 @@ void brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type,
>  	if (bus_type != BRCMF_BUSTYPE_SDIO)
>  		return;
>  
> +	if (of_find_property(np, "brcm,pno-disable", NULL))
> +		settings->feature_disable |= BIT(BRCMF_FEAT_PNO);

Is this DT property documented and acked by the Device Tree maintainers?
AFAIK DT is not supposed to be used as a software configuration
database.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches