Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp752352pxb; Fri, 22 Apr 2022 10:23:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyj3FoZyN3LMk0CtFgZVdDz/D6F8zJWkVJnrgUUqEYha7a3rr2vdG+EM8+UIfgRwCZ9D1BB X-Received: by 2002:a17:90a:d083:b0:1c9:94bb:732d with SMTP id k3-20020a17090ad08300b001c994bb732dmr6550007pju.106.1650648217000; Fri, 22 Apr 2022 10:23:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650648216; cv=none; d=google.com; s=arc-20160816; b=gc8CELGcLlkKDW3fqCbm+HL/Sb6yoFX0ndSUbcvVl0WsVcg5Gd8FjQ4hOUsex4417b 0ij63IHUSDUBOCBv3JJw4BjUWTgNqvGCVylJU/hDOCOIcDFAT1ZfDPM3Rb4ts8u2Ymgv K2xMW9sSUupb/zANWMOfAB4IiwToqUVBF3s0g5XlqTUBPkaPpAgPU/sw3McZ3X7frPgC F4Ext2HgLMebEzjiFt0w+d7fqGwEb/IVrPo4tvJZu+xQPWQhN+1TrFZMJnPu/U3D04M5 fLuGyRZB/ODjrqdb2lPpiztCqd7h/JZpsmsuEqXwe7XO0bkTCLy9qx1XvzwNkiu5KeWf p7HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from:dkim-signature; bh=qS4RzWD/rp9U12J+O+Qvd0P5ZJIxobZfplZjn25+BwI=; b=Rl6alEr535vZIqHeXcellKZARKguu1yfqRT0NFAu9HLPZS0KfzRFowbpDyEQzow7WA tyZaJ8LHpFlrQDbs8yTT9MfqLrBX6J/RdIqRlVFXu19OR15YSOF5UfEOKWUx1+Mg/SL2 QDW+cKssPqm0YQGPALwGCMjID5Emc+DAwH007+ujQI+3kmw12VKHDXdvrIzuKC5Wn/1g W0+auAk7i47J0oeUhmCRu1956tWvSxSY8gK68Rfz0NL2oRFaJBYU2BBoKC8dd/nfw0Ra YAA0zNOKpk8O0/K0e74miV+FjDM9YyDGe7BzQcjb2EbV3Gj4eq6xofbeoBYfQitwdIMM G94w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=uZNefaz3; spf=softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id i4-20020a170902c94400b001501189ca21si9931737pla.1.2022.04.22.10.23.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 10:23:36 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=uZNefaz3; spf=softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5735DB1A93; Fri, 22 Apr 2022 10:17:31 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378042AbiDTL20 (ORCPT + 66 others); Wed, 20 Apr 2022 07:28:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378036AbiDTL2S (ORCPT ); Wed, 20 Apr 2022 07:28:18 -0400 Received: from nbd.name (nbd.name [IPv6:2a01:4f8:221:3d45::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2CD93C4B5 for ; Wed, 20 Apr 2022 04:25:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject :To:From:Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=qS4RzWD/rp9U12J+O+Qvd0P5ZJIxobZfplZjn25+BwI=; b=uZNefaz3LsfCRhA+RIfQewyOoi NuC9dyHe0MNvj0VllIX5lfJIUCM78+64/Mpfd6TD0K3bHoS50S8iNFxO81giIeykr0MQ83IQD51lA kfR4QAGeU1RZx/RcO/RkAqzmXsoUeZ0PAMJZvASz5PYUsTGYfF1mfWuxHX9G7mVl+vAw=; Received: from p200300daa70ef200009e86881025829d.dip0.t-ipconnect.de ([2003:da:a70e:f200:9e:8688:1025:829d] helo=localhost.localdomain) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1nh8Se-0006a1-G7 for linux-wireless@vger.kernel.org; Wed, 20 Apr 2022 13:25:28 +0200 From: Felix Fietkau To: linux-wireless@vger.kernel.org Subject: [PATCH] mt76: do not attempt to reorder received 802.3 packets without agg session Date: Wed, 20 Apr 2022 13:25:24 +0200 Message-Id: <20220420112524.52430-1-nbd@nbd.name> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fixes potential latency / packet drop issues in cases where a BA session has not (yet) been established. Fixes: e195dad14115 ("mt76: add support for 802.3 rx frames") Signed-off-by: Felix Fietkau --- drivers/net/wireless/mediatek/mt76/agg-rx.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/agg-rx.c b/drivers/net/wireless/mediatek/mt76/agg-rx.c index 9b8e1dfbc814..10cbd9e560e7 100644 --- a/drivers/net/wireless/mediatek/mt76/agg-rx.c +++ b/drivers/net/wireless/mediatek/mt76/agg-rx.c @@ -162,8 +162,9 @@ void mt76_rx_aggr_reorder(struct sk_buff *skb, struct sk_buff_head *frames) if (!sta) return; - if (!status->aggr && !(status->flag & RX_FLAG_8023)) { - mt76_rx_aggr_check_ctl(skb, frames); + if (!status->aggr) { + if (!(status->flag & RX_FLAG_8023)) + mt76_rx_aggr_check_ctl(skb, frames); return; } -- 2.35.1