Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <f1b944f5-b440-d32e-84b9-7cb140b0adc6@nbd.name>
Date:   Thu, 21 Apr 2022 23:14:21 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: [PATCH] mt76: mt7915: disable RX_HDR_TRANS_SHORT
Content-Language: en-US
To:     "bo.jiao" <bo.jiao@mediatek.com>
Cc:     linux-wireless <linux-wireless@vger.kernel.org>,
        Ryder Lee <ryder.lee@mediatek.com>,
        Sujuan Chen <sujuan.chen@mediatek.com>,
        "lian . chen" <lian.chen@mediatek.com>,
        Shayne Chen <shayne.chen@mediatek.com>,
        Evelyn Tsai <evelyn.tsai@mediatek.com>,
        linux-mediatek <linux-mediatek@lists.infradead.org>
References: <20220420071144.14573-1-bo.jiao@mediatek.com>
 <46f14357-d02b-cad3-9fa8-7e1962305251@nbd.name>
 <5b0f28fa67b27151a59ea42d9f60e29919f36f36.camel@mediatek.com>
From:   Felix Fietkau <nbd@nbd.name>
In-Reply-To: <5b0f28fa67b27151a59ea42d9f60e29919f36f36.camel@mediatek.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


Hi,

On 21.04.22 03:44, bo.jiao wrote:
> hi felix:
> 
> mt7915_mac_fill_rx:
> 	......
> 
> 	if (!status->wcid || !ieee80211_is_data_qos(fc))
> 		return 0;
> 
> 	status->aggr = unicast &&
> 		       !ieee80211_is_qos_nullfunc(fc);
> 	status->qos_ctl = qos_ctl;
> 	status->seqno = IEEE80211_SEQ_TO_SN(seq_ctrl);
> 
> 	return 0;
> 
> it will be returned by the condition !ieee80211_is_data_qos(fc) when
> receive non-Qos (null) data, and the status->aggr/status-
>>qos_ctl/status->seqno keep the default value 0.
> 
> mt76_rx_aggr_reorder:
> 	....
> 
> 	sta = wcid_to_sta(wcid);
> 	if (!sta)
> 		return;
> 
> 	if (!status->aggr && !(status->flag & RX_FLAG_8023)) {
> 		mt76_rx_aggr_check_ctl(skb, frames);
> 		return;
> 	}
> 
> 	....
> 
> those packet will be forced to do rx reorder and may incorrectly update
> tid->head.
> https://patchwork.kernel.org/project/linux-wireless/patch/2022042010503
> 8.36443-1-nbd@nbd.name/
> Your replacement patch did not include this change.
> +	if (!status->aggr)
> +		return;
> +
> 
> Thanks.
I posted this patch: https://patchwork.kernel.org/project/linux-wireless/patch/20220420112524.52430-1-nbd@nbd.name/

- Felix