Received-SPF: softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <CAGm1_ktEim1vGOf5i=H_sqrPvg=dT50790YYwXgYKgAut-a=ng@mail.gmail.com>
 <YmDpTAu9wmlLijDA@atomide.com>
In-Reply-To: <YmDpTAu9wmlLijDA@atomide.com>
From:   Yegor Yefremov <yegorslists@googlemail.com>
Date:   Thu, 21 Apr 2022 11:01:54 +0200
Message-ID: <CAGm1_kv+b1h1OuWr4w5jS_mqfQpXF7UexiWFsOSs+MJK546=ew@mail.gmail.com>
Subject: Re: wl18xx: NVS file handling
To:     Tony Lindgren <tony@atomide.com>
Cc:     Linux-OMAP <linux-omap@vger.kernel.org>,
        linux-wireless@vger.kernel.org, sebastian.reichel@collabora.co.uk,
        Eyal Reizer <eyalr@ti.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Tony,

On Thu, Apr 21, 2022 at 7:19 AM Tony Lindgren <tony@atomide.com> wrote:
>
> Hi,
>
> * Yegor Yefremov <yegorslists@googlemail.com> [220420 13:58]:
> > Hi all,
> >
> > using the 5.18.x kernel, I get the following warning:
> >
> > wlcore: WARNING Detected unconfigured mac address in nvs, derive from
> > fuse instead.
> > wlcore: WARNING This default nvs file can be removed from the file system
> >
> > removing the /lib/firmware/ti-connectivity/wl127x-nvs.bin file, I get
> > this warning:
> >
> > wl18xx_driver wl18xx.0.auto: Direct firmware load for
> > ti-connectivity/wl1271-nvs.bin failed with error -2
> >
> > What's the best way to get rid of these warnings when I don't want to
> > handle WLAN's MAC address via the wl127x-nvs.bin?
>
> See commit d382b9c00782 ("wlcore: add missing nvs file name info for
> wilink8"), to me looks like the the second warning should be just removed
> for wl18xx.
>
> > According to this discussion [1], NVS file is the last resort for
> > handling the MAC address.
> >
> > [1] https://patchwork.kernel.org/project/linux-wireless/patch/8665E2433BC68541A24DFFCA87B70F5B363E1A3D@DFRE01.ent.ti.com/
>
> Yes the NVS file does not work at all for NFSroot for multiple devices.
>
> To me it seems we should have the option for the MAC address to be
> populated by the bootloader for the devicetree property like Ethernet
> adapters typically do. Not sure what that might take, maybe it
> already works. I guess the first step would be to make the nvs file
> completely optional for wlcore.

I'll try to create a patch for making nvs file optional.

P.S. a TI maintainer for wlcore would be great .... WPA3 and mesh are
still not really there [1].

[1] https://software-dl.ti.com/ecs/WiLink8/R8_8/change_log_R8_8.html

Regards,
Yegor