Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp961272pxb; Fri, 22 Apr 2022 15:23:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy5Bfh78/r1IRliZ58P6rvzZJv264klUBm0uBdC2j3bjRdu8WHhT0Jft3yn0jouibnHDUUm X-Received: by 2002:a17:902:7d83:b0:158:c7e9:1ff3 with SMTP id a3-20020a1709027d8300b00158c7e91ff3mr6813564plm.55.1650666224150; Fri, 22 Apr 2022 15:23:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650666224; cv=none; d=google.com; s=arc-20160816; b=z11F/6tznHkxXnMBlGHUJ2YyGQGjcKw2hX6XXQJmP9CWIrCH82L+OzMIF8lfAXIzeP jPKJJAmoOpMH+4x3IICwYSvdnCl/EH1VDhkFBWek/Tbum22/tljH7VOMH5Dc+4Oe0+mW VRHagYP/Fos7pKMs12S+q9FRF3pwvZRJ+7dcXMVG13x3yc0QJSVVeRiD4JEVuzCGHjcF 2NeurxWsR6XLV0jnEvpBcI5g1qY93sZYKRyeILBPKr4TUwjMCRv/dqS89Y2p9Ruw/1Li 6RU8Mnqf/qqdygDLpZCpaPTLojgpGQ//vmhCFEs/GQUCYBzcosXK9NXgdMlzciTl0tmP 9Z0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date; bh=x58OSBVxTWb0HZGXheH8f2D1FqZxpVSbG7e7zl1toD8=; b=nGVX7vB/+a5RSjvU+3/xwDVOkQNv/gyN/9knNLVOEDHxx7/jkQCGEUPhIdPceKGuMv SqleaSLOpIvSUKsc6/au9qrmSOfMHYvvkr3HhOj4eZF7V5ez/Rbpr/ea0Twd9CUComr4 +/Cze8TpoGecYnE3jvkpdGikkEULnDMNShdIGYYngYZyHNC7cVv3FaAKJBl4/VVMjubP LAduy73zxYjC/qRYkqj4P5hYk9GQj6zwLOkOG9GlTaisygZF7+UUd+fypBHuvRpQy+lS sDW14RrMw6bMshkRFUfWw2dyTH1GXLnoZ4txA+05OMkDD1Mw/hVlPyiz5kWEbRsSjO4v aEUQ== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id b5-20020a170902d88500b00156701abd74si9215952plz.215.2022.04.22.15.23.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 15:23:44 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0687D3D1BCF; Fri, 22 Apr 2022 13:29:00 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1449008AbiDVO6j (ORCPT + 66 others); Fri, 22 Apr 2022 10:58:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1449031AbiDVO6c (ORCPT ); Fri, 22 Apr 2022 10:58:32 -0400 X-Greylist: delayed 280 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 22 Apr 2022 07:55:38 PDT Received: from mail.kevlo.org (mail.kevlo.org [220.134.220.36]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0241B5AA61 for ; Fri, 22 Apr 2022 07:55:38 -0700 (PDT) Received: from localhost (ns.kevlo.org [local]) by ns.kevlo.org (OpenSMTPD) with ESMTPA id 62f7c6f5; Fri, 22 Apr 2022 22:50:54 +0800 (CST) Date: Fri, 22 Apr 2022 22:50:54 +0800 From: Kevin Lo To: Ping-Ke Shih Cc: linux-wireless@vger.kernel.org Subject: [PATCH] rtw88: use the correct bit in the REG_HCI_OPT_CTRL register Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Write the BIT_USB_SUS_DIS bit rather than BIT_BT_DIG_CLK_EN to the REG_HCI_OPT_CTRL register for fixing failure to PCIe power on. Signed-off-by: Kevin Lo --- diff --git a/drivers/net/wireless/realtek/rtw88/mac.c b/drivers/net/wireless/realtek/rtw88/mac.c index d1678aed9d9c..caf2603da2d6 100644 --- a/drivers/net/wireless/realtek/rtw88/mac.c +++ b/drivers/net/wireless/realtek/rtw88/mac.c @@ -75,7 +75,7 @@ static int rtw_mac_pre_system_cfg(struct rtw_dev *rtwdev) switch (rtw_hci_type(rtwdev)) { case RTW_HCI_TYPE_PCIE: - rtw_write32_set(rtwdev, REG_HCI_OPT_CTRL, BIT_BT_DIG_CLK_EN); + rtw_write32_set(rtwdev, REG_HCI_OPT_CTRL, BIT_USB_SUS_DIS); break; case RTW_HCI_TYPE_USB: break;