Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Guo Zhengkui <guozhengkui@vivo.com>
To:     Ping-Ke Shih <pkshih@realtek.com>, Kalle Valo <kvalo@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Guo Zhengkui <guozhengkui@vivo.com>,
        linux-wireless@vger.kernel.org (open list:REALTEK WIRELESS DRIVER
        (rtlwifi family)),
        netdev@vger.kernel.org (open list:NETWORKING DRIVERS),
        linux-kernel@vger.kernel.org (open list)
Cc:     zhengkui_guo@outlook.com
Subject: [PATCH] rtlwifi: btcoex: fix if == else warning
Date:   Sun, 24 Apr 2022 15:55:45 +0800
Message-Id: <20220424075548.1544-1-guozhengkui@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FfoYWKynT0O16N5ksVq0qPciVreqzDWMUDyyRjEqVqRWB1GzD1ksjxIHyhju?=
 =?us-ascii?Q?QgQYbgoG0W3SD0y0K5jVu1Jq69JkPVOjmEqjkLTY20/LwuEWqTpYOpZOFTZR?=
 =?us-ascii?Q?QiOkQ/QvQKRrgG9wedxRPYwmWub77JPFld/HqtjruSNrAGt+51xPvg8tzIhL?=
 =?us-ascii?Q?gOSicJUvo2cJy7kgppwA9YNe81LJpsjbbJtFTv9hm5kCA+cSRbhTHlIFq0O4?=
 =?us-ascii?Q?pdw5VvlWAL1rhfFC6sbbX93cVdqWYtV7OUGywfkVDZhZRwpyOpBneRHdh+oe?=
 =?us-ascii?Q?9ym3NCDyGpXk6G6mUenODLc+bjLspm6hrdE9+arsQtJ0Q6bTZSL6gEiU5BVa?=
 =?us-ascii?Q?mI53aufFC9UHs6G8GFmf87p7pnD5tK4/pMiRU5cTfjnJ+GBeBthKB/HLS9s8?=
 =?us-ascii?Q?13BqFTeDWOMam/nBq1mZ0aGqEVwGScCUZ4zOQIGol+g7Udq6MCmoENA3OP4K?=
 =?us-ascii?Q?moQzHiQ5mwvFYRuINbTeBFORAWS2yOQY0poJ9TFA2WCWLyR/ZpIXWhAtpmGu?=
 =?us-ascii?Q?ShdaxtqgKmzDeAVMj7+VKhG//tumf1X+NpJccwMDAyB4lqql+cgWo72XErST?=
 =?us-ascii?Q?Pmx0+LgJUqhlP/DCUh2NiswdjRLgNf5tprm3a8nozY7EsZaqRRJcgFLECb5Z?=
 =?us-ascii?Q?5CBXTHdDpn5FB3b2YiMZkvvL6eOzyAVh4k/ctfpX2mfbYn3DC/ad7EuMn3J+?=
 =?us-ascii?Q?Mpu9fz6e08j9h7dSP8On5JHClcUqRuIwqL6IJO+IvFMyGbWPnil2ZhQ8Rn8P?=
 =?us-ascii?Q?W7OTzHEwEZJGMVT4fd7v/UbNS/stgcmA1jv0gb6lWDIBNA5j72xMmhsEliJe?=
 =?us-ascii?Q?uzKz70T6Qw91uNEz4l807nok1x7d9rjQiW8jMmbo6g7ZI8mUsmaMU/FrFs54?=
 =?us-ascii?Q?uZXUGM+Z0IYTBCj2MxFFk3CUDmCc9BCkCmZoIm3rKR46vCfQ3aypmXRMr7z2?=
 =?us-ascii?Q?1Rshk4MnHXs1gTDshlZ7lPBe3WI5gTpPfn8WiAMqO+O1TWGTMP1rlUqEeH3K?=
 =?us-ascii?Q?LBkIG4bI1kwScU1hfEMdOOQtHkDH5PHy1ulfNkr63EcK6UggsIxNn1+5VSip?=
 =?us-ascii?Q?7DoQTj69tApk+VSdmJcuWpragC8E4j9CXnzFjSAzBMFrbUs5OEYWyhclDIwq?=
 =?us-ascii?Q?yQBIcaJZ8CLSlCueILm4xuV6K5ZHoxDblXClny3ypB7eWIPyUsrldrV+aMok?=
 =?us-ascii?Q?AsmT++ndszGbvrj+AFq+TQq1HSYnRenVw+b+mVVFl/ekci99+rSl1tLro09t?=
 =?us-ascii?Q?ygSX1/GMTfSjJuoQYdH5tba7XxLtrYctNzpGk9awMirpDewEZ9oYmx7odJiu?=
 =?us-ascii?Q?e8+IKq82UZMfhTX+bS8d6/5GTW5uIa5z+srP7IKVNysw35CgPjB7QKfHMwRk?=
 =?us-ascii?Q?8Lz6gxTA8anqb3b4a0PC19LswqOMudC7tv9pRWuUA4E08Z/ee7n2F2uA3Ln9?=
 =?us-ascii?Q?upr4zIxpm4dnn++fu909aG9Tmj46FG+WRpKZqc4Ylz1DvXi9RVz3VEgCJrx9?=
 =?us-ascii?Q?kDMBsQmiqkpRFpghB9n8uJZblFggZmNsfTY86asA7day+RfgjNIvxVYS7tiZ?=
 =?us-ascii?Q?b46iq3uuujvfMLNpyJiEc0eN9AjmJG2x0k2bOB6WD2P6Pc3czvpjYhlmRjeN?=
 =?us-ascii?Q?vkSUQ33ebu9RKY8No1GPu/qbjIf3IeNEp6UjX2kIfiEwQ3e6y+2bIWrzDYDd?=
 =?us-ascii?Q?9WBBfM6Ax70EdMz/NzaCBKp4bYHuNX3BICHN7h74gUnQffhUVQr5zs3xej0L?=
 =?us-ascii?Q?apbV1PGbEg=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f64a9c5c-4ee0-4725-747a-08da25c7ee72
X-MS-Exchange-CrossTenant-AuthSource: HK2PR06MB3492.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2022 07:56:25.6638
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZCYIocPYHKjPFoJ/y1vqxT9tIQg2987HwDtrxO2QoKHZxYBIf+V/eyLVRgEagOFYLV1CUe0P0VSox59+BPOoBw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB4347
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

Fix the following coccicheck warning:

drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c:1604:2-4:
WARNING: possible condition with no effect (if == else).

Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
---
 .../realtek/rtlwifi/btcoexist/halbtc8821a1ant.c   | 15 ++++-----------
 1 file changed, 4 insertions(+), 11 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c
index a18dffc8753a..2f4c6a37a2e8 100644
--- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c
+++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c
@@ -1601,17 +1601,10 @@ static void btc8821a1ant_act_wifi_con_bt_acl_busy(struct btc_coexist *btcoexist,
 		}
 	} else if (bt_link_info->hid_exist && bt_link_info->a2dp_exist) {
 		/* HID+A2DP */
-		if ((bt_rssi_state == BTC_RSSI_STATE_HIGH) ||
-		    (bt_rssi_state == BTC_RSSI_STATE_STAY_HIGH)) {
-			btc8821a1ant_ps_tdma(btcoexist, NORMAL_EXEC,
-					     true, 14);
-			coex_dm->auto_tdma_adjust = false;
-		} else {
-			/*for low BT RSSI*/
-			btc8821a1ant_ps_tdma(btcoexist, NORMAL_EXEC,
-					     true, 14);
-			coex_dm->auto_tdma_adjust = false;
-		}
+		/* for low BT RSSI */
+		btc8821a1ant_ps_tdma(btcoexist, NORMAL_EXEC,
+				     true, 14);
+		coex_dm->auto_tdma_adjust = false;
 
 		btc8821a1ant_coex_table_with_type(btcoexist, NORMAL_EXEC, 1);
 	} else if ((bt_link_info->pan_only) ||
-- 
2.20.1