Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Kalle Valo <kvalo@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Johannes Berg <johannes.berg@intel.com>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     kael_w@yeah.net, Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH] wil6210: simplify if-if to if-else
Date:   Sun, 24 Apr 2022 17:45:50 +0800
Message-Id: <20220424094552.105466-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?q2JBGfkrtILwuqJN6eYjtNfRynRM9fBHLwFZzfsS4dh0xTOkVuSb7UR9Q0G0?=
 =?us-ascii?Q?5AqFMyyDjQttzeX/nZdq/zg/w/Jhy00yTquTTnAGmgN6jPIXWVogfiNPQHL+?=
 =?us-ascii?Q?7NHxIDTfqDhN8KSO+tVFHJ19PE2VLJfku5O3Ye2yxRh7BS0DOFAGoTrZ2SHF?=
 =?us-ascii?Q?9FOfGcLWkG5nHrDQwQxq78PYFENGw/mR4UBGP8hHnGQg8GtY3GgIe1tbabSw?=
 =?us-ascii?Q?wlS0Me54IA2FjcwWRiRmOkINJgBSKA0mKT83WW2oioC/lzFfHeRU5tOrxaHK?=
 =?us-ascii?Q?usCbY4/cXiK5qMTpOquXJQeDYTsGRj4rDD9aECC/kWHOxTtPWRjA4Yh/YAtu?=
 =?us-ascii?Q?fieKyCL4rV0FZ7dCFfgy84/DR+4otbu7yii6EJeS18R2RzyJsWpqpHBbjcCH?=
 =?us-ascii?Q?p1K4XLdkPp8/TioiAljwbwhiN5/LvhgfmahP6rplS+UOKsWUeGKPpzMAFo6n?=
 =?us-ascii?Q?raQSIG7E6kcHhjksv4QN5pVsO+daHHQWFpc+4+WlxHfIMuXBuRFKaUFz7IwY?=
 =?us-ascii?Q?9l1qOynawLAKiowhVfP3gAx1TA2xxcbrqYykR1r2g7XFbuPzFum9c+b5Zn6O?=
 =?us-ascii?Q?YNl+GznqCWaL2TJbAJTvnjh8ILTIpTui2ZuLJc7whclE2w5c6zsYT6zBRRU+?=
 =?us-ascii?Q?57kogu8AGLTe8bqAwgkDFumVCAqd508DPwe+8K0jViisaXHpwhopB8xnIDkc?=
 =?us-ascii?Q?J3sI4eGt32v42e6ogwDldmGFGC62TU7FXBU4SU3nMMEZYrGKTXbGusypGMbS?=
 =?us-ascii?Q?/184fjxtZaDNvnLyMWjoCOyCh71HjBUKr+hNKKMPNFtIgYtroIiM7g91l4g+?=
 =?us-ascii?Q?/h0WhBcvYog4KEjej8raAE9eyH24ObeMAke2bhBYVxEBp8j5iALqBYF8iUwe?=
 =?us-ascii?Q?IMqx36DxSbpgu+2MXXqNjT/nSC5pnNKs0/R+EZtCRu8fyJY4st0Iv78GduLv?=
 =?us-ascii?Q?bNB5F+E0o8TzHLhlgSivnNF+uwYLd/k5M+/RKhl0nCipbFG+rWuYgJnyigCr?=
 =?us-ascii?Q?2z6jFQH0iozy1jX0oa/jeIhoXN/eQLfPIfvrvOAO3lqPe9XM7wIZU1Am+1Pk?=
 =?us-ascii?Q?wP9NDCK0m4kVfqR8w/m3hPXqvaokEsdhectrC4LIjJ6c/sRoRlPs+EcLV0+V?=
 =?us-ascii?Q?Iu+1wsFDYp88OxtDcowFaC8iG+va9jM7cqpnxYSkFB2a2jKjh54F9RrpW7ST?=
 =?us-ascii?Q?UyOhRxtJzGkTxsHfOCyO3pKZF8sT4uR75pPg024DREXmEAg6+pG6dIoYyKgp?=
 =?us-ascii?Q?51Ny8AXihr4c9cnz4vEQvsQK/kL3elNbQM5LjRrP5tZls+wgaU+LV6IetTL9?=
 =?us-ascii?Q?00Q+LMi4Z4o6FZVtyRYONBubyppvcJM18QMpX58wPBBieYqOBZxGv8lVQ431?=
 =?us-ascii?Q?yIGXOCC84lfoirGy+fN1AOImYAQZ5+J/gbiuRnveJrZBlRkWyBVjYuzzSBWm?=
 =?us-ascii?Q?0C5Hrq4Oc7bG1xwE7EMUMp6wVtub5YNliUCfMhNvtK2qXafNx1nsBm4nQUKR?=
 =?us-ascii?Q?/YAZJvKBBbQDf39nhcnAunVSnfHulwG8zJP7rai4iHHSr1pXVgE3hncStT0e?=
 =?us-ascii?Q?WLYzcaawC6k+3uqF0mOba5IPDgrfCAg07t3xOh+aXHuhx0d+AebpIX1hFEAN?=
 =?us-ascii?Q?KKV2qJhqmt8ir2jGRn+dwNLV06OYNxFMu3w7B/QaLAZZBVwMcQ56IBkPSqQc?=
 =?us-ascii?Q?1LpTipE/1vU/IMzjDmDnOpvUcazs5FczYqZ/CRV6gad2AKAg4dmMIx98YaVD?=
 =?us-ascii?Q?4BGtU3wOiA=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a904c91e-52ce-42e5-4c72-08da25d73ef9
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2022 09:46:03.3255
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IvawlaOAtWCriKvBLZGA/VtC41FG6S0/TCCLTU7XvawOvaA1+pHEY1pk9clitLgiteZ4TRUEb9msyFKghSagjA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR06MB2925
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

Use if and else instead of if(A) and if (!A).

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/net/wireless/ath/wil6210/cfg80211.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ath/wil6210/cfg80211.c b/drivers/net/wireless/ath/wil6210/cfg80211.c
index 764d1d14132b..8f2638f5b87b 100644
--- a/drivers/net/wireless/ath/wil6210/cfg80211.c
+++ b/drivers/net/wireless/ath/wil6210/cfg80211.c
@@ -1653,10 +1653,9 @@ static int wil_cfg80211_add_key(struct wiphy *wiphy,
 				params->seq_len, params->seq);
 			return -EINVAL;
 		}
-	}
-
-	if (!IS_ERR(cs))
+	} else {
 		wil_del_rx_key(key_index, key_usage, cs);
+	}
 
 	if (params->seq && params->seq_len != IEEE80211_GCMP_PN_LEN) {
 		wil_err(wil,
-- 
2.35.1