Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Guo Zhengkui <guozhengkui@vivo.com>
To:     Ping-Ke Shih <pkshih@realtek.com>, Kalle Valo <kvalo@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Guo Zhengkui <guozhengkui@vivo.com>,
        linux-wireless@vger.kernel.org (open list:REALTEK WIRELESS DRIVER
        (rtlwifi family)),
        netdev@vger.kernel.org (open list:NETWORKING DRIVERS),
        linux-kernel@vger.kernel.org (open list)
Cc:     zhengkui_guo@outlook.com
Subject: [PATCH v2] rtlwifi: btcoex: fix if == else warning
Date:   Mon, 25 Apr 2022 11:17:23 +0800
Message-Id: <20220425031725.5808-1-guozhengkui@vivo.com>
In-Reply-To: <0355f52ad7bf46454af4d5cb28fd6d59f678c25f.camel@realtek.com>
References: <0355f52ad7bf46454af4d5cb28fd6d59f678c25f.camel@realtek.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pm/LAZVTmrW3cgP7UxwGPmJEH56oX9v5eDKvRCtbydb3ZXvLAHR6IEcsevAI?=
 =?us-ascii?Q?sz61vD9WVxjkbYkCRYN5V4zqCZy75uD/Dox/IiFid8XH4j24SWjhEYd8yOBN?=
 =?us-ascii?Q?2UfKVN8HA6ESJSbvojtGVsyQAJ6FSm2vEvsL/lrOPEiIvNfI5y5J2yxeh4aJ?=
 =?us-ascii?Q?ns0kolcj5jJIonoEi0xJTcRJjpb93cxxtRiylfFoOGcM581751IHNvvE02we?=
 =?us-ascii?Q?vdsBJ3PoGz+Wtg30xCc+gxG5UtC8pnjufLkZrpA96n7XQ1UMVRJZnKL8FhwP?=
 =?us-ascii?Q?jauHChs97OG0CHgpC5fzev4M0NjuN0AJu6ZjudcW2Pa8LrW0vVMkLDrnI8c+?=
 =?us-ascii?Q?7R6JVyoYDbb3RsHjzqR/iRlP14IK8BtHpq6d3ooAKS8g4OtXXFMr7Nct7Kow?=
 =?us-ascii?Q?ykgFIXWIaOJ2RIxpnf5e9FxvOOZtAbKk60OoLs2f5mfzmRIxIexjnB70mgqL?=
 =?us-ascii?Q?QkCoDuACXKs+kKaTu7736oz20ZyRgqWdlBPCR9csKe8rVeZVSiPPdLNx0+18?=
 =?us-ascii?Q?hSR8pT38+zFcN9CjMP5qnFMxK+/dReyAwIplZdcfR3GKrtmRg5+Rqy6MSsct?=
 =?us-ascii?Q?TT6FeohUUDx6mHQNS2qkYWIeukGw3HtecWNwraw+FH4O2s8P2ZEpv+EEqkq3?=
 =?us-ascii?Q?YXIOlIuAGdXjPGCbQhtjlCPODdzsaCaN3HlJeHp8uU9jutQykZS68pP2VsTr?=
 =?us-ascii?Q?DRiLHUSJeVsQWEBPhSzpgzQ/E11Rapihk9IbSMQF7gNrsT5vYUM8bugJIkrJ?=
 =?us-ascii?Q?K8E1odlqVKd9Pd5TyWh3/aYUpCmYN/W8z3vOA9wwkvfn9KK8sRCw+NDxNLNr?=
 =?us-ascii?Q?WCbn6xuV1dVu3ZIuIQm8lKYfyfYFDQ6MLlCyZnYBruEOAM8p2GOXu5RgXHFD?=
 =?us-ascii?Q?kDHY/q0p25ePoEF1ATAN7CoLrascCbWT4RXEuXG7LpXtljy4N/cwonMMqE+D?=
 =?us-ascii?Q?Dejl6ovTobrcFHZjCjXOvpN701/+Q8rVPxah74g9hB3I8fNOb1XjKCkG1gkf?=
 =?us-ascii?Q?ugcPL/P6MaCf2sVsw4zBtX3QBcH4uNGp5G9FYVn7rGVYqdcPB7AIpO09yLr6?=
 =?us-ascii?Q?uaJjVddGyIjq6WOkBRFXHjbF7qKj2qBajwRMzfFhhIhNyUOYzr+oUE/EelHz?=
 =?us-ascii?Q?FLT2rYSPlGqY9YFAg3ZSao/YEtUro+pajLA1v+HYcpnlQCMtHXH7ol1WSnPu?=
 =?us-ascii?Q?ClEPZayRGXNEMorEXe8mhMBOaifnKfzDnyo8CnDll6zsCvKuZO/T3q9bnNYJ?=
 =?us-ascii?Q?ldlwx8W53JQs0Cef6mAg6TLUCMGTnHhfD476zag9Cc77AOPLcWFea4UYsuDx?=
 =?us-ascii?Q?RvO+5umSZ1B57NlW4yx2cmQq3eSKXueJdMlGNVV5HYrcyhjXw9fCIXARBHXg?=
 =?us-ascii?Q?i1JjHDTabQugvU5E2VTchwgBmo7q7nM9nOC8T+icx8UfDDEqaGW0dFvfKyiP?=
 =?us-ascii?Q?dHTiQzEYJ5v1yOJr4MVLRgQmG2NUp66pU8FEJCT94SwXgt+ybROMjy5U+WJt?=
 =?us-ascii?Q?eKVunzPB++rC55b5LAMAglBewuEqc9/T9i2HLNxb0mv8PByq1t39k7RNZvq0?=
 =?us-ascii?Q?IFUPdIA8aMuhguvU+TmY0QwBdK7TWVCfSlML8uqp8PgNpvaULEOdpooAwrnI?=
 =?us-ascii?Q?zZYjpT9JpHp8x8D2mwGVL6Sm8AX3dWYlV4OsTapC6NbROY1el9dZxzad+Zb9?=
 =?us-ascii?Q?eHUEj3QjaSiDlYuyj2fqxJb/SE0iOJ89a1FgDhqfa6ujgns975hom0jMw03i?=
 =?us-ascii?Q?DTbUYOtjzQ=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 31e1e904-b3ce-4f1c-1d5f-08da266a2f67
X-MS-Exchange-CrossTenant-AuthSource: HK2PR06MB3492.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 03:17:53.2365
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sYOvYXyD6uXEnpuK31BSwDZVuU6XR0Wc7NrWOytHZIoBt8D5TeW5aSxx2rsjL3XEtQekkAnIcjWDE7SacypsdA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB3897
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

Fix the following coccicheck warning:

drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c:1604:2-4:
WARNING: possible condition with no effect (if == else).

Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
---
v1 -> v2: Modify the comment according to Ping-Ke's suggestion.

 .../realtek/rtlwifi/btcoexist/halbtc8821a1ant.c  | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c
index a18dffc8753a..67d0b9aee064 100644
--- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c
+++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c
@@ -1600,18 +1600,10 @@ static void btc8821a1ant_act_wifi_con_bt_acl_busy(struct btc_coexist *btcoexist,
 			coex_dm->auto_tdma_adjust = false;
 		}
 	} else if (bt_link_info->hid_exist && bt_link_info->a2dp_exist) {
-		/* HID+A2DP */
-		if ((bt_rssi_state == BTC_RSSI_STATE_HIGH) ||
-		    (bt_rssi_state == BTC_RSSI_STATE_STAY_HIGH)) {
-			btc8821a1ant_ps_tdma(btcoexist, NORMAL_EXEC,
-					     true, 14);
-			coex_dm->auto_tdma_adjust = false;
-		} else {
-			/*for low BT RSSI*/
-			btc8821a1ant_ps_tdma(btcoexist, NORMAL_EXEC,
-					     true, 14);
-			coex_dm->auto_tdma_adjust = false;
-		}
+		/* HID+A2DP (no need to consider BT RSSI) */
+		btc8821a1ant_ps_tdma(btcoexist, NORMAL_EXEC,
+				     true, 14);
+		coex_dm->auto_tdma_adjust = false;
 
 		btc8821a1ant_coex_table_with_type(btcoexist, NORMAL_EXEC, 1);
 	} else if ((bt_link_info->pan_only) ||
-- 
2.20.1