Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9560c693-8dd5-ba68-69ca-dd3d213584e6@quicinc.com>
Date:   Tue, 26 Apr 2022 17:12:28 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [RFC PATCH] cfg80211: do some rework towards MLO link APIs
Content-Language: en-CA
To:     Johannes Berg <johannes@sipsolutions.net>,
        <linux-wireless@vger.kernel.org>
References: <20220414145522.116716-1-johannes@sipsolutions.net>
 <f137ca7f-8b59-3368-c666-247f83d80383@quicinc.com>
 <6b40798e349d11e495a6df20ecba479a8357dad2.camel@sipsolutions.net>
From:   Vasanthakumar Thiagarajan <quic_vthiagar@quicinc.com>
In-Reply-To: <6b40798e349d11e495a6df20ecba479a8357dad2.camel@sipsolutions.net>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/26/2022 12:46 PM, Johannes Berg wrote:
>>   > +	if (internal_flags & NL80211_FLAG_MLO_VALID_LINK_ID) {
>>   > +		struct nlattr *link_id = info->attrs[NL80211_ATTR_MLO_LINK_ID];
> 
> [...]
>>   > +		/* non-MLO -> no link ID attribute accepted */
>>   > +		if (!wdev->valid_links && link_id) {
>>
>> Isn't that we hit this condition when adding the very first link to the
>> MLD using NL80211_CMD_ADD_LINK?
>>
> 
> Oh, I don't think CMD_ADD_LINK would set NL80211_FLAG_MLO_VALID_LINK_ID,
> that's just helper functionality for those commands that expect
> everything to already be set up.

got it, thanks!

Vasanth