Received-SPF: softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] rtw88: use the correct bit in the REG_HCI_OPT_CTRL
 register
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <YmLAzuyPr0P4Y6BP@ns.kevlo.org>
References: <YmLAzuyPr0P4Y6BP@ns.kevlo.org>
To:     Kevin Lo <kevlo@kevlo.org>
Cc:     Ping-Ke Shih <pkshih@realtek.com>, linux-wireless@vger.kernel.org
User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <165103549637.18987.9142437749277361997.kvalo@kernel.org>
Date:   Wed, 27 Apr 2022 04:58:18 +0000 (UTC)
Precedence: bulk

Kevin Lo <kevlo@kevlo.org> wrote:

> Write the BIT_USB_SUS_DIS bit rather than BIT_BT_DIG_CLK_EN to the
> REG_HCI_OPT_CTRL register for fixing failure to PCIe power on.
> 
> Signed-off-by: Kevin Lo <kevlo@kevlo.org>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> 
> diff --git a/drivers/net/wireless/realtek/rtw88/mac.c b/drivers/net/wireless/realtek/rtw88/mac.c
> index d1678aed9d9c..caf2603da2d6 100644
> --- a/drivers/net/wireless/realtek/rtw88/mac.c
> +++ b/drivers/net/wireless/realtek/rtw88/mac.c
> @@ -75,7 +75,7 @@ static int rtw_mac_pre_system_cfg(struct rtw_dev *rtwdev)
>  
>  	switch (rtw_hci_type(rtwdev)) {
>  	case RTW_HCI_TYPE_PCIE:
> -		rtw_write32_set(rtwdev, REG_HCI_OPT_CTRL, BIT_BT_DIG_CLK_EN);
> +		rtw_write32_set(rtwdev, REG_HCI_OPT_CTRL, BIT_USB_SUS_DIS);
>  		break;
>  	case RTW_HCI_TYPE_USB:
>  		break;

Patch applied to wireless-next.git, thanks.

fc6234d7e2e3 rtw88: use the correct bit in the REG_HCI_OPT_CTRL register

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/YmLAzuyPr0P4Y6BP@ns.kevlo.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches