Received-SPF: softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <d377a595-c816-30f6-0386-442e10a81b9e@quicinc.com>
Date:   Wed, 27 Apr 2022 11:26:41 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH v2 12/19] ath11k: Datapath changes to support WCN6750
Content-Language: en-US
To:     Kalle Valo <kvalo@kernel.org>
CC:     <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <robh@kernel.org>
References: <1642337235-8618-1-git-send-email-quic_mpubbise@quicinc.com>
 <1642337235-8618-13-git-send-email-quic_mpubbise@quicinc.com>
 <87ilqvgkgo.fsf@kernel.org>
 <bd125d43-2f0c-f791-7bbe-f4333896722b@quicinc.com>
 <878rrrgjpb.fsf@kernel.org>
From:   Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
In-Reply-To: <878rrrgjpb.fsf@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/27/2022 11:18 AM, Kalle Valo wrote:
> Manikanta Pubbisetty <quic_mpubbise@quicinc.com> writes:
> 
>> On 4/27/2022 11:02 AM, Kalle Valo wrote:
>>> Manikanta Pubbisetty <quic_mpubbise@quicinc.com> writes:
>>>
>>>> HAL RX descriptor for WCN6750 is same as QCN9074, so use
>>>> the DP APIs of QCN9074 for WCN6750. There is one change
>>>> wrt to REO configuration though, REO configuration for
>>>> WCN6750 is same as WCN6855; Therefore, use reo_setup()
>>>> of WCN6855 for WCN6750.
>>>>
>>>> Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00573-QCAMSLSWPLZ-1
>>>> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-01720.1-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1
>>>> Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.5.0.1-01100-QCAHKSWPL_SILICONZ-1
>>>> Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.4.0.1-00192-QCAHKSWPL_SILICONZ-1
>>>>
>>>> Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
>>>> ---
>>>>    drivers/net/wireless/ath/ath11k/core.c |  1 +
>>>>    drivers/net/wireless/ath/ath11k/hw.c   | 31 +++++++++++++++++++++++++++++++
>>>>    2 files changed, 32 insertions(+)
>>>>
>>>> diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c
>>>> index 347131a..f65347c 100644
>>>> --- a/drivers/net/wireless/ath/ath11k/core.c
>>>> +++ b/drivers/net/wireless/ath/ath11k/core.c
>>>> @@ -458,6 +458,7 @@ static const struct ath11k_hw_params ath11k_hw_params[] = {
>>>>    		.num_vdevs = 16 + 1,
>>>>    		.num_peers = 512,
>>>>    		.supports_suspend = false,
>>>> +		.hal_desc_sz = sizeof(struct hal_rx_desc_qcn9074),
>>>
>>> You mention nothing about this change in the commit log, I'll add that.
>>>
>>
>> I did mention that "HAL RX descriptor for WCN6750 is same as QCN9074",
>> you were looking at something specific?
> 
> If I'm understanding correctly, by accident hal_desc_sz was not
> initialised for qcn9074. If that's the case, it would be good to mention
> that in the commit log.
> 

If I understand your comment correctly, since HAL RX descriptor is 
related to data path, I thought of adding it as part of the data path
patch.

Thanks,
Manikanta