Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fec83652-b8ed-8ad5-ff9a-db17655634ee@quicinc.com>
Date:   Thu, 28 Apr 2022 11:00:01 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] mac80211: Reset MBSSID parameters upon connection
Content-Language: en-US
To:     Johannes Berg <johannes@sipsolutions.net>
CC:     <linux-wireless@vger.kernel.org>
References: <20220427182305.11703-1-quic_mpubbise@quicinc.com>
 <ca53bf4ce43f967723125313d5285cc40eb7d3f4.camel@sipsolutions.net>
From:   Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
In-Reply-To: <ca53bf4ce43f967723125313d5285cc40eb7d3f4.camel@sipsolutions.net>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/28/2022 12:41 AM, Johannes Berg wrote:
> On Wed, 2022-04-27 at 23:53 +0530, Manikanta Pubbisetty wrote:
>> Currently MBSSID parameters in struct ieee80211_bss_conf
>> are not reset upon connection. This could be problematic
>> with some drivers in a scenario where the device first
>> connects to a non-transmit BSS and then connects to a
>> transmit BSS of a Multi BSS AP. The MBSSID parameters
>> which are set after connecting to a non-transmit BSS will
>> not be reset and the same parameters will be passed on to
>> the driver during the subsequent connection to a transmit
>> BSS of a Multi BSS AP.
>>
>> For example, firmware running on the ath11k device uses the
>> Multi BSS data for tracking the beacon of a non-transmit BSS
>> and reports the driver when there is a beacon miss. If we do
>> not reset the MBSSID parameters during the subsequent
>> connection to a transmit BSS, then the driver would have
>> wrong MBSSID data and FW would be looking for an incorrect
>> BSSID in the MBSSID beacon of a Multi BSS AP and reports
>> beacon loss leading to an unstable connection.
>>
>> Reset the MBSSID parameters upon every connection to solve this
>> problem.
> 
> Oops. Please add (or at least provide) a Fixes line though.
> 

Sure Johannes, just sent V2 patch with the Fixes line added.

Thanks,
Manikanta