Received-SPF: softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Kalle Valo <kvalo@kernel.org>
To:     Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc:     =?utf-8?B?SsOpcsO0bWU=?= Pouiller <jerome.pouiller@silabs.com>,
        linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wfx: avoid flush_workqueue(system_highpri_wq) usage
In-Reply-To: <3841528e-78ae-c3c4-169a-eeb39714f7ca@I-love.SAKURA.ne.jp>
        (Tetsuo Handa's message of "Sun, 1 May 2022 19:23:16 +0900")
References: <20220225112405.355599-1-Jerome.Pouiller@silabs.com>
        <20220225112405.355599-10-Jerome.Pouiller@silabs.com>
        <033f49bc-cc31-7384-7a7c-5d3c45ce9594@I-love.SAKURA.ne.jp>
        <4557835.LvFx2qVVIh@pc-42>
        <e25078f4-96f4-482c-b5da-a4a22d88b072@I-love.SAKURA.ne.jp>
        <87fsltd462.fsf@kernel.org>
        <3841528e-78ae-c3c4-169a-eeb39714f7ca@I-love.SAKURA.ne.jp>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
Date:   Mon, 02 May 2022 09:25:48 +0300
Message-ID: <87a6c0cuxf.fsf@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> writes:

> On 2022/05/01 17:53, Kalle Valo wrote:
>> So now the thread is created every time the module loaded, even if
>> there's no device available.
>
> Excuse me, but what thread?

Sorry, s/thread/workqueue/.

> alloc_workqueue() without WQ_MEM_RECLAIM flag does not create a
> thread, and therefore consumes little resource where there's no device
> available does not matter.

It still allocating memory which is not needed. To me allocating
resources during module_init is wrong.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches