Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp239762iob; Mon, 2 May 2022 18:11:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyFt9Zm39Ossvn1oAUSNJpiE/6WSNtwEB6y+4bu7SkQvzhmqJkoptz3fU9Zn2G1b2prOf1x X-Received: by 2002:a17:90b:4a8d:b0:1dc:3769:20fc with SMTP id lp13-20020a17090b4a8d00b001dc376920fcmr2089622pjb.114.1651540296539; Mon, 02 May 2022 18:11:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651540296; cv=none; d=google.com; s=arc-20160816; b=grDdB9ZwyxuJse/8y0/wFOXupYHDy9qduWINJn8VkPoNx6xRRN39fXXeCXSExFmrFi VBya7wQBAQHcCS8i656V5mzU6pn6v8TSKi4+BlRoH4gEYMto3rwZR38xQgve4/18nhKw HrLfWlrrpiCUx7NfARZC5JSYkoYge8gEWzVXYV4kXlSgq4A9AQUE/iqKqtH139zFLD45 GG4NN/CqOyALWtULh8KrS3pUR42VpKXP4GYQqpkOCJCoL2qwvRLi2jSJubo/VzRbn24y /XdLpKZAd69e5sYY9VGr8ZJBy80MvhO3NKOmk061GMsnNxAHyYTB7BVaMrH9OEjn0mPF ZWZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=4KBE1OMmEKnkQ1ETFtryRLO7as/x0YalIbzWB8FwvWU=; b=gXtp4JeFiSQog00w6i/5WW6WyYaa5YETksfVDU5lnP8RKtqduUmzhqwOSEV9uSKwYw EsQZxYW2rrEbsH/NOO5t4evOThug7Nyfw0pnbQWVrLvm/lZu8Lix79Whl8B+GJX//BmH dZOA9MebeVCYJmMocXARzhyzZnZS+iM8FbC90rUyxrGPdPRq+iZnUrti1wEmoP0AxMno qJqWO32rm8EQA6HO0n4itMP/2EEcOlF2Zrxriowfw2eI79lPRUsftx4iH5HU4D9wagAp TsDVnOTNkEfYg3HkS8PUMy2ua/gWsvJ8/ngsAWNZbL1aRs1TniNTG3cvuqun50qDvzlM /9OQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rhtgqWpN; spf=softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id cj24-20020a056a00299800b0050d8d0e5d5csi452768pfb.243.2022.05.02.18.11.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 May 2022 18:11:36 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rhtgqWpN; spf=softfail (google.com: domain of transitioning linux-wireless-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E4DFD5C879; Mon, 2 May 2022 17:53:00 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1385470AbiEBOE1 (ORCPT + 68 others); Mon, 2 May 2022 10:04:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1385467AbiEBOEZ (ORCPT ); Mon, 2 May 2022 10:04:25 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 335825F75; Mon, 2 May 2022 07:00:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E7677B81147; Mon, 2 May 2022 14:00:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98B8FC385AC; Mon, 2 May 2022 14:00:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651500054; bh=LnW2rQnd7IzWF/OG/CrCr2IFtLGxNBoAByjw1ptUJik=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=rhtgqWpNJlQBCsFtXzZdQrzg0yOi0tjVjo8Xf5ZM9gFaOA6ZjnQk9fJCLRrnsutg2 3IQlsb6crkR/t1Deg0j2n9X30V4gCVTcovaDGU3QKyJPp2YmbRYcX4MlnmCaApJ5yL k3VfWEgY/dgkrK7lN1Y21D7NuO/YyGAzN22FxLeoghU1qw4L6UJ6M13+aFIBwXUaBK j5vTDbMo2sioPxPOhqmDXMQBv0dKZNEL6TnrzGzl7/jqfFGhnKGQzWy5wFMdyWAs+b 5qPX39TjwPkjjK3n8deSOFo6jNPP1QKpm+8LjLKSOLIO/7TEeDeAN4v8hlwCtmQDZh lOqeZ1NDTnHCQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] carl9170: tx: fix an incorrect use of list iterator From: Kalle Valo In-Reply-To: <20220328122820.1004-1-xiam0nd.tong@gmail.com> References: <20220328122820.1004-1-xiam0nd.tong@gmail.com> To: Xiaomeng Tong Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, linville@tuxdriver.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Xiaomeng Tong , stable@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <165150005048.16977.15575451697134497197.kvalo@kernel.org> Date: Mon, 2 May 2022 14:00:52 +0000 (UTC) X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Xiaomeng Tong wrote: > If the previous list_for_each_entry_continue_rcu() don't exit early > (no goto hit inside the loop), the iterator 'cvif' after the loop > will be a bogus pointer to an invalid structure object containing > the HEAD (&ar->vif_list). As a result, the use of 'cvif' after that > will lead to a invalid memory access (i.e., 'cvif->id': the invalid > pointer dereference when return back to/after the callsite in the > carl9170_update_beacon()). > > The original intention should have been to return the valid 'cvif' > when found in list, NULL otherwise. So just return NULL when no > entry found, to fix this bug. > > Cc: stable@vger.kernel.org > Fixes: 1f1d9654e183c ("carl9170: refactor carl9170_update_beacon") > Signed-off-by: Xiaomeng Tong > Acked-by: Christian Lamparter > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 54a6f29522da carl9170: tx: fix an incorrect use of list iterator -- https://patchwork.kernel.org/project/linux-wireless/patch/20220328122820.1004-1-xiam0nd.tong@gmail.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches