Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 4 May 2022 16:25:51 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Stefano Brivio <sbrivio@redhat.com>
Cc:     Jaehee <jhpark1013@gmail.com>, Kalle Valo <kvalo@kernel.org>,
        =?iso-8859-1?B?Suly9G1l?= Pouiller <jerome.pouiller@silabs.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
        Outreachy Linux Kernel <outreachy@lists.linux.dev>
Subject: Re: [PATCH] wfx: use container_of() to get vif
Message-ID: <20220504132551.GD4009@kadam>
References: <20220418035110.GA937332@jaehee-ThinkPad-X1-Extreme>
 <87y200nf0a.fsf@kernel.org>
 <CAA1TwFCOEEwnayexnJin8T=Fc2HEgHC9jyfj5HxfiWybjUi9GA@mail.gmail.com>
 <20220504093347.GB4009@kadam>
 <20220504135059.7132b2b6@elisabeth>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220504135059.7132b2b6@elisabeth>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aNr/Vyia9lPs7nwzu/lGufE8hc0ra4ecE0o/E8tbAHjzQPoAHHkkzLFFVY8I?=
 =?us-ascii?Q?8B4KdypiZErLe6eWsNH4YV4G0modmf4nIQm4rKVdRh/tjxazuKHsKiKh0NSJ?=
 =?us-ascii?Q?+otTyXFiEyTQjyHk+wju6ncSL+FM78QrvHxzi5pXDl/8G4Vb6PvxxnRBxfJG?=
 =?us-ascii?Q?ZeU723AUCI6XHFQJfYUuFTE2a27+2BGT0NI92ONsgLr2Y+PdhoTwsvFRXq5x?=
 =?us-ascii?Q?rwtBbQVOxqcQlfz4q7EZUJq5MQl/JvcHAB8eZtM/PD947CPiazO+EmK9MMZl?=
 =?us-ascii?Q?OmNDlZQRSvbKiTcOW73Vmb8gxHtgRqWzihxl+75NrSTB6LzGfTJBy81/u620?=
 =?us-ascii?Q?+KTRcb//JtYM6KNsihLIMQZWOtj72bGuWKIF6NOoO6nsrpb5Q7zfH3AgSE1y?=
 =?us-ascii?Q?svzLHfGiV7O8VEkzjAwMH4H7U1rngZ0vuB5/YP2qo5EiM8CJVz5BoxqTdNGH?=
 =?us-ascii?Q?Ggcl2++WMfJ03rYoAGXgOtjS0hP3XKiKhmRF6QPXdIfcOVU8lVAqPl0wD8Cq?=
 =?us-ascii?Q?47FHgf29T4x2FjonAx5eSdWonr2UzgsTDvqTdNzcZyo7vmyIbhxsUO8P2uhi?=
 =?us-ascii?Q?WzmNUngDa7S1OLRlI/MNYDv4hW9RxIACGQiMPuC11omNvX9hu/UHW8p5WwHU?=
 =?us-ascii?Q?SsjVI11vCEakonGrmUTVGe08JhwlXtyYJyzjKb4m9ZGvOs6PUJaadTewruuF?=
 =?us-ascii?Q?AjxTu3QbZXvW3+/XztswvcTSFJDS0nwrCIs/PQyHzRBFt+LTxErQALXAGm6J?=
 =?us-ascii?Q?qWGYHHFc5r2xt/Ut6Uf3YqVjXYuTxb2jSGKzBAdYCqVW860g06VEDJf3yls3?=
 =?us-ascii?Q?k/u6wKb4pmf6PTkdMPY3A9QNhqIAk+1B0HV65sH2cxp9ZZniSizxGQFrC1Vs?=
 =?us-ascii?Q?ogIwfgZ+pkN4PDI0HNdTzPUTlFMcdlsNAyuZGnh3B5La0wYlQunKqYHGJgUx?=
 =?us-ascii?Q?PuOqXzuT823Je+oKGlrNrDVGGCqSlGlJ9so1nlj3gyZ1u5ddL3iz+7XVPows?=
 =?us-ascii?Q?XiwjkOZs/2oDsq6XxDvwXQMQqzOhNpPqvdrX9l5vMG7CTmnXngDkqPQXDzPB?=
 =?us-ascii?Q?1iCwRtFhV0PK64EKLbAZngOJs1bU9whyO0TRRlnJHCDkSSY3w0yW/BVWb8u9?=
 =?us-ascii?Q?ANpzq6JJhdofYsddVd0acjaUBRLPS36far2BDME0lEOZKwzUiSaCyTV8z6Ls?=
 =?us-ascii?Q?K7K9AvJqNWgwFBuukzMoTS/gaxlYlgtmh0CNtB5w0VgLzXb9kEsNiI2mln+G?=
 =?us-ascii?Q?o4SS0eUTJjnJy+O1ynR/yrq16CKOmTAwY0uTw789qtszr2QC1xSkUqFGOjvl?=
 =?us-ascii?Q?R89MPtuuQ1TH4ALfMA0S/OPfy5uhCoOJUzoVC4RH3V++t9n1t2wCgO3kbQ6Q?=
 =?us-ascii?Q?L+0iEYwek7OH7wy3FTt2DQLMA//Cdky7zhA/OQVlG0BYnL80uaDbl2JUXt7l?=
 =?us-ascii?Q?BTGW43BGtYbFUEamHe7F28Z7IMpWjQMzOx5N8pW5vo+2BXVZwqAbHu2kx8D8?=
 =?us-ascii?Q?Kix8y/0nphXZvX/YHKf4ExQVFw30Hfo4XL7nWwGohNRr1/T4xpAb7h9ZOGDn?=
 =?us-ascii?Q?jDUwHH9XCgpH0Cu8Ot7yP/v9BZVxpfsftqTsibFwV8hYF7sEWuE0393Nf2As?=
 =?us-ascii?Q?pjMGfl3uUxipb0tm5/NZ/Zi09xPswe7UcAL+1Q0NiJBfs6N8AZ/NXCtkwrIV?=
 =?us-ascii?Q?juuUl8J53AKem7DJCv/hjo1/FQwFX3pzk0ERoSiCPhk4rEMY24NMnH9mIxp1?=
 =?us-ascii?Q?frwi/2b8VtGEOp7BoIwaNaDPdl17/JU=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5a1019d6-917c-4081-ca83-08da2dd1a887
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 13:26:12.7420
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ippmVmAc1/+KRZLd5TYzNS2IMCd2Rxh+7YlYP1chWbZHxmJJz6/7TljaVqsgZQJ3zMs4VMJsa6NevmYMMjApIJ43wXwpXLJ2QZ5T+Rq265Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5632
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-05-04_04:2022-05-04,2022-05-04 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0
 mlxlogscore=999 spamscore=0 bulkscore=0 mlxscore=0 phishscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2205040085
X-Proofpoint-ORIG-GUID: mXdSOyF_xKPnOPUGmQoLEIXxNHlnqx38
X-Proofpoint-GUID: mXdSOyF_xKPnOPUGmQoLEIXxNHlnqx38
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Wed, May 04, 2022 at 01:50:59PM +0200, Stefano Brivio wrote:
> And that it's *obvious* that container_of() would trigger warnings
> otherwise. Well, obvious just for me, it seems.

:P

Apparently it wasn't obvious to Kalle and me.  My guess is that you saw
the build error.  Either that or Kalle and I are geezers who haven't
looked at container_of() since before the BUILD_BUG_ON() was added five
years ago.

regards,
dan carpenter