Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f2f27831-03eb-3788-5855-649c0f33c785@quicinc.com>
Date:   Tue, 3 May 2022 08:17:55 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH 1/2] ath11k: mac: fix too long line
Content-Language: en-US
To:     Kalle Valo <kvalo@kernel.org>, <ath11k@lists.infradead.org>
CC:     <linux-wireless@vger.kernel.org>
References: <20220503060415.24499-1-kvalo@kernel.org>
From:   Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <20220503060415.24499-1-kvalo@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/2/2022 11:04 PM, Kalle Valo wrote:
> From: Kalle Valo <quic_kvalo@quicinc.com>
> 
> checkpatch warns:
> 
> drivers/net/wireless/ath/ath11k/mac.c:7760: line length of 91 exceeds 90 columns
> 
> This was introduced by commit 046d2e7c50e3 ("mac80211: prepare sta handling for
> MLO support").
> 
> Compile tested only.
> 
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
> ---
>   drivers/net/wireless/ath/ath11k/mac.c | 12 ++++++++----
>   1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
> index c76cac5d6849..32fb0142124d 100644
> --- a/drivers/net/wireless/ath/ath11k/mac.c
> +++ b/drivers/net/wireless/ath/ath11k/mac.c
> @@ -7735,6 +7735,7 @@ ath11k_mac_validate_vht_he_fixed_rate_settings(struct ath11k *ar, enum nl80211_b
>   	bool he_fixed_rate = false, vht_fixed_rate = false;
>   	struct ath11k_peer *peer, *tmp;
>   	const u16 *vht_mcs_mask, *he_mcs_mask;
> +	struct ieee80211_link_sta *deflink;
>   	u8 vht_nss, he_nss;
>   	bool ret = true;
>   
> @@ -7757,13 +7758,16 @@ ath11k_mac_validate_vht_he_fixed_rate_settings(struct ath11k *ar, enum nl80211_b
>   	spin_lock_bh(&ar->ab->base_lock);
>   	list_for_each_entry_safe(peer, tmp, &ar->ab->peers, list) {
>   		if (peer->sta) {
> -			if (vht_fixed_rate && (!peer->sta->deflink.vht_cap.vht_supported ||
> -					       peer->sta->deflink.rx_nss < vht_nss)) {
> +			deflink = &peer->sta->deflink;


is there a reason to not declare deflink here?
then its scope of definition would equal the scope of usage


> +
> +			if (vht_fixed_rate && (!deflink->vht_cap.vht_supported ||
> +					       deflink->rx_nss < vht_nss)) {
>   				ret = false;
>   				goto out;
>   			}
> -			if (he_fixed_rate && (!peer->sta->deflink.he_cap.has_he ||
> -					      peer->sta->deflink.rx_nss < he_nss)) {
> +
> +			if (he_fixed_rate && (!deflink->he_cap.has_he ||
> +					      deflink->rx_nss < he_nss)) {
>   				ret = false;
>   				goto out;
>   			}
> 
> base-commit: f39af96d352dd4f36a4a43601ea90561e17e5ca6