Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp918321iob; Wed, 4 May 2022 10:36:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxrX8DrcoOc70sQYc8vxMp0qo0PGen1BhZZMzEMjpMdenW/e3riaXtEXdp4hdx1Oa+A9b5R X-Received: by 2002:a17:902:7d81:b0:14f:e18b:2b9e with SMTP id a1-20020a1709027d8100b0014fe18b2b9emr22306309plm.160.1651685815102; Wed, 04 May 2022 10:36:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651685815; cv=none; d=google.com; s=arc-20160816; b=fZ73VXFFeKl9PXOQ5GbeJpBqpSazdweXoiwMDfCasI20W5TSKW4rnwRAje36CHJ1j9 aAB5HAld8JpZ9j0FlpbG9vWDebDpTk9B24kwsgPvGcstTlJ8a6+H7JcwxhvnkfF4mlnM sionHtHU+fTrmPUs2KXpbq39o8qFYwuTmOq4x/iTwD6gVZz4Woq7u+YqWiCsWM7oBgTS 5cYm2M8RzsrxCV+9PDjsc1A6Any77/OqGqR+ZjRMZG2MNb/yf92EiXUUF4e+bVJgP08K aYMbU0Bp67G7zFgZEprxjkU7n7XAvP16lUJAnn6L39u0O7EYllxnLHFbVLU6NZWqjHsN gzcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=VC9wQ2arxRLTMlC7SE4ykRaDeym9oudqai2cOUp0Oxo=; b=dRdWs5WlfmaL5sgI7kJvM94vvLHLRxY12Y9/86jx1ZZKmdM4OyX8oses5wWXbD8/Wc IuLooz2K+FAviK2C4llMHZpMeKp2UuY4By/F+SEn90HmMKOULNc6WS9PQIGACpqsHhgA it8vM345A4vBtTre1REDQgSzgpLAAXN5tDSyFi3uVaUKRGM2vssyrmaMh/AYVm4YkV2g ew4gWaSQOOV7qPwxOrFa5C2qqRfvd44WI+Kt0a/n2PR8p+ELuDDrjSXh7O1s1tjMAvNA uCWj67ul9WBvduKUc8tz0SWAQh7OZRX26ZMzFJbbGwKHKwBh66cGg0x9g+995J32UFXu RwrQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Lg3a9GYj; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n4-20020a635c44000000b003c60870c831si466098pgm.394.2022.05.04.10.36.42; Wed, 04 May 2022 10:36:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Lg3a9GYj; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351504AbiEDQJo (ORCPT + 68 others); Wed, 4 May 2022 12:09:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231483AbiEDQJn (ORCPT ); Wed, 4 May 2022 12:09:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A883725C7B; Wed, 4 May 2022 09:06:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4303E60C37; Wed, 4 May 2022 16:06:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 181E5C385A4; Wed, 4 May 2022 16:06:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651680365; bh=mIu6gvR8TfoKz5CSa/RJWBPrsb5yAhojeG77OoPZbZ8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Lg3a9GYj9QSXNXBy62fQfvr7vDl8PPnqDYyWHWIsWbU5RdJWL7ytXsZqOmne4GJe+ EweVMY6JUHC1e86/QwLT5AofNVt/r3ms1o2lb1SZdyVhGgdjqk6+0OItLliYI5GFWq jTHOLvSPOAEJFWUZvTSg/1ISqlhFfnEWWxLcd+GKHIAtZagtajytritLohV2Zgfos7 OTY3IU+qGg15iV0QVRL1gWbOxnopiOb765IuXAUAco7ibp/f7I21b4Fecle8Sgwe8o sepuRDCrlUuYDUd50nt252yGyNfZpPAnL2yViqgFNf3eOvL9lHoyZJIvNyIQQOHYTF 8BWXghoaCh0Gg== From: Kalle Valo To: Dan Carpenter Cc: Stefano Brivio , Jaehee , =?utf-8?B?SsOpcsO0bWU=?= Pouiller , "David S. Miller" , Jakub Kicinski , Paolo Abeni , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Outreachy Linux Kernel Subject: Re: [PATCH] wfx: use container_of() to get vif References: <20220418035110.GA937332@jaehee-ThinkPad-X1-Extreme> <87y200nf0a.fsf@kernel.org> <20220504093347.GB4009@kadam> <20220504135059.7132b2b6@elisabeth> <20220504132551.GD4009@kadam> Date: Wed, 04 May 2022 19:05:57 +0300 In-Reply-To: <20220504132551.GD4009@kadam> (Dan Carpenter's message of "Wed, 4 May 2022 16:25:51 +0300") Message-ID: <87o80d9tay.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Dan Carpenter writes: > On Wed, May 04, 2022 at 01:50:59PM +0200, Stefano Brivio wrote: >> And that it's *obvious* that container_of() would trigger warnings >> otherwise. Well, obvious just for me, it seems. > > :P > > Apparently it wasn't obvious to Kalle and me. My guess is that you saw > the build error. Either that or Kalle and I are geezers who haven't > looked at container_of() since before the BUILD_BUG_ON() was added five > years ago. Exactly, I also had to duplicate the error myself before I was able to understand the issue. So I'm officially a geezer now :D -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches