Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Ajay.Kathat@microchip.com>
To:     <linux-wireless@vger.kernel.org>
CC:     <Claudiu.Beznea@microchip.com>, <Sripad.Balwadgi@microchip.com>,
        <Ajay.Kathat@microchip.com>
Subject: [PATCH 3/5] wilc1000: fix crash observed in AP mode with
 cfg80211_register_netdevice()
Thread-Topic: [PATCH 3/5] wilc1000: fix crash observed in AP mode with
 cfg80211_register_netdevice()
Thread-Index: AQHYX9K5kogwjz9cOUmXVoMCp0LCgw==
Date:   Wed, 4 May 2022 16:19:26 +0000
Message-ID: <20220504161924.2146601-3-ajay.kathat@microchip.com>
References: <20220504161924.2146601-1-ajay.kathat@microchip.com>
In-Reply-To: <20220504161924.2146601-1-ajay.kathat@microchip.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?Z12x0fwDKshR2y7608t7GY1CpUjRTH1JGrt6hxMmRdBFwWVA2M18kyumBd?=
 =?iso-8859-1?Q?yGQAroodd8cwA5FwXpXlJV/pMToj/9pTCIussybNYS0ULxptKWX7YUDP/y?=
 =?iso-8859-1?Q?IVCtMZgKo4esyVEPWhhNm5lqQPAS3bL6M3F2r+V8fVpGZQ1CR5TYUz6lE8?=
 =?iso-8859-1?Q?gb3+vL3Xjk7uETpT33qzdg7vG4WA2Xr54se6K++PungsNqXHrQnOeSVu3H?=
 =?iso-8859-1?Q?jc6r3yE6+60Us2eAUflBUjrv7ScaKa2MpVbBUGUxqer82OrrQLJN4xXbnr?=
 =?iso-8859-1?Q?L7he40n4/FKxTR2nPfMFKXfm4kq07yquVa8ownQXgSICuBIIk2bgWrTQ1c?=
 =?iso-8859-1?Q?so1tbt6RcGLbOTcCIXWsrPM/L58evJU+7fgzA3MBVW23rDfKB++uI93psq?=
 =?iso-8859-1?Q?8D0waD170RYBbyfBff4KFJMDPAz+pl3CJjG0sX3a0oBa7ZaiMAGnQ+U89e?=
 =?iso-8859-1?Q?uH2gJ8qITFL8yPd9IcsV3Tk2b0u6UORNpsxNZpq8DsDBvXy8GUCXSgYAJQ?=
 =?iso-8859-1?Q?Wr5qLOv94Gcpgy40pn/++7azoOF1HCGbj0YX/E9ABNYFC0m8S0GaDI6g4V?=
 =?iso-8859-1?Q?BhR++eqiOKvT3HbH5Vaj8jtfh7ViO8w/8I0Ke0n+/2ATO92IkjMAOGNItK?=
 =?iso-8859-1?Q?ECMyBBx30enxwstlAumz/lkvRpevq7+Nj9lHLb3HS9e/dWRBqq4rSj/gcg?=
 =?iso-8859-1?Q?mZrJYlAbezPdVOVddPVQ9alio/zOzQJebkQEyFgy0k1HA6aZyrVfVK7DKu?=
 =?iso-8859-1?Q?qAi48no3vfikBknpdkN8JYhZqiRsu9nhQnINUe9bZUas+rgsabpqB2uFBu?=
 =?iso-8859-1?Q?fyKJ5h9bS55xcExn+rYxMpqySSyIEz7a6zSI57Tc9wmPQuC79vMPYSHeMj?=
 =?iso-8859-1?Q?iqIfHuKfU8MMpSiumC3xz7LuyMC3R4vLYf3jC1WOHW8g1qa47rtAY1DfXI?=
 =?iso-8859-1?Q?ZnCm0D7r586PagJjzyH5gLchl4oiOBa00MhnBjQ/LxJAxOHdQ92wKegIo5?=
 =?iso-8859-1?Q?FumWoz/06M8ShfmuuJMUWri/qaexvByeQSTNHhKXvP1YUYKzckbi4iSW7U?=
 =?iso-8859-1?Q?3HbGWlvgdsVQU+Dgx394m6BMcpXt2huMOiRjWHQ6uaM1pSRqlnLvYmuP2A?=
 =?iso-8859-1?Q?ZBBMWhmqBL897kLx7kaLBWT7csZM5opWtARJGSsCqZF/emQo18cVeLX40U?=
 =?iso-8859-1?Q?6tanlxDcddwOxl+AGwgCr6X4sCEzWIlwE3qR/fpbfcxEq45mhfFlOrACTZ?=
 =?iso-8859-1?Q?PfdifxXlVxBkp+GXddN6VVpeQWlt0piD62/DkXv7o3AmAen8a2KC8Dm+aC?=
 =?iso-8859-1?Q?4z6TPEmKq1KD9yw0VmrhhYFIR2AltmWSPcrxkSBLt474zyPiuRMpKM8eQC?=
 =?iso-8859-1?Q?Ey9qNaJBn1YJusKDcypYKYWt8tOgrHwUntsOTOfzr60631Kvq9SUzkFtu8?=
 =?iso-8859-1?Q?orOUxq9sFOkUJYR1+XLBTbvnNjW6e9+teYoLGUGwXi84wOOnE3+JEbMqQB?=
 =?iso-8859-1?Q?klrOh7TRHwrVumr8pVEa7hvG9KIjGE7bxNbQFyu/sx/JWWPHjpMjsnyUMK?=
 =?iso-8859-1?Q?lIVZka/GhjGflMp38HxC//mMOeefj3wkoNVSp+StjmaCosAs8gIxlc0Mc+?=
 =?iso-8859-1?Q?NFqn+giAXrFZLKVHZhOWvE+koN1Ex5ds9NP68xrB52y7afXuO1tOTkYtmW?=
 =?iso-8859-1?Q?D8wI2e29MjFz4uPiJRVXSujDPPlTbR2XhmKJvIZvKdL5aqhwtGbLJrXn3i?=
 =?iso-8859-1?Q?wJze6avYu6J90EHulbZNf9WLU+Cw1m4qGc6ic1FOtZ4s5meqZBSjBNr47z?=
 =?iso-8859-1?Q?ea7sLAIUc9KW/NZGqQXggREeO8ADJEeVkJIQww01TJreUAoh/ayk?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5176.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9cd09fed-f918-49fc-2004-08da2de9dbce
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 May 2022 16:19:26.4382
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: lGjSsG9H1x6dq7x1NEXir5wL7WUQxiENHcI4vFcqJq8V0S+urqQQ6qLztFzixdojl3spxddZbxv01IRiGOQeJUEP1EiZL5jV9Yf/Ve8APlY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5597
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

From: Ajay Singh <ajay.kathat@microchip.com>

Monitor(mon.) interface is used for handling the AP mode and 'ieee80211_ptr=
'
reference is not getting set for it. Like earlier implementation,
use register_netdevice() instead of cfg80211_register_netdevice() which
expects valid 'ieee80211_ptr' reference to avoid the possible crash.

Fixes: 2fe8ef106238 ("cfg80211: change netdev registration/unregistration s=
emantics")
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
---
 drivers/net/wireless/microchip/wilc1000/mon.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/microchip/wilc1000/mon.c b/drivers/net/wi=
reless/microchip/wilc1000/mon.c
index 6bd63934c2d8..b5a1b65c087c 100644
--- a/drivers/net/wireless/microchip/wilc1000/mon.c
+++ b/drivers/net/wireless/microchip/wilc1000/mon.c
@@ -233,7 +233,7 @@ struct net_device *wilc_wfi_init_mon_interface(struct w=
ilc *wl,
 	wl->monitor_dev->netdev_ops =3D &wilc_wfi_netdev_ops;
 	wl->monitor_dev->needs_free_netdev =3D true;
=20
-	if (cfg80211_register_netdevice(wl->monitor_dev)) {
+	if (register_netdevice(wl->monitor_dev)) {
 		netdev_err(real_dev, "register_netdevice failed\n");
 		free_netdev(wl->monitor_dev);
 		return NULL;
@@ -251,7 +251,7 @@ void wilc_wfi_deinit_mon_interface(struct wilc *wl, boo=
l rtnl_locked)
 		return;
=20
 	if (rtnl_locked)
-		cfg80211_unregister_netdevice(wl->monitor_dev);
+		unregister_netdevice(wl->monitor_dev);
 	else
 		unregister_netdev(wl->monitor_dev);
 	wl->monitor_dev =3D NULL;
--=20
2.25.1