Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f8502bac-9b02-ac0d-3d0c-759fbddfa1fc@nbd.name>
Date:   Thu, 5 May 2022 14:28:25 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.9.0
Subject: Re: [PATCH 4/4] mt76: mt7915: limit minimum twt duration
Content-Language: en-US
To:     Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
        Peter Chiu <chui-hao.chiu@mediatek.com>
Cc:     Ryder Lee <ryder.Lee@mediatek.com>,
        Evelyn Tsai <evelyn.tsai@mediatek.com>,
        Shayne Chen <shayne.chen@mediatek.com>,
        linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org
References: <20220505082554.16656-1-chui-hao.chiu@mediatek.com>
 <20220505082554.16656-4-chui-hao.chiu@mediatek.com>
 <YnPBz8uB6A5kAPRs@lore-desk>
From:   Felix Fietkau <nbd@nbd.name>
In-Reply-To: <YnPBz8uB6A5kAPRs@lore-desk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 05.05.22 14:23, Lorenzo Bianconi wrote:
>> The minimum twt duration supported by mt7915 is 64 according to hardware
>> design. Reply station with TWT_SETUP_CMD_DICTATE if min_twt_dur smaller
>> than 64.
>> 
>> Signed-off-by: Peter Chiu <chui-hao.chiu@mediatek.com>
>> ---
>>  drivers/net/wireless/mediatek/mt76/mt7915/mac.c | 7 +++++++
>>  1 file changed, 7 insertions(+)
>> 
>> diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c
>> index ff60a3d2d26d..e912ecacb578 100644
>> --- a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c
>> +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c
>> @@ -2633,6 +2633,7 @@ void mt7915_mac_add_twt_setup(struct ieee80211_hw *hw,
>>  			      struct ieee80211_sta *sta,
>>  			      struct ieee80211_twt_setup *twt)
>>  {
>> +#define MT7915_MIN_TWT_DUR 64
> 
> nit: can you please move MT7915_MIN_TWT_DUR in mt7915.h since we have other twt
> defs there?
Fixed in my tree.

- Felix