Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 5 May 2022 14:22:03 +0200
From:   Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To:     Peter Chiu <chui-hao.chiu@mediatek.com>
Cc:     Felix Fietkau <nbd@nbd.name>, Ryder Lee <ryder.Lee@mediatek.com>,
        Evelyn Tsai <evelyn.tsai@mediatek.com>,
        Shayne Chen <shayne.chen@mediatek.com>,
        linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 3/4] mt76: mt7915: reject duplicated twt flows
Message-ID: <YnPBaw1d3nA791PP@lore-desk>
References: <20220505082554.16656-1-chui-hao.chiu@mediatek.com>
 <20220505082554.16656-3-chui-hao.chiu@mediatek.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="JuvCUEvvWg5UF+kk"
Content-Disposition: inline
In-Reply-To: <20220505082554.16656-3-chui-hao.chiu@mediatek.com>
Precedence: bulk


--JuvCUEvvWg5UF+kk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> Reject twt flows with the same parameters to prevent some potential issues
> causing by duplicated establishment.
>=20
> Reviewed-by: Ryder Lee <ryder.lee@mediatek.com>
> Reviewed-by: Shayne Chen <shayne.chen@mediatek.com>
> Signed-off-by: Peter Chiu <chui-hao.chiu@mediatek.com>
> ---
>  .../net/wireless/mediatek/mt76/mt7915/mac.c   | 31 +++++++++++++++++++
>  1 file changed, 31 insertions(+)
>=20
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c b/drivers/ne=
t/wireless/mediatek/mt76/mt7915/mac.c
> index 94a1871fbf43..ff60a3d2d26d 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c
> @@ -2601,6 +2601,34 @@ static int mt7915_mac_check_twt_req(struct ieee802=
11_twt_setup *twt)
>  	return 0;
>  }
> =20
> +static inline bool
> +mt7915_mac_twt_param_equal(struct mt7915_sta *msta,
> +			   struct ieee80211_twt_params *twt_agrt)

nit: please do not use inline in .c files.

Regards,
Lorenzo

> +{
> +	u16 type =3D le16_to_cpu(twt_agrt->req_type);
> +	u8 exp;
> +	int i;
> +
> +	exp =3D FIELD_GET(IEEE80211_TWT_REQTYPE_WAKE_INT_EXP, type);
> +	for (i =3D 0; i < MT7915_MAX_STA_TWT_AGRT; i++) {
> +		struct mt7915_twt_flow *f;
> +
> +		if (!(msta->twt.flowid_mask & BIT(i)))
> +			continue;
> +
> +		f =3D &msta->twt.flow[i];
> +		if (f->duration =3D=3D twt_agrt->min_twt_dur &&
> +		    f->mantissa =3D=3D twt_agrt->mantissa &&
> +		    f->exp =3D=3D exp &&
> +		    f->protection =3D=3D !!(type & IEEE80211_TWT_REQTYPE_PROTECTION) &&
> +		    f->flowtype =3D=3D !!(type & IEEE80211_TWT_REQTYPE_FLOWTYPE) &&
> +		    f->trigger =3D=3D !!(type & IEEE80211_TWT_REQTYPE_TRIGGER))
> +			return true;
> +	}
> +
> +	return false;
> +}
> +
>  void mt7915_mac_add_twt_setup(struct ieee80211_hw *hw,
>  			      struct ieee80211_sta *sta,
>  			      struct ieee80211_twt_setup *twt)
> @@ -2634,6 +2662,9 @@ void mt7915_mac_add_twt_setup(struct ieee80211_hw *=
hw,
>  	exp =3D FIELD_GET(IEEE80211_TWT_REQTYPE_WAKE_INT_EXP, req_type);
>  	sta_setup_cmd =3D FIELD_GET(IEEE80211_TWT_REQTYPE_SETUP_CMD, req_type);
> =20
> +	if (mt7915_mac_twt_param_equal(msta, twt_agrt))
> +		goto unlock;
> +
>  	flow =3D &msta->twt.flow[flowid];
>  	memset(flow, 0, sizeof(*flow));
>  	INIT_LIST_HEAD(&flow->list);
> --=20
> 2.18.0
>=20

--JuvCUEvvWg5UF+kk
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCYnPBawAKCRA6cBh0uS2t
rE7yAQCwyZ8EMpuBz+ESZCMKM1SaVuEgp5HBcs74ZdVEEI3b+AD9E449nVB0v8VY
ZsqEefKcfYF7Jgq4zv0aEX8FR+2VdAE=
=3L4/
-----END PGP SIGNATURE-----

--JuvCUEvvWg5UF+kk--