Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <40b8ad06-6ef2-113c-fffb-2fa001603b3f@suse.com>
Date:   Thu, 5 May 2022 10:22:40 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 0/7] PM: Solution for S0ix failure caused by PCH
 overheating
Content-Language: en-US
To:     Zhang Rui <rui.zhang@intel.com>, rjw@rjwysocki.net,
        kvalo@kernel.org, alexandre.belloni@bootlin.com
CC:     linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org,
        linux-rtc@vger.kernel.org, linux-wireless@vger.kernel.org,
        daniel.lezcano@linaro.org, merez@codeaurora.org, mat.jonczyk@o2.pl,
        sumeet.r.pawnikar@intel.com, len.brown@intel.com
References: <20220505015814.3727692-1-rui.zhang@intel.com>
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <20220505015814.3727692-1-rui.zhang@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lR3xHP/FD4NJ9Tb1UoziAUtMMg+SoV9+Wlr8g9azKjfjASAQMcR7bVgHEUul?=
 =?us-ascii?Q?f85XGXEvE/bfSjbhDB63D3X8a707o5MsZwzpWiRSWGujEY8rzLVRvxADdsj+?=
 =?us-ascii?Q?R0T0mpXW0+ew4W3aJHoLcAke3T1eJsHYD9qEAX3j0WhmepuyGOmXRiY/8/Kb?=
 =?us-ascii?Q?7+uzwvZr27CtgWh9nKK9e5f8aLKIrPctKA/O3GE1zT7bm5Lk2n4sets0uoWw?=
 =?us-ascii?Q?SXfOdXK5MCX2b7WE3S/mQ69HHbgFna7GvfQHMdfPg8lNr9YcNQVO/Ti3xInv?=
 =?us-ascii?Q?2kea4RFRGzbUKlrozVt2879bIeQNqyvZT2jUy04godCrwvPv8jL/DAVnzerd?=
 =?us-ascii?Q?gcUwAmJKDwRQUXuCkIwoNVkHMNH3tPONG1qUipwoyYDT7j1Ux897P4D5BwUr?=
 =?us-ascii?Q?DduZUeCog12jn414oioE+kspLzzVahkYlGhDVUNHHYJgmVoI6Ha1Lgy2Z0ka?=
 =?us-ascii?Q?782dVsUmjVxj8Z4KPGRE20Jr3qgffkltd1956ACjyR2093WQY5OukbyBTOsY?=
 =?us-ascii?Q?LQ/YwdXBeG7IxSTH4+bA/b9g9fVDAfqmsozjGB++FzVM68j49wjDPmjHv/BK?=
 =?us-ascii?Q?6EZUkCDRmc0WDqn54awCuOOhdwVcBArC4qDjHlAnWSdPgI8Wb6R1srZRjEso?=
 =?us-ascii?Q?giJCk7hZF+5ytCzD25gHDfQBBX5mVeZ0ZTZT+HLJMo18VYaxOg9hOppKzo59?=
 =?us-ascii?Q?kFTM1ySYjgNcUjphpkQwaO4PchjWLj3EO8362GobQ0VRQ0/B4R3Jv8L8Cph9?=
 =?us-ascii?Q?Msx+wmQV6rG5Eys5icxbrq+AGPbDVL4BkN+rD6YH+TCfo0A0Ubul3PAF5Ild?=
 =?us-ascii?Q?RNk11ngvTDk7vLrwfpSMtYqv5eQyv0SfGWcLfXTI2SV4G6XoXBIlTeAnMjl6?=
 =?us-ascii?Q?PEtiQWftvOYMI0My5u2x8cP6vJzzoTjTtKENtOkjjLtnZDJOPEpC602/1HUA?=
 =?us-ascii?Q?7tK23NhSy8FW5ifuyHqfEYOHbHgxiZGQzG1DTCfFGw43tF4gb2iLpM4wgtY2?=
 =?us-ascii?Q?M/WEJk+eXdbnyBNg7Jm4Ctz7d5PyCP0GN3pqzq+FQ6RGHeKP6eLPhkCEAjqU?=
 =?us-ascii?Q?6zg2wLgPuGj88NjNapHMKjrNhXmhqTsq1keaQwKv6WHU0lpUzoK/tKA6SGO4?=
 =?us-ascii?Q?fppAx462ETdva4ozs/bAt3W/vLRbNZqaGKr+IMSQtpQ2CRO0dJ6pqOefSli5?=
 =?us-ascii?Q?6eM9fNscWh6+7QAD5859FNE3jpliARjHD+UIi/3TOii3UFMyrcErBJNXzpmN?=
 =?us-ascii?Q?MFBZFEDxPeia/dtK69oEAmiJMhYTnpDX1z1aCym4gNk9qu2PF4JucMbOYFWA?=
 =?us-ascii?Q?/Z6dePjj2DzXJKc3r9L/w0Q+tTg5N8Sn8WoeqlVw2oRgWvB7CMZ47Mv3naUD?=
 =?us-ascii?Q?m2McAAmHbiA02Zt87FU9TgzS3nwPuXpYkNoU4yk0+ZwCIkaMq3VT/SGbctQ8?=
 =?us-ascii?Q?EReDOAY+N1Fl/c020eytPWpdviaQz6qpO5upICXbNoKzpegz1OJZww6MxiB0?=
 =?us-ascii?Q?IsO8YExUn4zBJOP3WM0eFp0LdOzfyzdViwKcpjYT0Qvdmxtqphv7mFW+Tf2F?=
 =?us-ascii?Q?RUf0A/l5MvQdyLcB/f20cHnS1ULtYWsWYUAAOxyPkYRSSSHGQhSsujUV5JQI?=
 =?us-ascii?Q?fun6pZI8A91ygunGlqMbi8+CH1tmaVPW7Uw1R/4Es5w4UhqSunBKTFnfE1Ye?=
 =?us-ascii?Q?8T5ozUxVtpXwUcg4q/J8OISSu2FpjOWn+dtoV8LO04uuMD6kcVxU89XtJ+ZS?=
 =?us-ascii?Q?/ZyU4r4fq6wnfO4EatbBZx8kBD2bHqAzbDmYwckuwv+op/WUSUvGC28tELpt?=
X-MS-Exchange-AntiSpam-MessageData-1: QhqSC8o2YsE61Q==
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 27a6ec71-f522-497e-7ded-08da2e706cdc
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0401MB2526.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 08:22:43.1450
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eSCoT+A5QxWQMpqqVH5LggQeEMnhlMlAMiumfivwIGrmn+KGkutHK5FOynMA2EkO6uB/8hRyqyD/MU4yPIZEIQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6592
X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org


On 05.05.22 03:58, Zhang Rui wrote:
> On some Intel client platforms like SKL/KBL/CNL/CML, there is a
> PCH thermal sensor that monitors the PCH temperature and blocks the syste=
m
> from entering S0ix in case it overheats.
>
> Commit ef63b043ac86 ("thermal: intel: pch: fix S0ix failure due to PCH
> temperature above threshold") introduces a delay loop to cool the
> temperature down for this purpose.
>
> However, in practice, we found that the time it takes to cool the PCH dow=
n
> below threshold highly depends on the initial PCH temperature when the
> delay starts, as well as the ambient temperature.

>
> This patch series has been tested on the same Dell XPS 9360 laptop and
> S0ix is 100% achieved across 1000+ s2idle iterations.
>
Hi,

what is the user experience if this ever triggers? At that stage the
system will appear to be suspended to an external observer, won't it?
So in effect you'd have a system that spontaneously wakes up, won't you?

=C2=A0=C2=A0=C2=A0 Regards
=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 Oliver