Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp3868328iob; Sat, 7 May 2022 18:32:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy6/p1p/zfdCyYs8VjnwfFUWKQK6i6Hglivn+b+gfQONLxl53FMWk9ABmhC787E2PMNeNFo X-Received: by 2002:a63:8348:0:b0:3c6:8345:8805 with SMTP id h69-20020a638348000000b003c683458805mr3198516pge.422.1651973520376; Sat, 07 May 2022 18:32:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651973520; cv=none; d=google.com; s=arc-20160816; b=BQ345qvTFacZJyTN+8Z+QCpI1gp+tsHUNuy2+GbE5tUG3OvxUHMspPjWG6UP+ONy0M LLSlJBCPemhs7sDYpozisM4yqvXF2nw1qxkovkV+2epTJxVhQFPwZKm7TTnF0WkgH3KY xgi70n4iEVbV234zZRkGZLPG7Q2JcB+7b3l3QC+pGHzaMC9ZYwPGec4yPfA9CukHsccP 9cJV+XmSvgwxQgi4kH9nkg/d2N/4r0GRWlg4Av5YYsF5IdHejrdsgn/H9XpvLf4DXXHW e2mrrD6RfWGD2HLdXw385Kwy5GElA8jkBqH+SfWZbG/fIesmnMYcouScBDCio/vMwwxf +DfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=6K3FhPasgUzSaU/OmGtcCnFeLokRAoKZ4RBJ1sDfmKc=; b=eyZlicOvUFZg7AQrS6h0Twez1Tdrq2S9ocRkZAsGH792g7Ywqy8NkynTroOhZQ/NhL QAnsIxYkkujuTE57n3nKXFYIrfXT1ARHD8DseKo+AApp14C/zRIHbOoKoWWtSyV3W8DH G6DUpILlVRuOt/iER6i/LZ7gKrouk0D9O8K+18VEvVlMv/4TK8rtzYSsLavxlbI2TENn mq/Qdashb8w2x5CvVVWSn5HTyGmx0Mn1LorKVSL9+oe6/aY9ORUM22PO50Bzr3RD147f B1Jgmw+G1oquUosYu50sMPZAIgf1XzcTtHorA23/D3sTxlL6x+AofRR/ukzPhewBV0Lc STWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=bGbrxpAn; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s7-20020a17090302c700b0015d078de5b9si6809579plk.30.2022.05.07.18.31.40; Sat, 07 May 2022 18:32:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=bGbrxpAn; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245084AbiEES51 (ORCPT + 68 others); Thu, 5 May 2022 14:57:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351958AbiEES5W (ORCPT ); Thu, 5 May 2022 14:57:22 -0400 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7C57396A9 for ; Thu, 5 May 2022 11:53:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1651776819; x=1683312819; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=6K3FhPasgUzSaU/OmGtcCnFeLokRAoKZ4RBJ1sDfmKc=; b=bGbrxpAnSTAl/21WFbKvgeU6CW55PwjEYbkhRH2Vqg2Z3vSIdy5ihPyV KxHBKXQlCarUT28cswcHI8frc/pXvG3ChMIVs8bDGgxsh+p1d/ZvsK/We vHh4b8wuI8GKzQcFXP0n0Eqc5WIdDySHK/4U+0Ql6B8c+ZR21LI/JqqQe g=; Received: from unknown (HELO ironmsg01-sd.qualcomm.com) ([10.53.140.141]) by alexa-out-sd-01.qualcomm.com with ESMTP; 05 May 2022 11:53:39 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg01-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2022 11:53:39 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Thu, 5 May 2022 11:53:39 -0700 Received: from [10.110.125.2] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Thu, 5 May 2022 11:53:38 -0700 Message-ID: <70b3bf3f-4b34-149a-ce1c-a8e857c6a3ac@quicinc.com> Date: Thu, 5 May 2022 11:53:37 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 2/3] ath11k: Don't check arvif->is_started before sending management frames Content-Language: en-US To: Baochen Qiang , CC: References: <20220505013851.1548789-1-quic_bqiang@quicinc.com> <20220505013851.1548789-3-quic_bqiang@quicinc.com> From: Jeff Johnson In-Reply-To: <20220505013851.1548789-3-quic_bqiang@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 5/4/2022 6:38 PM, Baochen Qiang wrote: > Commit 66307ca04057 ("ath11k: fix mgmt_tx_wmi cmd sent to FW for > deleted vdev") wants both of below two conditions are true before > sending management frames: > > 1: ar->allocated_vdev_map & (1LL << arvif->vdev_id) > 2: arvif->is_started > > Actually the second one is not necessary cause with the first one nit: s/cause/because/