Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp4395059iob; Sun, 8 May 2022 11:15:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwHPK47VpbMlNCjsZEOvOfLAi/fm9PMUzVA0wUbB9i8V9Nt5wqeGBN0kmSbBNHnk1lopcSD X-Received: by 2002:a05:6402:3292:b0:427:b4c9:6522 with SMTP id f18-20020a056402329200b00427b4c96522mr13625219eda.406.1652033758752; Sun, 08 May 2022 11:15:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652033758; cv=none; d=google.com; s=arc-20160816; b=nV7FzkaMVtPkYbTvcP8P2cJdGHNVykDP+VqHtPSQE/11P7tBId/ckr82FZtFiFh3Ya ncWkl6xLJczqRkExig8t6EjzoquE/IRmgYihwj3rm2GzECL8d/iD6QcG0nKbqy0nX5ST i6fCmjhAXjru7nVhLj6XHyCIP9qfQWzxB/msp/gijwcHa1cn6fNgZMegBdr56ODUH/JN Xxz9j40W+qb76smdS+yJ5NiQD+Ps1VeXNP+FSh4kcf4n1Uu1fet6R0f8T6GP/hLpH0mv vwAtndGOhNSnZfA4pNglSvZdSkKSqKIh1D/VeI4cd32cfqVIXJYEcVik7YcWf2hpEdmi LH7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=1RJ168iv1bTSwYVxSKxXDs5SZ7Oy7zBPAzxRcvnaTYI=; b=w/k6X7lytOFMEaS9STBOlGrgHcO/zh8KAuFgDjmrCJAVtbi2TIJ7UtiwJrTKS5yu65 4Jf/LAkzRdB2FmbXqrzwSQFVUPwI4fu07eMUDdwrsoTBeueG0o4zfkgpzTKAC7tZmgrt rw2uSHOrj+LmLlebpYw57NqUmff99xlxBEgRxRCwwhh2WZ0qaAAr7MYN3Ltdox5mXKwK 3i4GHmfzRo9NEuDJUtNp4HXgyBSiJ60latRC0KqQQmT/B3LXlV81FH5GOS29xIAz/Qxp CGHbUyYCcQUppwFPkkLw+9ZI/acrGvA4YAxvvJQauIPfBAKkSK2D1jdsgLdalC/TQlUN Qurw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=wJSZmx27; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bt24-20020a170906b15800b006e8c5874098si10968249ejb.43.2022.05.08.11.15.14; Sun, 08 May 2022 11:15:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=wJSZmx27; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1380180AbiEFBfD (ORCPT + 68 others); Thu, 5 May 2022 21:35:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232969AbiEFBfC (ORCPT ); Thu, 5 May 2022 21:35:02 -0400 Received: from alexa-out.qualcomm.com (alexa-out.qualcomm.com [129.46.98.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2BAF1EEC7 for ; Thu, 5 May 2022 18:31:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1651800681; x=1683336681; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=1RJ168iv1bTSwYVxSKxXDs5SZ7Oy7zBPAzxRcvnaTYI=; b=wJSZmx27gbm4zIIyxZrLNFF8wqPK0oll0wbzg4PIKavKU7xU9+rrg0fY Y8R9MdcgVc+2tfMItkXb4juHDLjDcpHFWEormdq4QXm6A6ZgBdby0nhaY QgyG/axvBMXS6l7DKsHASf1mZr3U6tH/wA4Xzz3AfAGMO0vepBDfXz2gK c=; Received: from ironmsg07-lv.qualcomm.com ([10.47.202.151]) by alexa-out.qualcomm.com with ESMTP; 05 May 2022 18:31:21 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg07-lv.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2022 18:31:21 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Thu, 5 May 2022 18:31:20 -0700 Received: from [10.253.34.102] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Thu, 5 May 2022 18:31:19 -0700 Message-ID: <23e17fea-57f6-3908-c373-fbfcb766f25d@quicinc.com> Date: Fri, 6 May 2022 09:31:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 2/3] ath11k: Don't check arvif->is_started before sending management frames Content-Language: en-US To: Jeff Johnson , CC: References: <20220505013851.1548789-1-quic_bqiang@quicinc.com> <20220505013851.1548789-3-quic_bqiang@quicinc.com> <70b3bf3f-4b34-149a-ce1c-a8e857c6a3ac@quicinc.com> From: Baochen Qiang In-Reply-To: <70b3bf3f-4b34-149a-ce1c-a8e857c6a3ac@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 5/6/2022 2:53 AM, Jeff Johnson wrote: > On 5/4/2022 6:38 PM, Baochen Qiang wrote: >> Commit 66307ca04057 ("ath11k: fix mgmt_tx_wmi cmd sent to FW for >> deleted vdev") wants both of below two conditions are true before >> sending management frames: >> >> 1: ar->allocated_vdev_map & (1LL << arvif->vdev_id) >> 2: arvif->is_started >> >> Actually the second one is not necessary cause with the first one > > nit: s/cause/because/ > Thanks Jeff, will address it in v2.